Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

On April 21, 2015, 9:47 p.m., David Edmundson wrote: lookandfeel/contents/components/InfoPane.qml, line 47 https://git.reviewboard.kde.org/r/123459/diff/1/?file=362312#file362312line47 there's a visible here. If your two lines are needed, this isn't. Or

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- (Updated April 24, 2015, 6:22 p.m.) Review request for Plasma. Changes

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

On April 22, 2015, 3:46 vorm., Kai Uwe Broulik wrote: -1 that's what the visible: pmSource.data[Battery][Has Cumulative] is for. there just used to be a bug where that property wasn't created in the first place if no battery was present leading to an exception causing the item to

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- (Updated April 24, 2015, 6:20 p.m.) Review request for Plasma. Bugs:

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

On April 22, 2015, 3:46 a.m., Kai Uwe Broulik wrote: -1 that's what the visible: pmSource.data[Battery][Has Cumulative] is for. there just used to be a bug where that property wasn't created in the first place if no battery was present leading to an exception causing the item to

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

On April 22, 2015, 3:46 a.m., Kai Uwe Broulik wrote: -1 that's what the visible: pmSource.data[Battery][Has Cumulative] is for. there just used to be a bug where that property wasn't created in the first place if no battery was present leading to an exception causing the item to

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

On April 22, 2015, 3:46 a.m., Kai Uwe Broulik wrote: -1 that's what the visible: pmSource.data[Battery][Has Cumulative] is for. there just used to be a bug where that property wasn't created in the first place if no battery was present leading to an exception causing the item to

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- (Updated April 24, 2015, 7:02 p.m.) Status -- This change has been

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

On April 22, 2015, 3:46 vorm., Kai Uwe Broulik wrote: -1 that's what the visible: pmSource.data[Battery][Has Cumulative] is for. there just used to be a bug where that property wasn't created in the first place if no battery was present leading to an exception causing the item to

Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- Review request for Plasma. Bugs: 346441

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/#review79321 --- -1 that's what the visible: pmSource.data[Battery][Has

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/#review79311 --- lookandfeel/contents/components/InfoPane.qml (line 47)

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/#review79312 --- Ship it! Ship It! - Lukáš Tinkl On Dub. 21, 2015, 11:18