Re: Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-29 Thread Aleix Pol Gonzalez
> On April 30, 2015, 1:02 a.m., Mark Gaiser wrote: > > Pushed. But slightly different then was reviewed here. > > I added the define which subsequently gave me two more issues of the same > > nature in kioclient (cat and openProperties). > > I've fixed those as well and changed the commit messag

Re: Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/#review79701 --- Pushed. But slightly different then was reviewed here. I added

Re: Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/ --- (Updated April 29, 2015, 10:56 p.m.) Status -- This change has been

Re: Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/#review79694 --- Ship it! Ship It! - David Faure On April 28, 2015, 6:18 p.

Re: Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-28 Thread Mark Gaiser
> On apr 28, 2015, 7:11 p.m., Aleix Pol Gonzalez wrote: > > Can you add add_definitions(-DQT_NO_URL_CAST_FROM_STRING)? > > > > That will help spotting these issues. Ok, will add that and commit later tonight or tomorrow. - Mark --- Thi

Re: Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/#review79645 --- Ship it! Can you add add_definitions(-DQT_NO_URL_CAST_FROM_ST

Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-28 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/ --- Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools