Re: Review Request 123770: Play the login sound in its own thread

2015-05-16 Thread Martin Klapetek
> On May 16, 2015, 7:13 p.m., Andreas Hartmetz wrote: > > Sorry, this has a major flaw: KNotification may pop up a window which is > > clearly not what you want as a login "sound". Worse, this window is created > > from a secondary thread which will cause an assertion to fail and kill > > ksms

Re: Review Request 123770: Play the login sound in its own thread

2015-05-16 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/#review80468 --- Sorry, this has a major flaw: KNotification may pop up a windo

Re: Review Request 123770: Play the login sound in its own thread

2015-05-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/ --- (Updated May 14, 2015, 6:03 p.m.) Status -- This change has been mar

Re: Review Request 123770: Play the login sound in its own thread

2015-05-14 Thread Martin Klapetek
> On May 13, 2015, 4:37 p.m., David Edmundson wrote: > > Ship It! > > Martin Klapetek wrote: > Stable? I'll push to master for now, we can cherry pick afterwards. - Martin --- This is an automatically generated e-mail. To reply, vi

Re: Review Request 123770: Play the login sound in its own thread

2015-05-13 Thread Martin Klapetek
> On May 13, 2015, 4:37 p.m., David Edmundson wrote: > > Ship It! Stable? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/#review80304 ---

Re: Review Request 123770: Play the login sound in its own thread

2015-05-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/#review80304 --- Ship it! Ship It! - David Edmundson On May 13, 2015, 10:09

Re: Review Request 123770: Play the login sound in its own thread

2015-05-13 Thread Martin Klapetek
> On May 13, 2015, 1:05 p.m., David Edmundson wrote: > > do you still have any backtraces of the original freeze? > > Martin Klapetek wrote: > I never had any, but Hrvoje and Mark had those problems as reported in > https://git.reviewboard.kde.org/r/118636/ [14:01:22] mck182: seems your p

Re: Review Request 123770: Play the login sound in its own thread

2015-05-13 Thread Martin Klapetek
> On May 13, 2015, 1:05 p.m., David Edmundson wrote: > > do you still have any backtraces of the original freeze? I never had any, but Hrvoje and Mark had those problems as reported in https://git.reviewboard.kde.org/r/118636/ - Martin ---

Re: Review Request 123770: Play the login sound in its own thread

2015-05-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/#review80290 --- do you still have any backtraces of the original freeze? - Da

Review Request 123770: Play the login sound in its own thread

2015-05-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/ --- Review request for Plasma. Repository: plasma-workspace Description ---