Re: Review Request 124204: Use proper relative paths to import js code

2015-12-29 Thread Kevin Ottens
> On Dec. 29, 2015, 1:36 p.m., Marco Martin wrote: > > this still seems to cause issues for some people. > > May this series of patches be worth to push anyways? > > David Edmundson wrote: > >this still seems to cause issues for some people. > > Where have you seen that? > I do

Re: Review Request 124204: Use proper relative paths to import js code

2015-12-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/ --- (Updated Dec. 29, 2015, 3:01 p.m.) Status -- This change has been di

Re: Review Request 124204: Use proper relative paths to import js code

2015-12-29 Thread Marco Martin
> On Dec. 29, 2015, 1:36 p.m., Marco Martin wrote: > > this still seems to cause issues for some people. > > May this series of patches be worth to push anyways? > > David Edmundson wrote: > >this still seems to cause issues for some people. > > Where have you seen that? > I do

Re: Review Request 124204: Use proper relative paths to import js code

2015-12-29 Thread David Edmundson
> On Dec. 29, 2015, 1:36 p.m., Marco Martin wrote: > > this still seems to cause issues for some people. > > May this series of patches be worth to push anyways? >this still seems to cause issues for some people. Where have you seen that? I don't recall seeing any bug reports. - David

Re: Review Request 124204: Use proper relative paths to import js code

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/#review90278 --- this still seems to cause issues for some people. May this ser

Re: Review Request 124204: Use proper relative paths to import js code

2015-07-01 Thread David Edmundson
> On June 29, 2015, 7:57 a.m., David Edmundson wrote: > > Was this causing an error? > > Kevin Ottens wrote: > Yes, most of the applets (see my other patches) were broken after my > update this week-end. I didn't update in a while previously. I noted that the > applets were inconsistent so

Re: Review Request 124204: Use proper relative paths to import js code

2015-07-01 Thread Marco Martin
> On June 29, 2015, 7:57 a.m., David Edmundson wrote: > > Was this causing an error? > > Kevin Ottens wrote: > Yes, most of the applets (see my other patches) were broken after my > update this week-end. I didn't update in a while previously. I noted that the > applets were inconsistent so

Re: Review Request 124204: Use proper relative paths to import js code

2015-07-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/#review81951 --- Ship it! Ship It! - Marco Martin On June 29, 2015, 7:15 a.

Re: Review Request 124204: Use proper relative paths to import js code

2015-07-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/#review81947 --- if that qml file is only supposed to be used in a plasmoid imp

Re: Review Request 124204: Use proper relative paths to import js code

2015-07-01 Thread Kevin Ottens
> On June 29, 2015, 7:57 a.m., David Edmundson wrote: > > Was this causing an error? > > Kevin Ottens wrote: > Yes, most of the applets (see my other patches) were broken after my > update this week-end. I didn't update in a while previously. I noted that the > applets were inconsistent so

Re: Review Request 124204: Use proper relative paths to import js code

2015-07-01 Thread Kevin Ottens
> On June 29, 2015, 7:57 a.m., David Edmundson wrote: > > Was this causing an error? > > Kevin Ottens wrote: > Yes, most of the applets (see my other patches) were broken after my > update this week-end. I didn't update in a while previously. I noted that the > applets were inconsistent so

Re: Review Request 124204: Use proper relative paths to import js code

2015-07-01 Thread David Edmundson
> On June 29, 2015, 7:57 a.m., David Edmundson wrote: > > Was this causing an error? > > Kevin Ottens wrote: > Yes, most of the applets (see my other patches) were broken after my > update this week-end. I didn't update in a while previously. I noted that the > applets were inconsistent so

Re: Review Request 124204: Use proper relative paths to import js code

2015-06-30 Thread David Edmundson
> On June 29, 2015, 7:57 a.m., David Edmundson wrote: > > Was this causing an error? > > Kevin Ottens wrote: > Yes, most of the applets (see my other patches) were broken after my > update this week-end. I didn't update in a while previously. I noted that the > applets were inconsistent so

Re: Review Request 124204: Use proper relative paths to import js code

2015-06-29 Thread Kevin Ottens
> On June 29, 2015, 7:57 a.m., David Edmundson wrote: > > Was this causing an error? Yes, most of the applets (see my other patches) were broken after my update this week-end. I didn't update in a while previously. I noted that the applets were inconsistent some using import "foo.js" (all brok

Re: Review Request 124204: Use proper relative paths to import js code

2015-06-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/#review81845 --- Theoretically Plasma should automatically use the code directo

Re: Review Request 124204: Use proper relative paths to import js code

2015-06-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/#review81844 --- Was this causing an error? - David Edmundson On June 29, 20

Review Request 124204: Use proper relative paths to import js code

2015-06-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/ --- Review request for Plasma. Repository: bluedevil Description --- U