---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124647/
---
(Updated Aug. 13, 2015, 12:38 p.m.)
Status
--
This change has been m
> On Aug. 13, 2015, 12:38 p.m., Bhushan Shah wrote:
> > Do you have commit rights or you want me to commit it for you?
>
> Luca Sartorelli wrote:
> Can you do it please, I don't have commit rigths. Thanks
Submitted with
http://commits.kde.org/plasma-mediacenter/4c242b2e04dbe6aaba5bd0766f2f
> On Aug. 13, 2015, 7:08 a.m., Bhushan Shah wrote:
> > Do you have commit rights or you want me to commit it for you?
Can you do it please, I don't have commit rigths. Thanks
- Luca
---
This is an automatically generated e-mail. To repl
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124647/#review83759
---
Do you have commit rights or you want me to commit it for you?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124647/#review83590
---
Ship it!
FindTaglib.cmake is also used in various other repos
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124647/
---
(Updated Aug. 7, 2015, 9:01 a.m.)
Review request for Plasma.
Changes
--
> On Aug. 6, 2015, 8:29 p.m., Rex Dieter wrote:
> > Wouldn't it be better to use VERSION_GREATER
> > (http://www.cmake.org/cmake/help/v3.0/command/if.html) rather than a string
> > compare?
That is great!, thank you for the smart suggestion, I didn't know about it
- Luca
--
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124647/#review83511
---
Wouldn't it be better to use VERSION_GREATER
(http://www.cmak
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124647/
---
Review request for Plasma.
Repository: plasma-mediacenter
Description
-
