Re: Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter

2015-08-31 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124947/ --- (Updated Aug. 31, 2015, 12:16 p.m.) Status -- This change has been

Re: Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter

2015-08-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124947/#review84472 --- Ship it! Other than Mark's comments; concept of patch is

Re: Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter

2015-08-27 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124947/#review84451 --- ksmserver/screenlocker/greeter/greeterapp.cpp (line 140)

Re: Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter

2015-08-27 Thread Martin Gräßlin
On Aug. 27, 2015, 12:01 p.m., Mark Gaiser wrote: ksmserver/screenlocker/greeter/greeterapp.cpp, line 140 https://git.reviewboard.kde.org/r/124947/diff/1/?file=399227#file399227line140 It might be nice to check if this pointer isn't 0 after the cast. Also, coding style.

Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter

2015-08-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124947/ --- Review request for Plasma and David Edmundson. Repository: