Re: Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

2015-09-08 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125105/ --- (Updated Sept. 8, 2015, 4:30 p.m.) Status -- This change has been ma

Re: Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

2015-09-08 Thread Martin Klapetek
> On Sept. 8, 2015, 5:46 p.m., David Faure wrote: > > I would split it the mimetype-determination into a separate line of code > > for readability, but other than that, this looks good, thanks for having > > made and tested the change. Alright, I'll move it out. - Martin --

Re: Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

2015-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125105/#review85017 --- Ship it! I would split it the mimetype-determination into a s

Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

2015-09-08 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125105/ --- Review request for Plasma and David Faure. Repository: plasma-framework