Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125134/ --- (Updated Sept. 21, 2015, 1:05 p.m.) Status -- This change has been m

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125134/ --- (Updated Sept. 18, 2015, 8:56 a.m.) Review request for Plasma and andreas

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

> On Sept. 17, 2015, 1:07 p.m., Marco Martin wrote: > > updates? > > regardless if screenshots end up being used in the widget explorer applets > > or not, I would add the possibility in order to ghns plasmoids to provide > > one > > andreas kainz wrote: > Yes please. > > As I wro

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125134/ --- (Updated Sept. 17, 2015, 2:01 p.m.) Review request for Plasma and andreas

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

> On Sept. 17, 2015, 1:30 p.m., Martin Gräßlin wrote: > > components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h, line 55 > > > > > > are you overriding a method here? If yes please add override. If no I

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125134/#review85573 --- components/shellprivate/widgetexplorer/plasmaappletitemmodel_

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

> On Sept. 17, 2015, 1:07 nachm., Marco Martin wrote: > > updates? > > regardless if screenshots end up being used in the widget explorer applets > > or not, I would add the possibility in order to ghns plasmoids to provide > > one Yes please. As I wrote in another reviewrequest I added yeste

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125134/#review85570 --- updates? regardless if screenshots end up being used in the wi

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

Generate the preview would be nice BUT really difficult cause you should look that the plasmoid fits into an square. about kwin screenshots I will have a look at if, if you like because also the KCM HIG is defined like that: Preview where you can add or select and an panel on buttom of the previe

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

> On Sept. 10, 2015, 12:39 p.m., Martin Gräßlin wrote: > > I'm questioning the distribution of screenshots. Wouldn't it make more > > sense to generate it at runtime to show how it will look like (theme, > > proper dpi, etc.)? > > Marco Martin wrote: > i don't think it's feasible, it would

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

> On Sept. 10, 2015, 10:39 a.m., Martin Gräßlin wrote: > > I'm questioning the distribution of screenshots. Wouldn't it make more > > sense to generate it at runtime to show how it will look like (theme, > > proper dpi, etc.)? i don't think it's feasible, it would have to load each single plas

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

> On Sept. 10, 2015, 10:39 a.m., Bhushan Shah wrote: > > +1 to idea in general > > > > However I am not so sure about providing screenshot in package, given same > > plasmoid might look different in different form factor. What about having > > seperate data dir to provide the screenshots for p

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125134/#review85096 --- I'm questioning the distribution of screenshots. Wouldn't it m

Re: Review Request 125134: Add a role for screenshots in the widgetexplorer model

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125134/#review85095 --- +1 to idea in general However I am not so sure about providin

Review Request 125134: Add a role for screenshots in the widgetexplorer model

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125134/ --- Review request for Plasma. Repository: plasma-workspace Description ---