Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125174/ --- (Updated Sept. 14, 2015, 11:11 a.m.) Status -- This change has been

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125174/#review85351 --- Provided this gets maintained, I'm in favor of this (perhaps

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca
> On Sept. 14, 2015, 8:24 a.m., Marco Martin wrote: > > Provided this gets maintained, I'm in favor of this (perhaps in > > kdeplasma-addons instead of a main workspace feature). > > Since the behavior of a pure launcher is quite different from both a > > taskbar entry or a dock icon, so some

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread Marco Martin
> On Sept. 14, 2015, 8:24 a.m., Marco Martin wrote: > > Provided this gets maintained, I'm in favor of this (perhaps in > > kdeplasma-addons instead of a main workspace feature). > > Since the behavior of a pure launcher is quite different from both a > > taskbar entry or a dock icon, so some

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125174/#review85360 --- applets/quicklaunch-qml/package/contents/code/layout.js

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca
> On Sept. 14, 2015, 9:35 a.m., Marco Martin wrote: > > applets/quicklaunch-qml/package/contents/code/layout.js, line 23 > > > > > > I guess the spacing here is half because it's used as margins for the > >

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-12 Thread David Rosca
> On Sept. 12, 2015, 12:42 a.m., Martin Klapetek wrote: > > Is there any disadvantage to using Icon-only task manager and adding > > launchers in there? It seems like this applet would do exactly the same > > minus the task switching, so perhaps some portions of the code could be > > shared?

Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-11 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125174/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125174/#review85224 --- Is there any disadvantage to using Icon-only task manager and