Re: Review Request 125654: Use shared engine in ksplashqml

2015-10-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125654/ --- (Updated Oct. 16, 2015, 2:18 p.m.) Status -- This change has been ma

Re: Review Request 125654: Use shared engine in ksplashqml

2015-10-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125654/#review86910 --- Ship it! +2 for sharing the engine - Marco Martin On Oct.

Re: Review Request 125654: Use shared engine in ksplashqml

2015-10-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125654/#review86909 --- +1, looks good to me ksplash/ksplashqml/splashapp.cpp (line

Review Request 125654: Use shared engine in ksplashqml

2015-10-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125654/ --- Review request for Plasma. Repository: plasma-workspace Description ---