Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- (Updated Nov. 5, 2015, 10:36 a.m.) Status -- This change has been ma

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/#review88042 --- Ship it! please fix the two added empty and then I think it's

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- (Updated Nov. 3, 2015, 4:37 p.m.) Review request for kwin and Plasma. R

Re: Review Request 125873: preliminar support for task geometries in wayland

> On Oct. 30, 2015, 5:52 p.m., Thomas Lübking wrote: > > shell_client.cpp, line 412 > > > > > > should the panel also be tested for being on the same screen (ie. same > > screen takes precedence over closer, but

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- (Updated Oct. 30, 2015, 5:42 p.m.) Review request for kwin and Plasma.

Re: Review Request 125873: preliminar support for task geometries in wayland

> On Oct. 30, 2015, 4:52 p.m., Thomas Lübking wrote: > > shell_client.cpp, line 413 > > > > > > just store the iterator? kindof prefer this way, but i can do it, sure - Marco

Re: Review Request 125873: preliminar support for task geometries in wayland

> On Oct. 30, 2015, 4:52 p.m., Thomas Lübking wrote: > > shell_client.cpp, line 412 > > > > > > should the panel also be tested for being on the same screen (ie. same > > screen takes precedence over closer, but

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/#review87753 --- abstract_client.h (line 601)

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- (Updated Oct. 30, 2015, 4:08 p.m.) Review request for kwin and Plasma.

Re: Review Request 125873: preliminar support for task geometries in wayland

> On Oct. 30, 2015, 3:32 p.m., Martin Gräßlin wrote: > > abstract_client.h, line 830 > > > > > > why friend an inheriting class? > > Marco Martin wrote: > because m_windowManagementInterface is private in Ab

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- (Updated Oct. 30, 2015, 3:31 p.m.) Review request for kwin and Plasma.

Re: Review Request 125873: preliminar support for task geometries in wayland

> On Oct. 30, 2015, 2:32 p.m., Martin Gräßlin wrote: > > main_wayland.cpp, lines 378-380 > > > > > > only if you want to break kwin for everybody with an up to date Qt 5.6 ah, right sorry, forgot that :( > On

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/#review87746 --- abstract_client.h (line 830)

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- (Updated Oct. 30, 2015, 1:43 p.m.) Review request for kwin and Plasma.

Re: Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- (Updated Oct. 30, 2015, 1:13 p.m.) Review request for kwin and Plasma.

Review Request 125873: preliminar support for task geometries in wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/ --- Review request for kwin and Plasma. Repository: kwin Description --