Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-09 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125984/ --- (Updated Nov. 9, 2015, 1:29 p.m.) Status -- This change has been

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125984/#review88180 --- Ship it! Ship It! - Sebastian Kügler On Nov. 9, 2015,

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-09 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125984/ --- (Updated Nov. 9, 2015, 8:28 a.m.) Review request for Plasma. Changes

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-07 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125984/#review88136 --- As someone who touched that part ages ago, +1. - Luca

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-07 Thread Jonathan Marten
> On Nov. 7, 2015, 1:48 p.m., Sebastian Kügler wrote: > > kcms/formats/kcmformats.cpp, line 124 > > > > > > spaces around the comparison operator, please. OK, will correct. - Jonathan

Re: Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125984/#review88137 --- Looks good, a coding style comment inline, though.

Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

2015-11-07 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125984/ --- Review request for Plasma. Bugs: 354984