Re: Review Request 126148: [plasma-framework] qstring optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126148/ --- (Updated Nov. 27, 2015, 8:19 p.m.) Status -- This change has been ma

Re: Review Request 126148: [plasma-framework] qstring optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126148/#review88822 --- Ship it! Ship It! - Marco Martin On Nov. 23, 2015, 10:19 p

Re: Review Request 126148: [plasma-framework] qstring optimizations

> On Nov. 23, 2015, 9:53 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/core/datamodel.cpp, line 58 > > > > > > Why not constBegin()/constEnd()? > > Nick Shaforostoff wrote: > because rNames is const

Re: Review Request 126148: [plasma-framework] qstring optimizations

> On Nov. 23, 2015, 9:02 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 122 > > > > > > Why do you drop FAST_CONCATENATION? ack QT_USE_FAST_CONCATENATION /usr/include/ brings nothing ack QT_USE_QSTRING

Re: Review Request 126148: [plasma-framework] qstring optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126148/ --- (Updated Nov. 23, 2015, 10:19 p.m.) Review request for Plasma, Marco Mart

Re: Review Request 126148: [plasma-framework] qstring optimizations

> On Nov. 23, 2015, 9:53 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/core/datamodel.cpp, line 58 > > > > > > Why not constBegin()/constEnd()? because rNames is const, constBegin()/constEnd() will be c

Re: Review Request 126148: [plasma-framework] qstring optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126148/#review88737 --- src/declarativeimports/core/datamodel.cpp (line 58)

Re: Review Request 126148: [plasma-framework] qstring optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126148/#review88735 --- CMakeLists.txt (line 122)

Review Request 126148: [plasma-framework] qstring optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126148/ --- Review request for Plasma, Marco Martin and Martin Klapetek. Repository: