Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-26 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/ --- (Updated Nov. 26, 2015, 9:05 a.m.) Status -- This change has been ma

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/#review88841 --- Ship it! Ok, I'll trust you. - Martin Klapetek On Nov. 25,

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread David Rosca
> On Nov. 25, 2015, 5:35 p.m., Martin Klapetek wrote: > > As you don't implement your own sizeHint() in the wizard - can you be sure > > that QWizard::sizeHint() will always return sensible value? > > > > As an alternative, you could just scale the font to always fit the wizard. > > That would

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/#review88839 --- As you don't implement your own sizeHint() in the wizard - can

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/ --- (Updated Nov. 25, 2015, 5:03 p.m.) Review request for Plasma and Martin K

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread David Rosca
> On Nov. 25, 2015, 2:08 p.m., Sebastian Kügler wrote: > > src/wizard/pages/pairing.cpp, line 111 > > > > > > The *2 seems fairly random. Can't we set the right minimum width > > derived from the pinNumber? Give

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/#review88800 --- src/wizard/pages/pairing.cpp (line 111)

Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

2015-11-24 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126160/ --- Review request for Plasma and Martin Klapetek. Bugs: 355798 https://b