Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

2016-01-26 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126300/ --- (Updated Jan. 27, 2016, 6:56 a.m.) Status -- This change has been ma

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

2016-01-24 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126300/#review91549 --- Ship it! Ship It! - Heiko Tietze On Jan. 10, 2016, 4:33

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

2016-01-24 Thread Heiko Tietze
> On Jan. 24, 2016, 8:58 p.m., Jonathan Marten wrote: > > Ping anyone? > > Kai Uwe Broulik wrote: > Please if you fixed an issue raised mark is as fixed so the "open issues" > count drops, making it easier to see what has changed. After it's zero and > you already got a "Ship It" (see abov

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

2016-01-24 Thread Kai Uwe Broulik
> On Jan. 24, 2016, 8:58 nachm., Jonathan Marten wrote: > > Ping anyone? Please if you fixed an issue raised mark is as fixed so the "open issues" count drops, making it easier to see what has changed. After it's zero and you already got a "Ship It" (see above, "Fix it", covered behind there's

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

2016-01-24 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126300/#review91537 --- Ping anyone? - Jonathan Marten On Jan. 10, 2016, 4:33 p.m.

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

2016-01-10 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126300/ --- (Updated Jan. 10, 2016, 4:33 p.m.) Review request for Plasma and KDE Usab

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

2016-01-07 Thread Heiko Tietze
> On Jan. 7, 2016, 10:42 a.m., Heiko Tietze wrote: > > Looks good from the usability POV. But what happens with very long text, > > like Finnish translation? In the HIG we wrote "Do not add line breaks. If > > necessary place an additional label below the check box." (which is worth > > to rev

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

2016-01-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126300/#review90738 --- +1 for the idea A bunch of coding nitpicks below. kcms/runn

Review Request 126300: Plasma Search KCM: display the runner descriptions

2015-12-10 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126300/ --- Review request for Plasma. Repository: plasma-desktop Description -