Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126464/#review90580 --- Ship it! Ship It! - Kai Uwe Broulik On Jan. 4, 2016, 5:39

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126464/ --- (Updated Jan. 4, 2016, 5:55 p.m.) Status -- This change has been mar

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126464/ --- (Updated Jan. 4, 2016, 6:39 p.m.) Review request for Plasma. Changes --

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Martin Klapetek
> On Dec. 21, 2015, 11:28 p.m., Kai Uwe Broulik wrote: > > desktoppackage/contents/applet/CompactApplet.qml, line 37 > > > > > > Doesn't it complain about "Cannot assign [undefined] to something"? If > > not, awe

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2015-12-22 Thread Martin Klapetek
> On Dec. 22, 2015, 1:43 p.m., Marco Martin wrote: > > Did you test all plasmoids with standard tooltip still work as expected? > > (and quinckly move the mouse back and forth between plsmoid with standard > > tooltip and custom) Yeah, all looks fine. --> https://www.dropbox.com/s/dgzulltsk6g

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2015-12-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126464/#review89910 --- Did you test all plasmoids with standard tooltip still work as

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2015-12-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126464/#review89866 --- desktoppackage/contents/applet/CompactApplet.qml (line 37)

Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2015-12-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126464/ --- Review request for Plasma. Repository: plasma-desktop Description -