Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Jan. 4, 2016, 6:20 p.m.) Status -- This change has been mar

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 29, 2015, 11:56 p.m., Ken Vermette wrote: > > In regards to the message displayed (as mentioned in your G+ post) how > > about: > > > > "Sorry for the inconvenience. Please report the error to help improve this > > software." > > Kai Uwe Broulik wrote: > I'm quite indifferent on

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 29, 2015, 11:56 nachm., Ken Vermette wrote: > > In regards to the message displayed (as mentioned in your G+ post) how > > about: > > > > "Sorry for the inconvenience. Please report the error to help improve this > > software." > > Kai Uwe Broulik wrote: > I'm quite indifferent

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 29, 2015, 11:56 nachm., Ken Vermette wrote: > > In regards to the message displayed (as mentioned in your G+ post) how > > about: > > > > "Sorry for the inconvenience. Please report the error to help improve this > > software." I'm quite indifferent on the wording: http://wstaw.org

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90316 --- In regards to the message displayed (as mentioned in your G+ p

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Dez. 29, 2015, 9:19 nachm.) Review request for KDE Frameworks, P

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Dez. 28, 2015, 11:34 nachm.) Review request for KDE Frameworks,

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Dez. 28, 2015, 11:14 nachm.) Review request for KDE Frameworks,

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correc

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correct:

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correc

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correct:

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correc

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correct:

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. The and is correct: - I never want to show the di

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90166 --- Ship it! drkonqi/main.cpp (line 159)

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Dez. 27, 2015, 4:11 nachm.) Review request for KDE Frameworks, P

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 25, 2015, 4:37 nachm., Kai Uwe Broulik wrote: > > Usability: I envisioned this to be used for auto-restarting shell services > > and not to be used by applications. > > Another interesting thought could be enabling this by default for all > > applications but for regular applications

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 25, 2015, 4:37 p.m., Kai Uwe Broulik wrote: > > Usability: I envisioned this to be used for auto-restarting shell services > > and not to be used by applications. > > Another interesting thought could be enabling this by default for all > > applications but for regular applications tr

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 25, 2015, 5:31 nachm., David Edmundson wrote: > > code looks fine. > > > > Though please do the TODOs before merging as historically we have a have a > > habbit of them not getting done > > Also your StatusNotifierItem leaks - but it proably wants to be the > > lifespan of the appli

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90104 --- code looks fine. Though please do the TODOs before merging as

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90100 --- Usability: I envisioned this to be used for auto-restarting sh

Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßli