Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/ --- (Updated Jan. 17, 2016, 11:56 a.m.) Status -- This change has been m

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/ --- (Updated Jan. 7, 2016, 9:21 nachm.) Review request for Plasma, KDE Usabil

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/#review90739 --- Note to myself: the type for "count", for some reason, is 64 b

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

> On Jan. 6, 2016, 7:57 nachm., Alessandro Longo wrote: > > Compliments! Your work is great as always. From visual design POV I think > > how it currently looks it's very fine; for the implementation: > > if I understand well the circle and the progress indicators will be two > > SVGs to be put

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/#review90707 --- Compliments! Your work is great as always. From visual design

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/ --- (Updated Jan. 6, 2016, 2:13 nachm.) Review request for Plasma, KDE Usabil

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

> On Jan. 4, 2016, 11:01 p.m., Eike Hein wrote: > > Ship It! > > Kai Uwe Broulik wrote: > I need a proper frame graphic, "hover" isn't particularly good but I > don't want to mess around with the tasks.svgz due to Review 126373 > > Kai Uwe Broulik wrote: > What am I supposed to do in t

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

> On Jan. 4, 2016, 11:01 nachm., Eike Hein wrote: > > Ship It! > > Kai Uwe Broulik wrote: > I need a proper frame graphic, "hover" isn't particularly good but I > don't want to mess around with the tasks.svgz due to Review 126373 What am I supposed to do in this case: the desktop file is

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

> On Jan. 4, 2016, 11:01 nachm., Eike Hein wrote: > > Ship It! I need a proper frame graphic, "hover" isn't particularly good but I don't want to mess around with the tasks.svgz due to Review 126373 - Kai Uwe --- This is an automatical

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/#review90611 --- Ship it! Ship It! - Eike Hein On Jan. 4, 2016, 10:50 p.m.,

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/ --- (Updated Jan. 4, 2016, 10:50 nachm.) Review request for Plasma, KDE Usabi

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/#review90598 --- applets/taskmanager/package/contents/ui/ConfigGeneral.qml (li

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

> On Jan. 4, 2016, 2:40 p.m., David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 278 > > > > > > Do we need a paintedWidth/paintedHeight in IconItem? > > Kai Uwe Broulik wrote: >

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

> On Jan. 4, 2016, 2:40 p.m., David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 278 > > > > > > Do we need a paintedWidth/paintedHeight in IconItem? > > Kai Uwe Broulik wrote: >

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

> On Jan. 4, 2016, 2:40 nachm., David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 278 > > > > > > Do we need a paintedWidth/paintedHeight in IconItem? > > Kai Uwe Broulik wrote: >

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

> On Jan. 4, 2016, 2:40 p.m., David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 278 > > > > > > Do we need a paintedWidth/paintedHeight in IconItem? > > Kai Uwe Broulik wrote: >

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/ --- (Updated Jan. 4, 2016, 3:03 nachm.) Review request for Plasma, KDE Usabil

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

> On Jan. 4, 2016, 2:40 nachm., David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 278 > > > > > > Do we need a paintedWidth/paintedHeight in IconItem? That would be sweet > On J

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/#review90547 --- +1 from me. Code is very neat and tidy. I don't really have a

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/ --- (Updated Jan. 4, 2016, 1:50 nachm.) Review request for Plasma, KDE Usabil

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API

> On Jan. 4, 2016, 7:58 a.m., Heiko Tietze wrote: > > Pretty cool stuff. Guess there will some greediness from other launchers. > > On the first glance I read the tool as a launcher for Unity, which would be > > weird. So I suggest to think about renaming, maybe just without the space. > > Kai

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API

> On Jan. 4, 2016, 7:58 vorm., Heiko Tietze wrote: > > Pretty cool stuff. Guess there will some greediness from other launchers. > > On the first glance I read the tool as a launcher for Unity, which would be > > weird. So I suggest to think about renaming, maybe just without the space. I was t

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/#review90524 --- Pretty cool stuff. Guess there will some greediness from other

Review Request 126621: [Task Manager] Add support for Unity Launcher API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/ --- Review request for Plasma, KDE Usability, Craig Drummond, Eike Hein, and Lu