Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

2016-01-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126642/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

2016-01-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126642/#review90664 --- I don't really understand the problem this is solving. This wo

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

2016-01-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126642/#review91327 --- We really need a fix for this. There have yet again been cha

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

2016-01-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126642/#review91402 --- Ship it! I'm in general in favor of that, mostly for the s

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

2016-01-23 Thread Kai Uwe Broulik
> On Jan. 21, 2016, 11:06 vorm., Marco Martin wrote: > > I'm in general in favor of that, mostly for the scenario we find some > > actual rendering bug in the svg rendering code, that then gets cached Is there a better way to store the version? I recall in KCache or so you can store custom pro

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

2016-01-25 Thread Marco Martin
> On Jan. 21, 2016, 11:06 a.m., Marco Martin wrote: > > I'm in general in favor of that, mostly for the scenario we find some > > actual rendering bug in the svg rendering code, that then gets cached > > Kai Uwe Broulik wrote: > Is there a better way to store the version? I recall in KCache

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

2016-01-25 Thread David Edmundson
> On Jan. 21, 2016, 11:06 a.m., Marco Martin wrote: > > I'm in general in favor of that, mostly for the scenario we find some > > actual rendering bug in the svg rendering code, that then gets cached > > Kai Uwe Broulik wrote: > Is there a better way to store the version? I recall in KCache

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

2017-02-08 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126642/ --- (Updated Feb. 8, 2017, 2:24 nachm.) Status -- This change has been d