Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/ --- (Updated Feb. 29, 2016, 11:05 p.m.) Status -- This change has been m

Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/#review92886 --- Ship it! Ship It! - Marco Martin On Feb. 28, 2016, 5:15

Re: Review Request 127201: Fix svg icon path resolving in IconItem

> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so reliable if the icon is not rendered with

Re: Review Request 127201: Fix svg icon path resolving in IconItem

> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so reliable if the icon is not rendered with

Re: Review Request 127201: Fix svg icon path resolving in IconItem

> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so reliable if the icon is not rendered with

Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/ --- (Updated Feb. 28, 2016, 5:15 p.m.) Review request for KDE Frameworks, Pla

Re: Review Request 127201: Fix svg icon path resolving in IconItem

> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 253 > > > > > > This should be `QSize(32, 32)` as the comment says? I indented to use a size without exact match. > On Feb

Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/#review92843 --- autotests/iconitemtest.cpp (line 133)

Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/ --- (Updated Feb. 28, 2016, 1:18 a.m.) Review request for KDE Frameworks, Pla

Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/#review92838 --- can we extend the unit test to cover this? - Kai Uwe Broulik

Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: p