Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/ --- (Updated April 25, 2016, 7:52 a.m.) Status -- This change has been m

Re: Review Request 127263: Add Wireless Energy Saving action

> On Dub. 24, 2016, 9:46 odp., Kai Uwe Broulik wrote: > > Thanks! I cannot push it until this gets solved too https://git.reviewboard.kde.org/r/127325/. - Jan --- This is an automatically generated e-mail. To reply, visit: https://git.

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review94820 --- Ship it! Thanks! - Kai Uwe Broulik On März 9, 2016, 4:1

Re: Review Request 127263: Add Wireless Energy Saving action

> On March 9, 2016, 2:47 p.m., Thomas Pfeiffer wrote: > > Thank you for the screenshot! > > It looks good to me, the only thing I'd change is relabeling "Manual > > configuration" to "Leave unchanged" (and changing functionality if that > > isn't what it does atm) and putting that as the first

Re: Review Request 127263: Add Wireless Energy Saving action

> On Bře. 9, 2016, 2:47 odp., Thomas Pfeiffer wrote: > > Thank you for the screenshot! > > It looks good to me, the only thing I'd change is relabeling "Manual > > configuration" to "Leave unchanged" (and changing functionality if that > > isn't what it does atm) and putting that as the first o

Re: Review Request 127263: Add Wireless Energy Saving action

> On March 9, 2016, 2:47 p.m., Thomas Pfeiffer wrote: > > Thank you for the screenshot! > > It looks good to me, the only thing I'd change is relabeling "Manual > > configuration" to "Leave unchanged" (and changing functionality if that > > isn't what it does atm) and putting that as the first

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review94749 --- Ping? - Jan Grulich On Bře. 9, 2016, 4:15 odp., Jan Grulic

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/ --- (Updated Bře. 9, 2016, 4:15 odp.) Review request for Plasma, Solid, KDE U

Re: Review Request 127263: Add Wireless Energy Saving action

> On März 9, 2016, 3:01 nachm., Anthony Fieroni wrote: > > I think it's needed complete comfiguration module, to replace tlp itself. > > Or when you use tlp this can conflict it. > Or when you use tlp this can conflict it. I don't consider some random 3rd party service running and messing with

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93336 --- I think it's needed complete comfiguration module, to replace

Re: Review Request 127263: Add Wireless Energy Saving action

> On Bře. 9, 2016, 2:47 odp., Thomas Pfeiffer wrote: > > Thank you for the screenshot! > > It looks good to me, the only thing I'd change is relabeling "Manual > > configuration" to "Leave unchanged" (and changing functionality if that > > isn't what it does atm) and putting that as the first o

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93334 --- Thank you for the screenshot! It looks good to me, the only t

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/ --- (Updated Bře. 9, 2016, 10:44 dop.) Review request for Plasma, Solid, KDE

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93324 --- I still haven't actually tried/compiled it because of this st

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/ --- (Updated Bře. 9, 2016, 9:36 dop.) Review request for Plasma, Solid, KDE U

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/ --- (Updated Bře. 9, 2016, 9:28 dop.) Review request for Plasma, Solid, KDE U

Re: Review Request 127263: Add Wireless Energy Saving action

> On March 3, 2016, 1:36 p.m., Kai Uwe Broulik wrote: > > > y) Switching to a profile where the action is enabled too and options are > > > turned off -> will turn on the wifi/wwan/bt > > z) Switching to a profile where the action is disabled -> will recover the > > previous state of the wifi/w

Re: Review Request 127263: Add Wireless Energy Saving action

> On März 3, 2016, 1:36 nachm., Kai Uwe Broulik wrote: > > > y) Switching to a profile where the action is enabled too and options are > > > turned off -> will turn on the wifi/wwan/bt > > z) Switching to a profile where the action is disabled -> will recover the > > previous state of the wifi/

Re: Review Request 127263: Add Wireless Energy Saving action

> On Bře. 3, 2016, 12:35 odp., Lamarque Souza wrote: > > daemon/actions/bundled/wirelesspowersaving.cpp, line 49 > > > > > > This and the next two if are a bit strange. Shouldn't this be: > > > > if (m_la

Re: Review Request 127263: Add Wireless Energy Saving action

> On March 3, 2016, 12:35 p.m., Lamarque Souza wrote: > > daemon/actions/bundled/wirelesspowersaving.cpp, line 49 > > > > > > This and the next two if are a bit strange. Shouldn't this be: > > > > if (m_l

Re: Review Request 127263: Add Wireless Energy Saving action

> On Bře. 3, 2016, 1:36 odp., Kai Uwe Broulik wrote: > > > y) Switching to a profile where the action is enabled too and options are > > > turned off -> will turn on the wifi/wwan/bt > > z) Switching to a profile where the action is disabled -> will recover the > > previous state of the wifi/ww

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93095 --- > y) Switching to a profile where the action is enabled too a

Re: Review Request 127263: Add Wireless Energy Saving action

> On Bře. 3, 2016, 12:35 odp., Lamarque Souza wrote: > > daemon/actions/bundled/wirelesspowersaving.cpp, line 49 > > > > > > This and the next two if are a bit strange. Shouldn't this be: > > > > if (m_la

Re: Review Request 127263: Add Wireless Energy Saving action

> On Bře. 3, 2016, 12:36 odp., Kai Uwe Broulik wrote: > > Please add Usability for this review, too and describe in more detail what > > it does. So, when I plug back in the cable it turns everything back on > > unconditionally? While that's fine with WiFi I don't want eg. Bluetooth to > > tur

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/ --- (Updated Bře. 3, 2016, 1:30 odp.) Review request for Plasma, Solid, KDE U

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93090 --- Please add Usability for this review, too and describe in mor

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93088 --- CMakeLists.txt (line 25)

Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/ --- Review request for Plasma, Solid and Kai Uwe Broulik. Repository: powerde