Re: Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

2016-03-09 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127296/ --- (Updated March 9, 2016, 5:21 p.m.) Status -- This change has been ma

Re: Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

2016-03-08 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127296/#review93302 --- Ship it! Okay, thanks for the explanation. - Sebastian Kü

Re: Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

2016-03-08 Thread Harald Sitter
> On March 8, 2016, 10:15 a.m., Sebastian Kügler wrote: > > CMakeLists.txt, line 14 > > > > > > Pardon my ignrance, but what does this mean? Plugin uses math.h -> needs libm -> doesn't explicitly link libm -> cau

Re: Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

2016-03-08 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127296/#review93289 --- CMakeLists.txt (line 14)

Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

2016-03-06 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127296/ --- Review request for Plasma and Harald Sitter. Repository: breeze-plymouth