Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-05-04 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/ --- (Updated May 4, 2016, 3:36 p.m.) Status -- This change has been mark

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-05-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/#review95165 --- Fix it, then Ship it! autotests/configmodeltest.cpp (line

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-05-03 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/ --- (Updated May 3, 2016, 1:21 p.m.) Review request for Plasma. Changes ---

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-05-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/#review95128 --- autotests/configmodeltest.cpp (line 26)

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-05-03 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/ --- (Updated May 3, 2016, 7:04 a.m.) Review request for Plasma. Changes ---

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-04-29 Thread David Rosca
> On April 29, 2016, 9:51 a.m., Marco Martin wrote: > > any news on this? Sorry, not much time now. But I did take a look and the test will need AppletInterface to actually test this case, so I think it won't be easy from plasma-framework. With the plasmashell testing subsystem added recently

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-04-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/#review95007 --- any news on this? - Marco Martin On April 21, 2016, 10:11

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-04-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/#review94755 --- what sebas says, seems the patch makes sense, but really need

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-04-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/#review94747 --- I think we should start adding autotests to those classes we

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-04-21 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/ --- (Updated April 21, 2016, 10:11 a.m.) Review request for Plasma. Changes

Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-04-20 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/ --- Review request for Plasma. Repository: plasma-framework Description ---