Re: Review Request 127875: Selected state concept for icons

> On May 15, 2016, 7:26 p.m., David Faure wrote: > > src/kiconloader.cpp, line 820 > > > > > > Could q->theme() be NULL here in some cases? > > See > > https://build.kde.org/job/khtml%20master%20kf5-qt5/PLAT

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95492 --- src/kiconloader.cpp (line 820)

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ --- (Updated May 13, 2016, 9:46 a.m.) Status -- This change has been mar

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ --- (Updated May 11, 2016, 12:12 p.m.) Review request for KDE Frameworks and

Re: Review Request 127875: Selected state concept for icons

> On May 11, 2016, 10:52 a.m., David Edmundson wrote: > > src/kiconloader.cpp, line 840 > > > > > > 1) For the unselected case, do you think we want Text and Base rather > > than Window and WindowText? > > f

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95350 --- src/kiconloader.cpp (line 840)

Re: Review Request 127875: Selected state concept for icons

> On May 10, 2016, 12:50 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 839 > > > > > > Aren't we missing an arg? > > > > return QStringLiteral(".ColorScheme-Text {\ > > color:%1;\ >

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ --- (Updated May 10, 2016, 2:15 p.m.) Review request for KDE Frameworks and P

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95347 --- src/kiconloader.cpp (line 827)

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95345 --- src/kiconloader.cpp (line 839)

Re: Review Request 127875: Selected state concept for icons

> On May 9, 2016, 10:32 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 841 > > > > > > we're already passing a highlightedText colour for some reason. > > > > Either: > > - Kiconloader is

Re: Review Request 127875: Selected state concept for icons

> On May 9, 2016, 10:32 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 841 > > > > > > we're already passing a highlightedText colour for some reason. > > > > Either: > > - Kiconloader is

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ --- (Updated May 10, 2016, 10:56 a.m.) Review request for KDE Frameworks and

Re: Review Request 127875: Selected state concept for icons

> On May 9, 2016, 10:32 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 311 > > > > > > was createIconImage in the last frameworks? > > > > if so this is an ABI break. > > > > instead

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95297 --- src/kiconloader.cpp (line 311)

Re: Review Request 127875: Selected state concept for icons

> On Mai 9, 2016, 10:32 nachm., David Edmundson wrote: > > src/kiconloader.cpp, line 311 > > > > > > was createIconImage in the last frameworks? > > > > if so this is an ABI break. > > > > inste

Re: Review Request 127875: Selected state concept for icons

> On Mai 9, 2016, 10:21 nachm., Andreas Kainz wrote: > > Ship It! I can't review the code but this is one of the best features in the past 2 years - Andreas --- This is an automatically generated e-mail. To reply, visit: https://git.rev

Re: Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95309 --- Ship it! Ship It! - Andreas Kainz On Mai 9, 2016, 3:26

Review Request 127875: Selected state concept for icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ --- Review request for KDE Frameworks and Plasma. Repository: kiconthemes D