Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/ --- (Updated June 19, 2016, 10:56 p.m.) Status -- This change has been

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96732 --- applets/systemmonitor/common/contents/ui/DoublePlotter.qml

Re: Review Request 128136: alignement for systemmonitoring applets

> On June 19, 2016, 10:35 p.m., David Edmundson wrote: > > applets/systemmonitor/common/contents/ui/DoublePlotter.qml, lines 82-85 > > > > > > This needs fixing. > > > > you've set a right anchors > >

Re: Review Request 128136: alignement for systemmonitoring applets

> On Juni 17, 2016, 5:32 nachm., Thomas Pfeiffer wrote: > > I still think that the applets need a completely different layout in order > > to really be useful in panels (who would really want to use a whole panel > > just to show CPU load?), but that's probably for another patch. > > The

Re: Review Request 128136: alignement for systemmonitoring applets

> On June 17, 2016, 5:32 p.m., Thomas Pfeiffer wrote: > > I still think that the applets need a completely different layout in order > > to really be useful in panels (who would really want to use a whole panel > > just to show CPU load?), but that's probably for another patch. > > The changes

Re: Review Request 128136: alignement for systemmonitoring applets

> On Juni 17, 2016, 5:32 nachm., Thomas Pfeiffer wrote: > > I still think that the applets need a completely different layout in order > > to really be useful in panels (who would really want to use a whole panel > > just to show CPU load?), but that's probably for another patch. > > The

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96640 --- I still think that the applets need a completely different

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/ --- (Updated June 16, 2016, 12:14 p.m.) Review request for Plasma.

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96581 --- Ship it! Ship It from i18n point of view - Burkhard Lück

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96580 --- applets/systemmonitor/common/contents/ui/DoublePlotter.qml

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/ --- (Updated June 16, 2016, 11:16 a.m.) Review request for Plasma. Changes

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96573 --- applets/systemmonitor/common/contents/ui/DoublePlotter.qml

Re: Review Request 128136: alignement for systemmonitoring applets

> On June 15, 2016, 9:07 a.m., Marco Martin wrote: > > applets/systemmonitor/common/contents/ui/DoublePlotter.qml, line 84 > > > > > > this way if the text is too long, it will not wrap. > > > > if you

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/ --- (Updated June 16, 2016, 9:12 a.m.) Review request for Plasma.

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/ --- (Updated June 16, 2016, 9:13 a.m.) Review request for Plasma.

Re: Review Request 128136: alignement for systemmonitoring applets

> On June 15, 2016, 9:16 a.m., Burkhard Lück wrote: > > applets/systemmonitor/cpu/contents/ui/cpu.qml, line 43 > > > > > > please add context and explain what %1 and %2 are > > Andreas Kainz wrote: > I

Re: Review Request 128136: alignement for systemmonitoring applets

> On Juni 15, 2016, 9:16 vorm., Burkhard Lück wrote: > > applets/systemmonitor/cpu/contents/ui/cpu.qml, line 43 > > > > > > please add context and explain what %1 and %2 are I really don't know. - Andreas

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96515 --- applets/systemmonitor/cpu/contents/ui/cpu.qml (line 43)

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96512 --- Fix it, then Ship it! nice, but still a problem in a

Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/ --- Review request for Plasma. Repository: plasma-workspace Description