Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-08-31 Thread Painless Roaster
> On Čec. 28, 2016, 6:02 dop., Painless Roaster wrote: > > Ship It! > > Eike Hein wrote: > Do you need someone to commit this for you? > > Painless Roaster wrote: > I do not have an account on github. > > Eike Hein wrote: > Thanks, I'll see about getting this in next week. > >

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-08-30 Thread Eike Hein
> On July 28, 2016, 6:02 a.m., Painless Roaster wrote: > > Ship It! > > Eike Hein wrote: > Do you need someone to commit this for you? > > Painless Roaster wrote: > I do not have an account on github. > > Eike Hein wrote: > Thanks, I'll see about getting this in next week. Can

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-08-28 Thread Eike Hein
> On July 28, 2016, 6:02 a.m., Painless Roaster wrote: > > Ship It! > > Eike Hein wrote: > Do you need someone to commit this for you? > > Painless Roaster wrote: > I do not have an account on github. Thanks, I'll see about getting this in next week. - Eike

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-08-26 Thread Painless Roaster
> On Čec. 28, 2016, 6:02 dop., Painless Roaster wrote: > > Ship It! > > Eike Hein wrote: > Do you need someone to commit this for you? I do not have an account on github. - Painless --- This is an automatically generated e-mail.

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-08-23 Thread Eike Hein
> On July 28, 2016, 6:02 a.m., Painless Roaster wrote: > > Ship It! Do you need someone to commit this for you? - Eike --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-07-28 Thread Painless Roaster
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/#review97884 --- Ship it! Ship It! - Painless Roaster On Čec. 13, 2016,

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-07-27 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/#review97876 --- Ship it! Ship It! - Eike Hein On July 13, 2016, 1:13

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-07-27 Thread Painless Roaster
> On Čec. 14, 2016, 7:58 dop., Eike Hein wrote: > > It seems to work fairly well, but the editor margins are not symmetric on > > the left and right with respect to the item delegate frame: > > > > ![Screenshot](http://i.imgur.com/2JhUtp4.png) > > Painless Roaster wrote: > It is OK. The

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-07-14 Thread Painless Roaster
> On Čec. 14, 2016, 7:58 dop., Eike Hein wrote: > > It seems to work fairly well, but the editor margins are not symmetric on > > the left and right with respect to the item delegate frame: > > > > ![Screenshot](http://i.imgur.com/2JhUtp4.png) > > Painless Roaster wrote: > It is OK. The

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-07-14 Thread Eike Hein
> On July 14, 2016, 7:58 a.m., Eike Hein wrote: > > It seems to work fairly well, but the editor margins are not symmetric on > > the left and right with respect to the item delegate frame: > > > > ![Screenshot](http://i.imgur.com/2JhUtp4.png) > > Painless Roaster wrote: > It is OK. The

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-07-14 Thread Painless Roaster
> On Čec. 14, 2016, 7:58 dop., Eike Hein wrote: > > It seems to work fairly well, but the editor margins are not symmetric on > > the left and right with respect to the item delegate frame: > > > > ![Screenshot](http://i.imgur.com/2JhUtp4.png) It is OK. The vertical scroller is dynamically

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-07-14 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/#review97371 --- It seems to work fairly well, but the editor margins are not

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-07-13 Thread Painless Roaster
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/ --- (Updated Čec. 13, 2016, 1:13 odp.) Review request for Plasma. Bugs:

Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-07-11 Thread Painless Roaster
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/ --- Review request for Plasma. Repository: plasma-desktop Description