Re: Review Request 128431: Fix race condition when new applications open

2016-07-16 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128431/ --- (Updated July 16, 2016, 3:12 p.m.) Status -- This change has been

Re: Review Request 128431: Fix race condition when new applications open

2016-07-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128431/#review97412 --- Ship it! Ship It! - David Edmundson On July 12, 2016,

Re: Review Request 128431: Fix race condition when new applications open

2016-07-13 Thread Martin Tobias Holmedahl Sandsmark
> On July 13, 2016, 10:44 a.m., Aleix Pol Gonzalez wrote: > > Would it be possible to have a test there? It will be easier to review for > > us. what would the test test? nothing should call updateOrAddProcess(), ideally I'd just make it private, but I'm not sure how stable the libksysguard

Re: Review Request 128431: Fix race condition when new applications open

2016-07-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128431/#review97342 --- Would it be possible to have a test there? It will be easier

Review Request 128431: Fix race condition when new applications open

2016-07-12 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128431/ --- Review request for Plasma and John Tapsell. Bugs: 261255