Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-25 Thread Ural Mullabaev
Hi Andreas! > Much more readable now, great. Still it should obey the theme text > color which > is black instead of while. See sebas suggestion: I set color for text from theme. And I detected black font with shadow too dark on the light background. I had to switch off shadows. > Another featur

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-24 Thread Andreas Demmer
Hi Ural! > I've added shadows for items text using QGraphicsDropShadowEffect. Much more readable now, great. Still it should obey the theme text color which is black instead of while. See sebas suggestion: > Doesn't look like it's using the correct color from the theme > (Theme::textColor), o

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-24 Thread Ural Mullabaev
Hi Andreas! > I would also suggest to give the label text at least some shadows since the > current white is somewhat hard to read: I've added shadows for items text using QGraphicsDropShadowEffect. > > Resizing popup window to contents of folder is our feature. [...] > > I think, we can make sp

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-24 Thread Sebastian Kügler
On Tuesday, October 23, 2012 14:53:43 Andreas Demmer wrote: > I would also suggest to give the label text at least some shadows since the > current white is somewhat hard to read: > > http://wstaw.org/m/2012/10/23/plasma-desktopr24762.png Doesn't look like it's using the correct color from the t

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-24 Thread Andreas Demmer
Hi Ural! > Resizing popup window to contents of folder is our feature. [...] > I think, we can make special version for KDE. I do not quite understand. Does this mean, that stack folders are a unique feature of your distro? At least the animated version? It would be really cool to share the ani

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-23 Thread Andreas Demmer
Hi Ural, I would also suggest to give the label text at least some shadows since the current white is somewhat hard to read: http://wstaw.org/m/2012/10/23/plasma-desktopr24762.png Yours, Andreas -- http://www.andreas-demmer.de signature.asc Description: This is a digitally signed message par

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-23 Thread Ural Mullabaev
Hi Martin! > I just tried it and I quite like it, nice work! I have few suggestions > for improvements - first of all don't hide and show the popup when you > change folder, I wasn't sure what's happening when I clicked some > folder in it, I thought Dolphin is being opened and then suddenly the >

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-23 Thread Martin Klapetek
Hey Ural, On Mon, Oct 22, 2012 at 12:45 PM, Ural Mullabaev wrote: > Hi Aaron and Marco! > > I fixed the problems which you specified the last time: > - icon decreasing on the panel (attachment - smallicon.png); > - empty popup dialog (now it should show correctly) > And also I changed path to the

Stackfolder inclusion to 4.10 [attempt#2]

2012-10-22 Thread Ural Mullabaev
Hi Aaron and Marco! I fixed the problems which you specified the last time: - icon decreasing on the panel (attachment - smallicon.png); - empty popup dialog (now it should show correctly) And also I changed path to the qml contents to /plasma/packages/org.kde.stackfolder. Now what else do I nee