Re: ddcutil in Plasma Powerdevil

2019-10-03 Thread Harald Sitter
I think we are generally backwards compatible to 3.5 or some such, so you'll want to use the old call I guess. FWIW, the more reliable and I think also more liked way of doing this is to configure_file a header where you #cmakedefine WITH_DDCUTI e.g. see plasma-workspace or plasma-desktop. That

Re: ddcutil in Plasma Powerdevil

2019-10-02 Thread Sanford Rockowitz
You might want to look at the launchpad packaging (https://launchpad.net/~rockowitz/+archive/ubuntu/ddcutil), which includes the library version and development package.  It is at the current release level (0.9.7). If the cmake error is not obvious, let me know what it is.  The locus of the

Re: ddcutil in Plasma Powerdevil

2019-09-30 Thread Dorian Vogel
Rah that's dicky me trying to add the WITH_DDCUTIL symbol and propagate it to be used in a #ifdef in the actual code (ddcutilbrightness.{c, h}) I spent a lot of time trying to get it to work although it's probably basic cmake stuff... Hmm after a bit of research, is it possible that the

Re: ddcutil in Plasma Powerdevil

2019-09-30 Thread Jonathan Riddell
https://build.neon.kde.org/job/bionic_unstable_kde_powerdevil_bin_amd64/127/console *17:40:13* CMake Error at CMakeLists.txt:56 (add_compile_definitions):*17:40:13* Unknown CMake command "add_compile_definitions". Is the cmake error I get for Powerdevil https://cgit.kde.org/powerdevil.git/

Re: ddcutil in Plasma Powerdevil

2019-09-30 Thread Jonathan Riddell
I put ddcutils package in Neon unstable to be able to test it, using Sanford's packaging from Debian but with the libraries turned on. However powerdevil doesn't compile with DDCUtils turned on, it fails on a cmake error. Jonathan On Fri, 27 Sep 2019 at 07:14, Dorian Vogel wrote: > Hey

Re: ddcutil in Plasma Powerdevil

2019-09-27 Thread Dorian Vogel
Hey Jonathan, Unfortunately I did not test it for a long time (last time was around 5.15), and don't really have the possibility now because I'm away from home. *If I remember correctly,* back then I had a few instances when the startup of plasma (during the splashscreen) was quite longer due to

ddcutil in Plasma Powerdevil

2019-09-26 Thread Jonathan Riddell
The DDCUtil features of Powerdevil in KDE Plasma are currently disabled by default "DDCUtil library support is disabled by default as recomended by authors, add -DHAVE_DDCUTIL=On to enable" This is based on a conversation from 2017 where it was decided it was unstable. I see work has continued on