knotificationitem: api prettiness

2009-05-26 Thread Marco Martin
Hi all, was talking with richmoore about the api of libknotificationitem, wat did emerged is a thing i wasn't happy about but couldn't quite quantify before: 1) we have two way to set icons: by name and by pixmap, right now by name is setIcon() by pixmap is setImage() (that should reflect in dbus

Re: knotificationitem: api prettiness

2009-05-26 Thread Aaron J. Seigo
On Tuesday 26 May 2009, Marco Martin wrote: > Hi all, > was talking with richmoore about the api of libknotificationitem, wat did > emerged is a thing i wasn't happy about but couldn't quite quantify before: > > 1) we have two way to set icons: by name and by pixmap, right now by name > is setIcon(

Re: knotificationitem: api prettiness

2009-05-26 Thread Richard Moore
On Tue, May 26, 2009 at 10:17 PM, Marco Martin wrote: > 1) we have two way to set icons: by name and by pixmap, right now by name is > setIcon() > by pixmap is setImage() > (that should reflect in dbus too) > that looks a bit weird, would be better maybe setIconName() and setIcon()? To make it cl

Re: knotificationitem: api prettiness

2009-05-26 Thread Michael Jansen
On Tuesday 26 May 2009 23:17:57 Marco Martin wrote: > Hi all, > was talking with richmoore about the api of libknotificationitem, wat did > emerged is a thing i wasn't happy about but couldn't quite quantify before: > > 1) we have two way to set icons: by name and by pixmap, right now by name > is

Re: knotificationitem: api prettiness

2009-05-27 Thread Marco Martin
On Tuesday 26 May 2009, Aaron J. Seigo wrote: > On Tuesday 26 May 2009, Marco Martin wrote: > > Hi all, > > was talking with richmoore about the api of libknotificationitem, wat did > > emerged is a thing i wasn't happy about but couldn't quite quantify > > before: > > > > 1) we have two way to set

Re: knotificationitem: api prettiness

2009-05-27 Thread Aaron J. Seigo
On Tuesday 26 May 2009, Marco Martin wrote: > Hi all, > was talking with richmoore about the api of libknotificationitem, wat did > emerged is a thing i wasn't happy about but couldn't quite quantify before: > > 1) we have two way to set icons: by name and by pixmap, right now by name > is setIcon(

Re: knotificationitem: api prettiness

2009-05-27 Thread Richard Moore
On Wed, May 27, 2009 at 12:27 PM, Aaron J. Seigo wrote: > On Tuesday 26 May 2009, Marco Martin wrote: >> 1) we have two way to set icons: by name and by pixmap, right now by name >> is setIcon() >> by pixmap is setImage() >> (that should reflect in dbus too) >> that looks a bit weird, would be bet

Re: knotificationitem: api prettiness

2009-05-27 Thread Aaron J. Seigo
On Wednesday 27 May 2009, Richard Moore wrote: > On Wed, May 27, 2009 at 12:27 PM, Aaron J. Seigo wrote: > > On Tuesday 26 May 2009, Marco Martin wrote: > >> 1) we have two way to set icons: by name and by pixmap, right now by > >> name is setIcon() > >> by pixmap is setImage() > >> (that should r