KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 7 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/7/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 13 Dec 2017 10:55:58 + Build duration: 3 min 30 sec and counting

Re: KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 4 - Failure!

Done.

Fwd: KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 4 - Failure!

org> Date: 13/12/2017 4:15 AM Subject: KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 4 - Failure! To: <kde-frameworks-de...@kde.org>, <kde-dashbo...@kde.org> Cc: *BUILD FAILURE* Build URL https://build.kde.org/job/Frameworks%20plasma-framework% 20kf5-qt5%20FreeBSD

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

discarded. Review request for Plasma. Repository: plasma-framework Description --- We have the version number of the theme and some mtime heuristic yet still we often end up with a broken theme after upgrades when it is changed, when downstreams forget to adjust the version

Re: Review Request 129373: Plasma Framework changes for #129372

dated Nov. 10, 2016, 8:47 p.m.) > > > Review request for Plasma and Eike Hein. > > > Repository: plasma-framework > > > Description > --- > > Plasma Framework changes for #129372 > > > Diffs > - > > src/declarativeimports/

Re: Review Request 129373: Plasma Framework changes for #129372

- > > (Updated Nov. 10, 2016, 8:47 p.m.) > > > Review request for Plasma and Eike Hein. > > > Repository: plasma-framework > > > Description > --- > > Plasma Framework changes for #129372 > > > Diffs

Re: Review Request 129373: Plasma Framework changes for #129372

d.kde.org/r/129373/ > --- > > (Updated Nov. 10, 2016, 8:47 p.m.) > > > Review request for Plasma and Eike Hein. > > > Repository: plasma-framework > > > Description > --- > > Plasma Framework changes for #

Re: Review Request 129373: Plasma Framework changes for #129372

gt; > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129373/ > --- > > (Updated Nov. 10, 2016, 8:47 na

Review Request 129373: Plasma Framework changes for #129372

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129373/ --- Review request for Plasma and Eike Hein. Repository: plasma-framework

Re: Review Request 129203: Fixes for building plasma-framework

marked as submitted. Review request for Plasma. Changes --- Submitted with commit f82d76eb2b915d5097f41a22a9f218e0bb23bb03 by David Edmundson on behalf of Alberto Curro to branch master. Repository: plasma-framework Description --- Being a newbie, following build instruction from

Re: Review Request 129203: Fixes for building plasma-framework

7, 2016, 2:53 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > Being a newbie, following build instruction from the wiki, I could not build > plasma-framework on my Linux mint 18 (ba

Re: Review Request 129203: Fixes for building plasma-framework

d e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129203/ > --- > > (Updated Oct. 17, 2016, 2:53 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description &

Re: Review Request 129203: Fixes for building plasma-framework

--- Updated the selection of right RenderStage depending on version of Qt available. Repository: plasma-framework Description --- Being a newbie, following build instruction from the wiki, I could not build plasma-framework on my Linux mint 18 (based on Ubuntu Xenial). Two

Re: Review Request 129203: Fixes for building plasma-framework

> https://git.reviewboard.kde.org/r/129203/ > --- > > (Updated Oct. 17, 2016, 7:35 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > &

Re: Review Request 129203: Fixes for building plasma-framework

- > > (Updated Oct. 17, 2016, 7:35 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > Being a newbie, following build instruction from the wiki, I could not build > plasma-framework on my Lin

Re: Review Request 129203: Fixes for building plasma-framework

enerated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129203/ > --- > > (Updated Oct. 17, 2016, 7:35 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Desc

Re: Review Request 129203: Fixes for building plasma-framework

Oct. 17, 2016, 1:37 a.m., Alberto Curro wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129203/ > --- > > (Updated Oct. 17, 2016, 1:37 a.m.) > > > Review r

Re: Review Request 129203: Fixes for building plasma-framework

--- Drop changing the Qt Requirement for the framework, applied an extended patch based on another review Repository: plasma-framework Description --- Being a newbie, following build instruction from the wiki, I could not build plasma-framework on my Linux mint 18 (based on Ubuntu

Re: Review Request 129203: Fixes for building plasma-framework

. 17, 2016, 4:37 преди обяд) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > Being a newbie, following build instruction from the wiki, I could not build > plasma-framework on my Linux mint 18 (

Review Request 129203: Fixes for building plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129203/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 129101: Port to new plasma-framework API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 10, 2016, 11:46 p.m.) Status -- This change has been

Re: Review Request 129101: Port to new plasma-framework API

> On Okt. 10, 2016, 8:49 nachm., Kai Uwe Broulik wrote: > > This commit broke panel display/loading for me. > > > > When I have a system tray in a panel (eg. default panel) it won't show up > > on startup. Sorry, the REVIEW link in the commit was wrong. The offending commit is

Re: Review Request 129101: Port to new plasma-framework API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/#review99915 --- This commit broke panel display/loading for me. When I have

Re: Review Request 129101: Port to new plasma-framework API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 10, 2016, 2:30 p.m.) Status -- This change has been

Re: Review Request 129101: Port to new plasma-framework API

> On Oct. 6, 2016, 2:58 a.m., Michael Stemle wrote: > > runners/windowedwidgets/windowedwidgetsrunner.cpp, line 111 > > > > > > *Nit-picky:* If it's not a name, and other parts have a name, maybe we > > should

Re: Review Request 129101: Port to new plasma-framework API

> On Oct. 6, 2016, 4:58 a.m., Michael Stemle wrote: > > runners/windowedwidgets/windowedwidgetsrunner.cpp, line 111 > > > > > > *Nit-picky:* If it's not a name, and other parts have a name, maybe we > > should

Re: Review Request 129101: Port to new plasma-framework API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/#review99802 --- runners/windowedwidgets/windowedwidgetsrunner.cpp (line

Re: Review Request 129101: Port to new plasma-framework API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 5, 2016, 12:54 p.m.) Review request for Plasma.

Re: Review Request 129101: Port to new plasma-framework API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 5, 2016, 12:54 p.m.) Review request for Plasma. Bugs:

Re: Review Request 129101: Port to new plasma-framework API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/#review99792 --- Fix it, then Ship it! applets/systemtray/systemtray.cpp

Re: Review Request 129101: Port to new plasma-framework API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 5, 2016, 1:59 a.m.) Review request for Plasma.

Re: Review Request 129101: Port to new plasma-framework API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 5, 2016, 1:58 a.m.) Review request for Plasma.

Re: Review Request 129101: Port to new plasma-framework API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/#review99791 --- Fix it, then Ship it! shell/shellcorona.cpp (line 1964)

Review Request 129101: Port to new plasma-framework API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: RFC: plasma-framework IndicatorArea formFactor()

On Tue, Sep 20, 2016 at 2:42 PM, David Edmundson wrote: > > then we change our Q_PROPERTY in Plasma::Applet to go to a real > implementation > > system tray containment can then also implements the property. nnnuuuh :/ > Another possible technique is we export a new

Re: RFC: plasma-framework IndicatorArea formFactor()

On Tue, Sep 20, 2016 at 1:32 PM, Marco Martin wrote: > On Tue, Sep 20, 2016 at 2:05 PM, David Edmundson > wrote: > > > > Actually adding a virtual is, but the design pattern of a virtual is > do-able > > in multiple other ways which are binary

Re: RFC: plasma-framework IndicatorArea formFactor()

On Tue, Sep 20, 2016 at 2:05 PM, David Edmundson wrote: > > Actually adding a virtual is, but the design pattern of a virtual is do-able > in multiple other ways which are binary compatiable. > *if* that's the approach we want (and it's my preferred option) I'll make a

Re: RFC: plasma-framework IndicatorArea formFactor()

On Mon, Sep 19, 2016 at 9:16 PM, Marco Martin wrote: > On Mon, Sep 19, 2016 at 8:37 PM, David Edmundson > wrote: > >> perhaps you are right, semantically they are two things, not sure what > >> could be used instead more "proper"(suggestions

Re: RFC: plasma-framework IndicatorArea formFactor()

On Mon, Sep 19, 2016 at 8:37 PM, David Edmundson wrote: > applet->pluginInfo().pluginName()) { > -applet->destroy(); > +QMetaObject::invokeMethod(applet, "cleanUpAndDelete"); > > (in all 3 cases) > > But it's equally messy, and has an issue that

Re: RFC: plasma-framework IndicatorArea formFactor()

On Mon, Sep 19, 2016 at 8:37 PM, David Edmundson wrote: >> perhaps you are right, semantically they are two things, not sure what >> could be used instead more "proper"(suggestions welcome), will think >> more about it. > > > Long term, a virtual hook for immutability?

Re: RFC: plasma-framework IndicatorArea formFactor()

On Mon, Sep 19, 2016 at 7:10 PM, Marco Martin wrote: > On Mon, Sep 19, 2016 at 7:55 PM, David Edmundson > wrote: > > https://bugs.kde.org/show_bug.cgi?id=365967 > > > > It's a bug in that weather applet that it's rendering outside the area it > >

Re: RFC: plasma-framework IndicatorArea formFactor()

On Mon, Sep 19, 2016 at 7:55 PM, David Edmundson wrote: > https://bugs.kde.org/show_bug.cgi?id=365967 > > It's a bug in that weather applet that it's rendering outside the area it > actually has - and that needs fixing anyway. > Introducing a new form factor won't

Re: RFC: plasma-framework IndicatorArea formFactor()

utability to be different in system tray containment compared to it's parent. Sounds fine. +1 But I don't see why we would tie that to the formFactor. Semantically they're not remotely related, the only link is that the system tray happens to need both. > > Unfortunately as it needs changes in pl

RFC: plasma-framework IndicatorArea formFactor()

ity°, because the systray itself should always be able to both add and remove plasmoids in itself even when immutable (even Systemimmutable) it could still hide/disable the ui to do so when immutable, but must be programmatically able to do so. Unfortunately as it needs changes in plasma-framework i

[plasma-framework] autotests: Skip autotest that is broken with Qt 5.5

-0autotests/dialogstatetest.cpp http://commits.kde.org/plasma-framework/8abeceaffd0c93028810ea12131b7fa8bcd13b12 diff --git a/autotests/dialogstatetest.cpp b/autotests/dialogstatetest.cpp index f8ac9bc..333f74f 100644 --- a/autotests/dialogstatetest.cpp +++ b/autotests/dialogstatetest.cpp @@ -37,6 +3

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

May 8, 2016, 4:15 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Deprecate downloadPath(const QString ) in favor of downloadPath() since > the file argument is not used.

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

To reply, visit: > https://git.reviewboard.kde.org/r/127870/ > --- > > (Updated Mai 8, 2016, 4:15 nachm.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > D

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

May 8, 2016, 4:15 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Deprecate downloadPath(const QString ) in favor of downloadPath() since > the file argument is not used.

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!

On Monday 16 May 2016, David Faure wrote: > > Can someone take a look? Can more precise checks be added before the > QVERIFY to ease debugging when this fails? > At least a QVERIFY2(QFile::exists(iconPath), qPrintable(iconPath)) would be > good, right? But what if iconTheme is null? Then for sure

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!

On Monday 16 May 2016, David Faure wrote: > Can someone take a look? Can more precise checks be added before the > QVERIFY to ease debugging when this fails? > At least a QVERIFY2(QFile::exists(iconPath), qPrintable(iconPath)) would be > good, right? But what if iconTheme is null? Then for sure

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux, All, gcc - Build # 44 - Still Unstable!

On Saturday, May 14, 2016 10:52:16 AM CEST no-re...@kde.org wrote: > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/ PLATFORM=Linux,Variation=All,compiler=gcc/44/ Project: > PLATFORM=Linux,Variation=All,c

Review Request 127870: plasma-framework: AppletInterface::downloadPath()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127870/ --- Review request for KDE Frameworks and Plasma. Repository: plasma

Re: [plasma-framework] src/plasma: if path is passed, pick the tail

anteed that part is equal to > the plugin name. > > BUG:359902 > Change-Id: Ic7300b7c12d7693bcb5590e29de780109a8ff81c > > M +4-2 src/plasma/pluginloader.cpp > > http://commits.kde.org/plasma-framework/40b99a91222f59a6172b8673536c3c15c0458bf6 > > diff --git a/src/

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

marked as submitted. Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Changes --- Submitted with commit 9f625326745369b289952b3d83a2f3478cca4748 by Aleix Pol to branch master. Repository: plasma-framework Description --- Fix almost all the Clazy warnings in plasma

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

org/r/126672/ > --- > > (Updated Jan. 17, 2016, 9:50 p.m.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. > > > Repository: plasma-framework > > > Description > --- > > Fix almost all the

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

, 9:50 p.m.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. > > > Repository: plasma-framework > > > Description > --- > > Fix almost all the Clazy warnings in plasma-framework. > > Related GCI-2015 task: > [https://

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

rated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126672/ > --- > > (Updated Jan. 17, 2016, 8:50 nachm.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. > > > Repository: plasma-framework > > > Description > --- > > F

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

d Jan. 17, 2016, 9:50 p.m.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. > > > Repository: plasma-framework > > > Description > --- > > Fix almost all the Clazy warnings in plasma-framework. > > Related GCI-2015 task:

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126672/ > --- > > (Updated Jan. 17, 2016, 9:50 p.m.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

> > (Updated Jan. 5, 2016, 6:11 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > We have the version number of the theme and some mtime heuristic yet still we > often end up w

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126642/ > --- > > (Updated Jan. 5, 2016, 6:11 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework &g

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

eviewboard.kde.org/r/126642/ > --- > > (Updated Jan. 5, 2016, 6:11 nachm.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > We have the version number of the theme and some mtime heuris

Re: Review Request 126812: plasma-framework: Fix document.svgz to use color from stylesheet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126812/#review91401 --- Ship it! Ship It! - Marco Martin On Jan. 19, 2016,

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

: > https://git.reviewboard.kde.org/r/126642/ > --- > > (Updated Jan. 5, 2016, 6:11 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > &g

Re: Review Request 126812: plasma-framework: Fix document.svgz to use color from stylesheet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126812/ --- (Updated Jan. 21, 2016, 2:42 p.m.) Status -- This change has been

Re: Review Request 126791: plasma-framework: Fix list.svgz to use color from stylesheet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126791/#review91320 --- Ship it! Ship It! - Marco Martin On Jan. 18, 2016,

Re: Review Request 126791: plasma-framework: Fix list.svgz to use color from stylesheet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126791/ --- (Updated Jan. 19, 2016, 1:37 p.m.) Status -- This change has been

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

1 nachm.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > We have the version number of the theme and some mtime heuristic yet still we > often end up with a broken theme after upgrades when

Review Request 126812: plasma-framework: Fix document.svgz to use color from stylesheet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126812/ --- Review request for Plasma. Description --- Fixed "document-encrypt"

Review Request 126791: plasma-framework: Fix list.svgz to use color from stylesheet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126791/ --- Review request for Plasma. Description --- Fixed the color for

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

, Plasma and Aleix Pol Gonzalez. Changes --- Fixed the issue Repository: plasma-framework Description --- Fix almost all the Clazy warnings in plasma-framework. Related GCI-2015 task: [https://codein.withgoogle.com/tasks/6272625345036288/](https://codein.withgoogle.com/tasks

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

6672/ > --- > > (Updated Янв. 8, 2016, 1:34 д.п.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. > > > Repository: plasma-framework > > > Description > --- > &g

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

-- > > (Updated Jan. 8, 2016, 1:34 a.m.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. > > > Repository: plasma-framework > > > Description > --- > > Fix almost all the Clazy warnings in p

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126672/ > --- > > (Updated Jan. 8, 2016, 2:34 a.m.) > > > Review request

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

tically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126672/ > ------- > > (Updated Jan. 8, 2016, 2:34 a.m.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. > > >

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126672/ > --- > > (Updated Jan. 8, 2016, 1:34 a.m.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. > > > Repository: plasma-framework > > > Description &g

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

an. 8, 2016, 2:34 a.m.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. > > > Repository: plasma-framework > > > Description > --- > > Fix almost all the Clazy warnings in plasma-framework. > > Related GCI-2015 task:

Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126642/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

. This wont' solve the problem of downstreams doing their own themes and failing to update their version numbers properly unless they always release at the same time as plasma-framework. - David Edmundson On Jan. 5, 2016, 6:11 p.m., Kai Uwe Broulik wrote

Re: Review Request 126148: [plasma-framework] qstring optimizations

marked as submitted. Review request for Plasma, Marco Martin and Martin Klapetek. Changes --- Submitted with commit c7c2980f1429e0b0972b8754c37a2c4cd4ef5233 by Nick Shaforostoff to branch master. Repository: plasma-framework Description --- also contains fix for clazy warning

Re: Review Request 126148: [plasma-framework] qstring optimizations

Nov. 23, 2015, 10:19 p.m.) > > > Review request for Plasma, Marco Martin and Martin Klapetek. > > > Repository: plasma-framework > > > Description > --- > > also contains fix for clazy warning regarding iterating over temporary > roleNames()

Re: Review Request 126148: [plasma-framework] qstring optimizations

> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126148/ > --- > > (Updated Nov. 23, 2015, 10:19 p.m.) > > > Review request for Plasma, Marco Martin an

Re: Review Request 126148: [plasma-framework] qstring optimizations

Martin and Martin Klapetek. Changes --- removed QStringLiteral use for LoadPackage calls becaus they may store the string argument in the static variable Repository: plasma-framework Description --- also contains fix for clazy warning regarding iterating over temporary roleNames

Re: Review Request 126148: [plasma-framework] qstring optimizations

0:19 p.m.) > > > Review request for Plasma, Marco Martin and Martin Klapetek. > > > Repository: plasma-framework > > > Description > --- > > also contains fix for clazy warning regarding iterating over temporary > roleNames() object > > note that for QRegEx

Re: Review Request 126148: [plasma-framework] qstring optimizations

l. To reply, visit: > https://git.reviewboard.kde.org/r/126148/ > --- > > (Updated Nov. 23, 2015, 8:36 nachm.) > > > Review request for Plasma, Marco Martin and Martin Klapetek. > > > Repository: plasma-frame

Re: Review Request 126148: [plasma-framework] qstring optimizations

kde.org/r/126148/ > --- > > (Updated Nov. 23, 2015, 10:19 p.m.) > > > Review request for Plasma, Marco Martin and Martin Klapetek. > > > Repository: plasma-framework > > > Description > ---

Re: Review Request 126148: [plasma-framework] qstring optimizations

d.kde.org/r/126148/ > --- > > (Updated Nov. 23, 2015, 9:36 p.m.) > > > Review request for Plasma, Marco Martin and Martin Klapetek. > > > Repository: plasma-framework > > > Description > --- > > also contains fix for clazy warning reg

Review Request 126148: [plasma-framework] qstring optimizations

: plasma-framework Description --- also contains fix for clazy warning regarding iterating over temporary roleNames() object note that for QRegExp constructor and for QIcon::fromTheme() i used QLatin1String because QStringLiteral is known to produce crashes-on-exit if the code is inside

Re: Release plasma-framework + kdeclarative beta with plasma 5.5beta?

ys >> and there is some stuff in workspace that requires latest >> plasma-framework + kdeclarative, >> > > Then it needs reverting, you missed the window. > Ok, reverted and postponed for 5.6. Cheers -- Martin Klapetek | KDE Developer ___

Re: Release plasma-framework + kdeclarative beta with plasma 5.5beta?

On Wed, Nov 18, 2015 at 2:25 PM, Martin Klapetek <martin.klape...@gmail.com> wrote: > Hi, > > so there's a plasma 5.5 beta release in the following days > and there is some stuff in workspace that requires latest > plasma-framework + kdeclarative, > Then it needs revertin

Release plasma-framework + kdeclarative beta with plasma 5.5beta?

Hi, so there's a plasma 5.5 beta release in the following days and there is some stuff in workspace that requires latest plasma-framework + kdeclarative, their qml imports to be more precise. The final 5.5 will be out when those frameworks are out but for the beta, we'll be releasing half-broken

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 116 - Still Unstable!

st > > > > > > Is anyone looking into fixing that, before making more commits to > > > plasma-framework? > > > > hmm, is the oxygen icon theme not installed anymore in kci? > > oxygen is not a dependency of frameworksintegration so i guess no. > >

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 116 - Still Unstable!

ped: 0 test(s), Total: 11 test(s)Failed: > > TestSuite.dialognativetest > > Is anyone looking into fixing that, before making more commits to > plasma-framework? hmm, is the oxygen icon theme not installed anymore in kci? -- Marco Martin

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux, All, gcc - Build # 116 - Still Unstable!

> > > M=Linux,compiler=gcc/31/ Name: (root) Failed: 1 test(s), Passed: 10 > > > test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: > > > TestSuite.dialognativetest > > > > Is anyone looking into fixing that, before making more commits to > > plasma-fr

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux, All, gcc - Build # 116 - Still Unstable!

ativetest Is anyone looking into fixing that, before making more commits to plasma-framework? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: [plasma-framework] src/plasma: plasma: Fix applet actions might be nullptr

lesliezhai into branch 'master'. > > > > plasma: Fix applet actions might be nullptr > > BUG:351777 > > > > M +1 -1 src/plasma/applet.cpp > > > > http://commits.kde.org/plasma-framework/4e9b32d80d6b43ad3d1ddd47c94 > > 8ad066608b052 > > > > di

Re: [plasma-framework] src/plasma: plasma: Fix applet actions might be nullptr

/applet.cpp http://commits.kde.org/plasma-framework/4e9b32d80d6b43ad3d1ddd47c94 8ad066608b052 diff --git a/src/plasma/applet.cpp b/src/plasma/applet.cpp index 89c..3716a83 100644 --- a/src/plasma/applet.cpp +++ b/src/plasma/applet.cpp @@ -568,7 +568,7 @@ QListQAction * Applet

Change in plasma-framework[master]: Fix build on Qt 5.2

: Ia183cf55bed764747dbba727346f18df396affeb --- M src/declarativeimports/calendar/calendar.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/62/462/1 diff --git a/src/declarativeimports/calendar/calendar.cpp b/src

Re: Review Request 123276: Plasma-framework: Fix coding style, width should be renamed to height.

.) Review request for Plasma. Repository: plasma-framework Description --- Fix coding style width - height. Diffs - src/plasmaquick/appletquickitem.cpp 1abedf0 Diff: https://git.reviewboard.kde.org/r/123276/diff/ Testing --- Thanks, Antonis

Re: Review Request 123276: Plasma-framework: Fix coding style, width should be renamed to height.

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 684e456f8433a3234345d6f8f5ccee230ee8 by Antonis Tsiapaliokas to branch master. Repository: plasma-framework Description --- Fix coding style width - height. Diffs - src/plasmaquick

<    1   2   3   4   5   6   7   >