Re: plasma apps and screen information

2008-10-29 Thread Guillaume Pothier
2008/10/29 Aaron J. Seigo <[EMAIL PROTECTED]>: > so, some small implementation fixes, but i like how simple this makes things > while removing QDesktopWidget use from libplasma. after the above changes are > made, pls commit. Ok, committed. I used asserts instead of null checks, so finally I do no

Re: plasma apps and screen information

2008-10-28 Thread Aaron J. Seigo
On Tuesday 28 October 2008, Guillaume Pothier wrote: > 2008/10/29 Aaron J. Seigo <[EMAIL PROTECTED]>: > > On Tuesday 28 October 2008, Guillaume Pothier wrote: > >> to have the corona register itself when created. Ok to commit? > > > > getting closer =) > > Cool :-) > > > first, the patch needs to g

Re: plasma apps and screen information

2008-10-28 Thread Guillaume Pothier
2008/10/29 Aaron J. Seigo <[EMAIL PROTECTED]>: > On Tuesday 28 October 2008, Guillaume Pothier wrote: >> to have the corona register itself when created. Ok to commit? > > getting closer =) Cool :-) > > first, the patch needs to guard against containment() and/or corona() being 0. Do we need to

Re: plasma apps and screen information

2008-10-28 Thread Aaron J. Seigo
On Tuesday 28 October 2008, Guillaume Pothier wrote: > to have the corona register itself when created. Ok to commit? getting closer =) first, the patch needs to guard against containment() and/or corona() being 0. doing dynamic_casts like this: menu.exec(dynamic_cast(scene())->popupPosition(th

Re: plasma apps and screen information

2008-10-28 Thread Guillaume Pothier
Ok, here comes a new version of the patch. I think I took into account all your comments: the new methods in Corona have a default implementation, I removed the ViewerCorona class, moved popupPosition to Corona, removed the convenience methods from View and Applet. The only remaining problem, I thi

Re: plasma apps and screen information

2008-10-27 Thread Aaron J. Seigo
On Monday 27 October 2008, Guillaume Pothier wrote: > 2008/10/27 Aaron J. Seigo <[EMAIL PROTECTED]>: > >> The latter should probably return a QRegion instead, according to what > >> you said about toolbox placement. > > > > yes, it should be a QRegion. > > ok, I'll use QRegion in the API, but for n

Re: plasma apps and screen information

2008-10-27 Thread Guillaume Pothier
2008/10/27 Aaron J. Seigo <[EMAIL PROTECTED]>: >> - Added three methods to Corona: >>int numScreens() >>QRect screenGeometry(int) >>QRect availableScreenGeometry(int) > > these shouldn't be pure virtual. they can return silly values like by default, > of course: > ok > >> The latter s

Re: plasma apps and screen information

2008-10-27 Thread Aaron J. Seigo
On Friday 24 October 2008, Guillaume Pothier wrote: > 2008/10/23 Aaron J. Seigo <[EMAIL PROTECTED]>: > > On Wednesday 22 October 2008, Guillaume Pothier wrote: > >> Just tell me if you want me to go ahead. > > > > please do =) > > Ok, here comes the patch. In summary: > - Added three methods to Cor

Re: plasma apps and screen information

2008-10-26 Thread Aaron J. Seigo
On Sunday 26 October 2008, Guillaume Pothier wrote: > On Fri, Oct 24, 2008 at 12:08 PM, Guillaume Pothier <[EMAIL PROTECTED]> wrote: > > Ok, here comes the patch. In summary: > > - Added three methods to Corona: > > int numScreens() > > QRect screenGeometry(int) > > QRect availableScreenGeom

Re: plasma apps and screen information

2008-10-26 Thread Guillaume Pothier
On Fri, Oct 24, 2008 at 12:08 PM, Guillaume Pothier <[EMAIL PROTECTED]> wrote: > Ok, here comes the patch. In summary: > - Added three methods to Corona: > int numScreens() > QRect screenGeometry(int) > QRect availableScreenGeometry(int) > The latter should probably return a QRegion instead,

Re: plasma apps and screen information

2008-10-24 Thread Guillaume Pothier
2008/10/23 Aaron J. Seigo <[EMAIL PROTECTED]>: > On Wednesday 22 October 2008, Guillaume Pothier wrote: >> Just tell me if you want me to go ahead. > > please do =) Ok, here comes the patch. In summary: - Added three methods to Corona: int numScreens() QRect screenGeometry(int) QRect avai

Re: plasma apps and screen information

2008-10-23 Thread Aaron J. Seigo
On Thursday 23 October 2008, Guillaume Pothier wrote: > 2008/10/23 Aaron J. Seigo <[EMAIL PROTECTED]>: > > hm... so viewport is a bad name. i completely forgot that we'd need that > > method in a scroll area subclass (View) ... well, let's leave it at > > screen then, and just allow the Corona to s

Re: plasma apps and screen information

2008-10-23 Thread Guillaume Pothier
2008/10/23 Aaron J. Seigo <[EMAIL PROTECTED]>: > hm... so viewport is a bad name. i completely forgot that we'd need that > method in a scroll area subclass (View) ... well, let's leave it at screen > then, and just allow the Corona to say what a "screen" means. Argh! Ok, the patch will be much sm

Re: plasma apps and screen information

2008-10-23 Thread Aaron J. Seigo
On Thursday 23 October 2008, Guillaume Pothier wrote: > 2008/10/23 Aaron J. Seigo <[EMAIL PROTECTED]>: > > On Wednesday 22 October 2008, Guillaume Pothier wrote: > >> Just tell me if you want me to go ahead. > > > > please do =) > > It ended up a much bigger task than I thought... adding the method

Re: plasma apps and screen information

2008-10-23 Thread Guillaume Pothier
2008/10/23 Aaron J. Seigo <[EMAIL PROTECTED]>: > On Wednesday 22 October 2008, Guillaume Pothier wrote: >> Just tell me if you want me to go ahead. > > please do =) It ended up a much bigger task than I thought... adding the methods to corona and making use of them was rather simple, but I also ch

Re: plasma apps and screen information

2008-10-22 Thread Aaron J. Seigo
On Wednesday 22 October 2008, Guillaume Pothier wrote: > Just tell me if you want me to go ahead. please do =) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: T

Re: plasma apps and screen information

2008-10-22 Thread Guillaume Pothier
2008/10/19 Aaron J. Seigo <[EMAIL PROTECTED]>: > to get access to viewport information (size, etc) a method could be added to > Corona that applications could subclass to return actual and available size > information for a given viewport. Aaron if you want I can start hacking on that. I would add

Re: plasma apps and screen information

2008-10-20 Thread Guillaume Pothier
2008/10/19 Aaron J. Seigo <[EMAIL PROTECTED]>: > hi.. > > to get access to viewport information (size, etc) a method could be added to > Corona that applications could subclass to return actual and available size > information for a given viewport. > > i considered putting this in View instead, but

plasma apps and screen information

2008-10-19 Thread Aaron J. Seigo
hi.. in a few places in libplasma we still assume that we're dealing with physical screens. this probably isn't correct, because of the whole "we're not making a desktop" thing. ;) something that occurred to me is that we could probably change the convention from talking about "screens" to som