System tray notification

Hi, I don't write a bug report, as this is not a bug in itself, just something that seems to be badly designed. Or maybe it is still unfinished, in that case ignore the mail. The idea of keeping the notifications visible for a longer time makes sense and I support it. The way how it works now

Re: System tray notification

Marco Martin wrote: > true, the problem is that sophisticate communication like "the mail > associated to that notification has been read" is totally impossible in > the spec (and probably quite out of scope too, since it would require too > much burden to the applications themselves, situation tha

Re: System tray notification

Andreas Marschke wrote: > AFAIK the notifications do have a clickable cross in the upper corner and > a dragable title bar so basically no worries right? > Happy clicking on them. :) Obviously that doesn't work if you have notifications for mail folder or RSS feeds with fairly high traffic. You

Re: Notifications not automatically hidden anymore

Hi, I've been testing and evaluating the current behavior of the systray notifications, and I have to admit, that I still don't like it. Now that the notifications are cleared after 5 minutes when using the computer is better, but not enough, and I agree with this statement: Aleix Pol wrote: >

Re: The future of Power Management - together with Activities

On Saturday, October 01, 2011 16:27:48 Dario Freddi wrote: > Hello all, and sorry for cross-posting. > [...] I can't comment on activities, never used them, nor feel the need to use them. So this sounds more like the power management applet would force me to create and use activites. What I ca

Re: The future of Power Management - together with Activities

[Please reply on both lists if you cross-posted, otherwise dicussion will be more fragmented. I just looked up the plasma list out of curiosity, normally I don't follow, so your mail would have been missed.] Dario Freddi wrote: >> I can't comment on activities, never used them, nor feel the nee

Re: The future of Power Management - together with Activities

On Saturday, October 01, 2011 23:13:06 Dario Freddi wrote: > > Is it? Certainly disabling desktop effects and 3D acceleration has > > an > > impact. > > Sorry to disappoint you, but this action will be removed in 4.8. > Martin has explicitely stated that for how compositing in KDE works > now turn

Re: The future of Power Management - together with Activities

On Sunday, October 02, 2011 14:45:58 Dario Freddi wrote: > > That was one example. Another example brought up is e.g switching of > > strigi or nepomuk indexing when switching to a power saving profile. > > These two are something that usually kick in when you are in idle > > mode, exactly when the

Re: The future of Power Management - together with Activities

On Sunday, October 02, 2011 17:04:50 Martin Gr��lin wrote: > So please calmn down and lets focus on improving the user experience > by not spending too much time on too long� threads. I'm far from being upset or anything. I just gave my opinion, which seems to match others as well. We were *asked

Re: The future of Power Management - together with Activities

On Sunday, October 02, 2011 20:31:11 Dario Freddi wrote: > I don't think so. Every other system does a similar thing: there is no > use in saving battery when you're on AC, when you are on battery > these components are turned off. I don't think this should be > configurable at all, and to a certai

KRunner plugin documentation

Hi, I like a lot the KRunner plugins, but I find one issue with them: it is not documented how you should use them. I discovered some of the features, but probably not everything. And I see no place in the UI where the documentation could be plugged in. Every plugin has an Info button, but tha

Re: KRunner plugin documentation

Sebastian Kügler wrote: > Hey Andras, > > On Wednesday, December 07, 2011 09:55:59 Andras Mantia wrote: >> I like a lot the KRunner plugins, but I find one issue with them: it is >> not documented how you should use them. I discovered some of the >> features, but pro

Re: KRunner plugin documentation

Sebastian Kügler wrote: > The text is not semi-transparant on my machine, maybe you're using a > different theme? I have the same issue with Air and Oxygen. Here is a screenshot: http://i.imgur.com/SjgWN.png The background is the composer for this mail. :) Andras ___

Re: KRunner plugin documentation

Martin Klapetek wrote: > On Wed, Dec 7, 2011 at 11:50, Andras Mantia wrote: > >> Sebastian Kügler wrote: >> >> > The text is not semi-transparant on my machine, maybe you're using a >> > different theme? >> >> I have the same iss

Re: KRunner plugin documentation

Sebastian Kügler wrote: > On Wednesday, December 07, 2011 12:08:41 Martin Klapetek wrote: >> On Wed, Dec 7, 2011 at 12:04, Andras Mantia wrote: >> > Martin Klapetek wrote: >> > > On Wed, Dec 7, 2011 at 11:50, Andras Mantia wrote: >> > >> Sebastian

[PATCH] Show the job progress in separate dialog

Hi, the attached patch introduces a config option to show the job progress dialogs as separate dialogs. The reason is: 1) people are used to the old ones 2) the new ones, integrated into the systray notification have some limitation compared to the old ones, like not being visible every time,

Re: uiserver interaction, was: Re: [PATCH] Show the job progress in separate dialog

First of all what Sebas wrote are my main problems with the new behavior. I just didn't explain that detailed. :) >> - An option to keep the jobwindow visible when it looses focus. Sometime, >> I do indeed wait for a job to be finished, and then it's annoying if the >> dialog keeps vanishing >

Re: Systray Notifications

Rob Scheepmaker wrote: > Agreed, Ideally those should be hidden. Something I could do is only let > notifications appear after a job has been running for a couple of seconds > so all those very short jobs won't bother you, As far as I know this is exactly what happens with the old dialogs. > uni

plasma & plasma-desktop

Hi, I noticed that after I compiled trunk I have two panels, systray without icons and similar strange things. After a while I realized that I have both plasma and plasma-desktop running. It happens because I have a distro packaged KDE 4.1 (and now 4.2) in /usr and a self compiled one in /opt

Review Request: Display correct week number in the calendar widget

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/76/ --- Review request for Plasma. Summary --- The calendar widget currently display

Re: Review Request: Display correct week number in the calendar widget

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/76/#review147 --- Any opinion about this? - Andras On 2009-02-14 06:30:08, Andras

Re: Review Request: Display correct week number in the calendar widget

This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/76/#review154 --- On 2009-02-14 06:30:08, Andras Mantia wrote: > > -

Re: Review Request: Display correct week number in the calendar widget

> > on the other hand, it makes international scheduling with people over the > > phone a bit harder ("your week 32 is my week 33??") ... but if you're > > concerned about that you'll use a standard calendar system rather than a > > regional one, no? so ..

D17408: Make accessibility warning dialog usable again

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY Layout was completely broken, resulting in an empty dialog. REPOSITORY R119 Plasma Desktop BRANCH accessbility-fixes REVISION

D17415: Fix event type checking

amantia created this revision. amantia added reviewers: Plasma, Plasma Accessibility, aacid. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY The ev->xkbType looks to be a value that is defined in xkb.xml (usuall

D17415: Fix event type checking

amantia updated this revision to Diff 47100. amantia added a comment. Added comment for workaround CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17415?vs=47065&id=47100 REVISION DETAIL https://phabricator.kde.org/D17415 AFFECTED FILES kaccess/kaccess.cpp To: amantia, #plasma,

D17408: Make accessibility warning dialog usable again

This revision was automatically updated to reflect the committed changes. Closed by commit R119:40b9e34ced6b: Make accessibility warning dialog usable again (authored by amantia). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17408?vs=47044&id=47374#toc REPOSITORY R119 Plasma Desktop

D17415: Fix event type checking

amantia closed this revision. amantia added a comment. Messed up a little and this got landed together with another patch https://cgit.kde.org/plasma-desktop.git/commit/?id=40b9e34ced6b421c8585f304d91a2da37f40c4d6 REVISION DETAIL https://phabricator.kde.org/D17415 To: amantia, #plasma, #pl

D17533: Make the button's purprose more clear

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY BUG: 190369 REPOSITORY R119 Plasma Desktop BRANCH accesbility_dialog_improvement REVISION DETAIL https://phabricator.kde.or

D17536: Make accessibility warning dialog usable again and fix event handling

amantia created this revision. amantia added reviewers: Plasma Accessibility, Plasma, aacid. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY Layout was completely broken, resulting in an empty dialog. REPOSITORY R119 Plasma Desktop BRANCH Plasma

D17536: Make accessibility warning dialog usable again and fix event handling

amantia added a comment. Accessibility bugfixes cherry picked from master REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17536 To: amantia, #plasma_accessibility, #plasma, aacid Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterbe

D17533: Make the button's purprose more clear

amantia planned changes to this revision. amantia added a comment. Will have to rework, I missed some cases(the dialog might as to activate. deactivate or "activate some, deactivate others"), it is not as simple as I thought. INLINE COMMENTS > davidedmundson wrote in kaccess.cpp:713 > can w

D17533: Make the button's purprose more clear

amantia updated this revision to Diff 47441. amantia added a comment. Reworked, by reshuffling the dialog text, instead of renaming the buttons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47434&id=47441 BRANCH accesbility_dialog_improv

D17557: Make accessibility warning dialog usable again

amantia added a comment. Backport to 5.12 branch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17557 To: amantia, #plasma_accessibility, #plasma, aacid Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D17557: Make accessibility warning dialog usable again

amantia created this revision. amantia added reviewers: Plasma Accessibility, Plasma, aacid. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY Layout was completely broken, resulting in an empty dialog. REPOSITORY R119 Plasma Desktop BRANCH Plasma

D17557: Make accessibility warning dialog usable again

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17557 To: amantia, #plasma_accessibility, #plasma, aacid, davidedmundson Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

D17536: Make accessibility warning dialog usable again and fix event handling

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17536 To: amantia, #plasma_accessibility, #plasma, aacid, mart Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17533: Make the button's purprose more clear

amantia added a comment. How it looked before: F6476429: new_dialog.jpg How it looks now: F6476432: new_dialog.jpg REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17533 To: ama

D17533: Make the button's purpose more clear

amantia added a comment. You can't change to Yes/No (that was my first try), as the question might be one of the following: - "Activate foo ?" - "Deactivate foo?" - "Activate foo and deactivate bar?" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D175

D17533: Make the button's purpose more clear

amantia updated this revision to Diff 47590. amantia added a comment. Improve dialog title as well REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47441&id=47590 BRANCH accesbility_dialog_improvement REVISION DETAIL https://phabricator.

D17533: Make the button's purpose more clear

amantia added a comment. I'm not a native speaker, but I don't see how OK/Cancel is better. The dialog shows a question that can be answered with Yes or No. See also the HIG https://hig.kde.org/components/assistance/message.html > - Apply confirmation button labels when further interac

D17533: Make the button's purpose more clear

amantia updated this revision to Diff 47661. amantia added a comment. Make the question text bold REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47590&id=47661 BRANCH accesbility_dialog_improvement REVISION DETAIL https://phabricator.k

D17533: Make the button's purpose more clear

amantia added a comment. Yes, most questions can be answered with Yes/No, and still I'd say it is better to use Yes/No, instead of OK/Cancel. OK/Cancel is rather useless, although widely used, I know... I made the question text bold now, and unfortunately as I said I don't want to spend mo

D17533: Make the button's purpose more clear

amantia abandoned this revision. amantia added inline comments. INLINE COMMENTS > ngraham wrote in kaccess.cpp:870 > Let's use `xi18nc()` for this: > > `xi18nc("@info", "%1", question)` That looks weird., as it creates a translatable string for no reason. Obviously best would be to update all

D17533: Make the button's purpose more clear

amantia updated this revision to Diff 47712. amantia added a comment. Change the individual texts REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47661&id=47712 BRANCH accesbility_dialog_improvement REVISION DETAIL https://phabricator.k

D17533: Make the button's purpose more clear

amantia added a comment. I perfectly agree with Frederik. There is room for improvement, but my intention was not to completely change it, just to make it slightly more clear what this is about. The rest can be fixed in a separate commit, if anyone is interested to do it. :) INLINE COMMENTS

D17533: Make the button's purpose more clear

amantia updated this revision to Diff 47714. amantia added a comment. Use title case REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47712&id=47714 BRANCH accesbility_dialog_improvement REVISION DETAIL https://phabricator.kde.org/D17533

D17657: Notify also if modes have changed

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY Will be needed in the KCM to correctly update the UI REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://

D17658: Redraw the slider if modes have changed

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY This can happen if a monitor was not configured at all, the KCM is shown when it first plugged in and the user selects to not conf

D17657: Notify also if modes have changed

amantia added inline comments. INLINE COMMENTS > davidedmundson wrote in output.cpp:583-585 > isn't that what this is doing? Good point, missed it. @dvratil any reason why it emits outputChanged and not modesChanged? Actually setModes emits both, so maybe indeed it is easier to just put modesC

D17658: Redraw the slider if modes have changed

amantia added inline comments. INLINE COMMENTS > davidedmundson wrote in resolutionslider.cpp:144 > does this not cause the apply button to enable immediately when a user hasn't > changed anything? I don't see how it would do that. This is called either when an output is set up the first time

D17657: Notify also if modes have changed

amantia updated this revision to Diff 47789. amantia added a comment. Simplify REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17657?vs=47778&id=47789 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17657 AFFECTED FILES src/output

D17658: Redraw the slider if modes have changed

amantia updated this revision to Diff 47830. amantia added a comment. - Show unconnected displayed at the left REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17658?vs=47779&id=47830 BRANCH rework_qml_part REVISION DETAIL https://phabricator.kde.org/D1

D17658: Redraw the slider if modes have changed

amantia updated this revision to Diff 47831. amantia added a comment. Undo last change REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17658?vs=47830&id=47831 BRANCH fix_null_size REVISION DETAIL https://phabricator.kde.org/D17658 AFFECTED FILES kcm

D17685: Notify also if modes have changedBackport for D17657Depends on D17657

amantia created this revision. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY Will be needed in the KCM to correctly update the UI REPOSITORY R110 KScreen Library BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D17685 AFFECTE

D17686: Redraw the slider if modes have changed

amantia created this revision. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY This can happen if a monitor was not configured at all, the KCM is shown when it first plugged in and the user selects to not configure it. In the UI it will appear wit

D17685: Notify also if modes have changed

amantia added a comment. I have on for master and one for Plasma 5.12, as we want this in 5.12 as well, if approved. Should I keep only one of them? REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17685 To: amantia, #plasma, dvratil Cc: davidedmundson, plasm

D17657: Notify also if modes have changed

amantia abandoned this revision. amantia added a comment. Will fix first in 5.12 and merge to master, as per https://phabricator.kde.org/D17685 REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17657 To: amantia, dvratil Cc: davidedmundson, plasma-devel, GB_2,

D17685: Notify also if modes have changed

amantia closed this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D17685 To: amantia, #plasma, dvratil Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17686: Redraw the slider if modes have changed

amantia closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D17686 To: amantia, #plasma, dvratil Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17658: Redraw the slider if modes have changed

amantia abandoned this revision. amantia added a comment. Abandoned in favor of https://phabricator.kde.org/D17686 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D17658 To: amantia, dvratil Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D17682: Show unconnected displays at the right side of the main screen

amantia closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D17682 To: amantia, dvratil Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17533: Make the button's purpose more clear

amantia added a comment. Ping? I'll push this if there are no strong objections. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17533 To: amantia, #plasma_accessibility, davidedmundson, aacid, ngraham Cc: pino, gladhorn, ngraham, plasma-devel, kvanton, jralei

D17533: Make the button's purpose more clear

amantia added a comment. I understand that, of course. I think the question is: is this an improvement or not? I think it is (not perfect, has problems, but an improvement), but if considered to be not, I will just abandon it, no hard feelings. REPOSITORY R119 Plasma Desktop REVISION DETA

D18091: Backport "Show unconnected displays at the right side of the main screen"https://phabricator.kde.org/D17682

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REPOSITORY R104 KScreen BRANCH backport_screen_to_right REVISION DETAIL https://phabricator.kde.org/D18091 AFFECTED FILES kcm/src/declarativ

D18092: Backport "Show unconnected displays at the right side of the main screen"

amantia created this revision. amantia added a project: Plasma. amantia requested review of this revision. REVISION SUMMARY https://phabricator.kde.org/D17682 REPOSITORY R104 KScreen BRANCH dynamic_scale REVISION DETAIL https://phabricator.kde.org/D18092 AFFECTED FILES kcm/src/declar

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia updated this revision to Diff 48998. amantia added a comment. - Don't reset the moved display position REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18093?vs=48953&id=48998 BRANCH fix_reset_output_pos REVISION DETAIL https://phabricator.kde.o

D18100: Calculate screen scaling dynamically, so it always fits to the page

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY Don't reset the moved display position This fixes the problem that after moving a display, clicking on another one and clicki

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia updated this revision to Diff 49002. amantia added a comment. Restore REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18093?vs=48998&id=49002 BRANCH dynamic_scale REVISION DETAIL https://phabricator.kde.org/D18093 AFFECTED FILES kcm/src/decl

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia added a comment. It is a followup and extension of https://phabricator.kde.org/D17682 Basically it is possible that you have 3-4 monitors and only 2.5 or so are visible, because they don't fit in the dialog. This patch makes sure they are all visible. The previous patch just redu

D18121: Don't lose the widget layout after Default is pressed

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY BUG: 400302 REPOSITORY R104 KScreen BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D18121 AFFECTED FILES

D18121: Don't lose the widget layout after Default is pressed

amantia closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D18121 To: amantia, dvratil, #plasma, davidedmundson Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18091: Backport "Show unconnected displays at the right side of the main screen"https://phabricator.kde.org/D17682

amantia updated this revision to Diff 50656. amantia added a comment. Don't use QQuickItem size(), use width() directly, so it builds with Qt 5.9 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18091?vs=48951&id=50656 REVISION DETAIL https://phabricator.kde.org/D18091 AFFECTED FIL

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia updated this revision to Diff 50657. amantia added a comment. Make it work with Qt 5.9 REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18093?vs=49002&id=50657 BRANCH dynamic_scale REVISION DETAIL https://phabricator.kde.org/D18093 AFFECTED FIL

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D18093 To: amantia, #plasma, dvratil Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18101: Don't reset the moved display position

amantia updated this revision to Diff 50659. amantia added a comment. Rebased REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18101?vs=49003&id=50659 BRANCH fix_reset_output_pos REVISION DETAIL https://phabricator.kde.org/D18101 AFFECTED FILES kcm/s

D18101: Don't reset the moved display position

This revision was automatically updated to reflect the committed changes. Closed by commit R104:2c5af49d3de7: Don't reset the moved display position (authored by amantia). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18101?vs=50659&id=50660 REVISION DETAIL

D8922: Avoid jumping of items toward right/botton when dropping

amantia added a comment. Sorry about it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8922 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9325: Use QUrl in the ScreenMapper API

amantia added inline comments. INLINE COMMENTS > mwolff wrote in foldermodel.cpp:1509 > not your change: why is m_url not an url :-/ > > also: introduce the helper function you have in the tests here, too - maybe > even move it into a static function in the ScreenMapper and then use it > every

D9325: Use QUrl in the ScreenMapper API

amantia updated this revision to Diff 25799. amantia added a comment. Change code according to reviewer's requests REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9325?vs=23954&id=25799 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D9325: Use QUrl in the ScreenMapper API

amantia edited reviewers, added: hein; removed: dakon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9325 To: amantia, #plasma, mwolff, broulik, hein Cc: ervin, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9325: Use QUrl in the ScreenMapper API

amantia updated this revision to Diff 25933. amantia added a comment. Make the code more clear, by renaming a local variable. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9325?vs=25799&id=25933 BRANCH master REVISION DETAIL https://phabricat

D9325: Use QUrl in the ScreenMapper API

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9325 To: amantia, #plasma, mwolff, broulik, hein Cc: ervin, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10407: Disable positioning in popup folderviews

amantia created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY We need to use the overriden sortMode, not the model's sort mode. The == -> === changes are just c

D10407: Disable positioning in popup folderviews

amantia added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10407 To: amantia, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10408: Add option to enable shared folderview content per desktop

amantia added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION DETAIL https://phabricator.kde.org/D10408 To: amantia, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuter

D10407: Disable positioning in popup folderviews

amantia added a comment. Yes, I have commit access since some time. ;) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10407 To: amantia, hein Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10408: Add option to enable shared folderview content per desktop

amantia closed this revision. REVISION DETAIL https://phabricator.kde.org/D10408 To: amantia, #plasma, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10407: Disable positioning in popup folderviews

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10407 To: amantia, hein Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10729: Improve detecting D&D between two screen showing the same URL

amantia added reviewers: Plasma, hein, mwolff. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D10728: Improve multi-desktop folderview behavior

amantia added reviewers: Plasma, hein. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1072

D10729: Improve detecting D&D between two screen showing the same URL

amantia added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10729 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia added a comment. It adds a new entry, doesn't change an existing one. If that is not there, I see no problems, the ScreenMapper::readDisabledScreensMap() will not initialize the m_itemsOnDisabledScreensMap. That map was not saved previously, thus the folderview behaving differently a

D10728: Improve multi-desktop folderview behavior

amantia added a comment. Yes, I will push first to 5.12 both of them REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10729: Improve detecting D&D between two screen showing the same URL

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10729 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

amantia added a comment. I can't put to 5.12 as it seems https://phabricator.kde.org/D9325 didn't get into the 5.12 branch, and I don't want two versions of this patch. May I cherry-pick that commit to 5.12 and apply this patch? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DET

D10728: Improve multi-desktop folderview behavior

amantia updated this revision to Diff 28998. amantia added a comment. Moved to 5.12 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10728?vs=27733&id=28998 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10728 AFFECTED FILES containments/desktop/plugins/folder

D10728: Improve multi-desktop folderview behavior

amantia closed this revision. REVISION DETAIL https://phabricator.kde.org/D10728 To: amantia, #plasma, hein Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8447: Add unit tests for Folder View

amantia created this revision. amantia added reviewers: Plasma, ervin, hein, mlaurent, aacid, dvratil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add some tests for FolderModel and Positioner classes. REPOSITORY R1

  1   2   3   >