D26289: [KCM/Activity] Make default button work, modernize code

meven updated this revision to Diff 72399. meven marked 4 inline comments as done. meven added a comment. 4 newlines were missing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26289?vs=72375&id=72399 BRANCH arcpatch-D26289 REVISION DETAIL http

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

This revision was automatically updated to reflect the committed changes. Closed by commit R119:967b6ac017e8: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit… (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72402. meven added a comment. cherry-pick on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72368&id=72402 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26179 AFFECTED FILES kc

D26179: [KCM/Component] Clean up code of filemanager cfg

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7651c1f42b5e: [KCM/Component] Clean up code of filemanager cfg (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72402&id=72403 R

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

meven updated this revision to Diff 72453. meven added a comment. make a if conv clearer, convert code to use QStringList more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26295?vs=72396&id=72453 BRANCH arcpatch-D26295 REVISION DETAIL https:/

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

meven updated this revision to Diff 72455. meven added a comment. fix indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26295?vs=72454&id=72455 BRANCH arcpatch-D26295 REVISION DETAIL https://phabricator.kde.org/D26295 AFFECTED FILES

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

meven updated this revision to Diff 72454. meven marked an inline comment as done. meven added a comment. fix indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26295?vs=72453&id=72454 BRANCH arcpatch-D26295 REVISION DETAIL https://phab

D26289: [KCM/Activity] Make default button work, modernize code

This revision was automatically updated to reflect the committed changes. Closed by commit R119:83b42833a00e: [KCM/Activity] Make default button work, modernize code (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26289?vs=72399&id=7

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ec0e184791ad: [KCM/Datetime] Convert a foreach, port away from KStandardDirs (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26295?vs=724

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven created this revision. meven added a reviewer: ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The first RadioButtons in the radioLayout is the last in mDynamicRadioButtons TEST PLAN Defaults work

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven updated this revision to Diff 72460. meven added a comment. [KCM/Component] Terminal port to KConfig XT, make isDefault work REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72458&id=72460 BRANCH master REVISION DETAIL https://phab

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven updated this revision to Diff 72461. meven added a comment. Include last commit only REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72460&id=72461 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26322 AFFECTED FILES

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven updated this revision to Diff 72462. meven added a comment. Fix indentation HEAD^ REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72461&id=72462 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26322 AFFECTED FILES kc

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven updated this revision to Diff 72463. meven added a comment. Fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72462&id=72463 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26322 AFFECTED FILES kcms/componentc

D26323: [KCM/Component] Terminal port to KConfigXT, make isDefault work

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26323 AFFECTED FIL

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3bd210f13cca: [KCM/Component] Fix CfgFileManager::isDefaults (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72463&id=72466 REV

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

meven added a comment. In D26234#584972 , @ngraham wrote: > In D26234#584969 , @ndavis wrote: > > > In D26234#584620 , @meven wrote: > > > > > I feel th

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED FIL

D26323: [KCM/Component] Terminal port to KConfigXT, make isDefault work

meven updated this revision to Diff 72468. meven added a comment. Make default button work, fix a carriage return missing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26323?vs=72465&id=72468 BRANCH master REVISION DETAIL https://phabricator.k

D26323: [KCM/Component] Terminal port to KConfigXT, make isDefault work

meven marked an inline comment as done. meven added a comment. In D26323#585271 , @ervin wrote: > One nitpick to address before pushing. > > Also I mark those accepted assuming there will be another phase where the settings objects will actua

D26329: [KCM/Component] Email: make isDefault work

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26329 AFFECTED FIL

D26323: [KCM/Component] Terminal port to KConfigXT, make isDefault work

This revision was automatically updated to reflect the committed changes. Closed by commit R119:19844315c557: [KCM/Component] Terminal port to KConfigXT, make isDefault work (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26323?vs=72

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72485. meven added a comment. Use std::any_of REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72467&id=72485 BRANCH arcpatch-D26324 REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED FILES

D26329: [KCM/Component] Email: make isDefault work

This revision was automatically updated to reflect the committed changes. Closed by commit R119:10108d4b48ad: [KCM/Component] Email: make isDefault work (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26329?vs=72480&id=72486 REVISIO

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72488. meven added a comment. Use std::find_if REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72485&id=72488 BRANCH arcpatch-D26324 REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED FILES

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72489. meven added a comment. rebase on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72488&id=72489 BRANCH arcpatch-D26324 REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED FILES

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72491. meven marked 2 inline comments as done. meven added a comment. Better implement helper function, replace unnused include by a more relevant one REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72489&

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72493. meven marked an inline comment as done. meven added a comment. Correct namespace declaration, better variable naming, take list of QRadioButton by const ref REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72494. meven added a comment. clean REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72493&id=72494 BRANCH arcpatch-D26324 REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED FILES kcms/comp

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72495. meven added a comment. clean REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72494&id=72495 BRANCH arcpatch-D26324 REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED FILES kcms/comp

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72497. meven added a comment. fix curly brace position REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72495&id=72497 BRANCH arcpatch-D26324 REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTE

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven marked 3 inline comments as done. meven added a comment. In D26111#580344 , @meven wrote: > Two points raised by @broulik but not resolved : > > - should display a specific icon based on file mimetype ? > - should we allow to open a fo

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd4fd031eb6b: [KCM/Component] filemanager: make dolphin the default filemananger (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs

D26363: [KCM/Activities] Clean unused code

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26363 AFFECTED FIL

D26363: [KCM/Activities] Clean unused code

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bd05813d8784: [KCM/Activities] Clean unused code (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26363?vs=72609&id=72621 REVISION DETAIL

D26147: Kickoff computer tab : don't display filepath for places in description

meven added a comment. ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26147 To: meven, ngraham, #plasma, #vdg, hein Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himces

D26121: Kicker/RecentDocument display file path as decoration

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9099652598fa: Kicker/RecentDocument display file path as decoration (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26121?vs=71950&id=7

D26147: Kickoff computer tab : don't display filepath for places in description

This revision was automatically updated to reflect the committed changes. Closed by commit R120:861e465951a0: Kickoff computer tab : don't display filepath for places in description (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D26385: Kicker/RecentDocuments Avoid referring to hidden places

meven created this revision. meven added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26385 AFFECTED

D26386: Kicker/RecentDocuments: add icons to actions

meven created this revision. meven added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26386 AFFECTED

D26388: Get rid of KGlobalSettings

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Looks fine to me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26388 To: ervin, #plasma, mart, davidedmundson, bport, crossi, meven Cc: plasma-devel, LeGast

D26398: [KCM/Activities] Use KConfigXT in ui

meven created this revision. meven added reviewers: Plasma, ervin, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Port the ui components to use KConfig XT features to reduce amount of boilerplate code. T

D26386: Kicker/RecentDocuments: add icons to actions

meven added a comment. In D26386#587025 , @ngraham wrote: > Is there no way to set the icon during initialization so these can stay const? I would have needed to edit `Kicker::createActionItem`, it might be interesting. But not keeping

D26385: Kicker/RecentDocuments Avoid referring to hidden places

This revision was automatically updated to reflect the committed changes. Closed by commit R120:aa259e389848: Kicker/RecentDocuments Avoid referring to hidden places (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26385?vs=72671&id

D26386: Kicker/RecentDocuments: add icons to actions

meven updated this revision to Diff 72697. meven added a comment. Add an icon parameter to Kicker::createActionItem REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=72673&id=72697 BRANCH arcpatch-D26386 REVISION DETAIL https://phabrica

D26386: Kicker/RecentDocuments: add icons to actions

meven added a comment. I am not too fond of this version growing the number of parameters of Kicker::createActionItem, and given its third parameter before icon is QVariant this becomes error-prone. There are a lot more usage of this method that I haven't yet updated, if we want to follow

D26385: Kicker/RecentDocuments Avoid referring to hidden places

meven added a comment. In D26385#587173 , @hein wrote: > I don't agree with this patch. Hiding a place or section from the Places panel doesn't mean the user didn't add it and it's not to be used. We don't hide it from Folder View's config or re

D26386: Kicker/RecentDocuments: add icons to actions

meven added a comment. In D26386#587169 , @hein wrote: > It should be `iconName` after `label`. I like this suggestion. It entails a lot of error-prone code change. Will do. REPOSITORY R120 Plasma Workspace REVISION DETAIL https:

D26416: Kicker/Documents optimization: Lazily build KFileItem

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Save quite a few KFileItem instanciation. On each document hovering several KFileItem were instanc

D26386: Kicker/RecentDocuments: add icons to actions

meven updated this revision to Diff 72752. meven added a comment. Change signature of Kicker::createActionItem and update all its users REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=72697&id=72752 BRANCH arcpatch-D26386_1 REVISION DET

D26386: Kicker/RecentDocuments: add icons to actions

meven updated this revision to Diff 72754. meven added a comment. Clean unwanted change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=72752&id=72754 BRANCH arcpatch-D26386_1 REVISION DETAIL https://phabricator.kde.org/D26386 AFFECT

D26386: Kicker/RecentDocuments: add icons to actions

meven updated this revision to Diff 72755. meven added a comment. Use view-hidden icon for Hide Application action for consistency REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=72754&id=72755 BRANCH arcpatch-D26386_1 REVISION DETAIL

D26416: Kicker/Documents optimization: Lazily build KFileItem

meven updated this revision to Diff 72761. meven added a comment. Remove outdate ifdef, we depend on KF5 5.62 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26416?vs=72735&id=72761 BRANCH arcpatch-D26416 REVISION DETAIL https://phabricator.kd

D26386: Kicker/RecentDocuments: add icons to actions

meven added inline comments. INLINE COMMENTS > contactentry.cpp:117 > > -actionList << Kicker::createActionItem(i18n("Show Contact > Information..."), QStringLiteral("showContactInfo")); > +actionList << Kicker::createActionItem(i18n("Show Contact > Information..."), QString(), QStrin

D26386: Kicker/RecentDocuments: add icons to actions

meven updated this revision to Diff 72804. meven marked 2 inline comments as done. meven added a comment. Add icon identity for showContactInfo action REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=72755&id=72804 BRANCH arcpatch-D26386_

D26438: Runners: Convert foreach to for

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26438 AFFECTED FILES

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 72849. meven added a comment. KCM/Component clean unused file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72695&id=72849 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26398 AFFECTED

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 72850. meven added a comment. Remove unwanted change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72849&id=72850 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26398 AFFECTED FILES k

D26451: KCM/Component clean unused file

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Apparently a leftover file. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D26438: Runners: Convert foreach to for

meven updated this revision to Diff 72864. meven marked an inline comment as done. meven added a comment. Ensure windowList is const, use stdMap to loop over QMap key+value REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26438?vs=72810&id=72864 BRA

D26438: Runners: Convert foreach to for

meven updated this revision to Diff 72866. meven marked an inline comment as done. meven added a comment. Add a ref REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26438?vs=72864&id=72866 BRANCH master REVISION DETAIL https://phabricator.kde.o

D26438: Runners: Convert foreach to for

meven updated this revision to Diff 72867. meven marked an inline comment as done. meven added a comment. Use a loop over bindObjects.constKeyValueBegin/bindObjects.constKeyValueEnd REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26438?vs=72866&id=7

D26416: Kicker/Documents optimization: Lazily build KFileItem

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1640e9f46ef6: Kicker/Documents optimization: Lazily build KFileItem (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26416?vs=72761&id=7

D26451: KCM/Component clean unused file

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7313066401d5: KCM/Component clean unused file (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26451?vs=72851&id=72875 REVISION DETAIL

D26438: Runners: Convert foreach to for

meven added a comment. In D26438#588598 , @ivan wrote: > @davidedmundson > > Yes, the wrapper just serves for keyval iterators to be usable with a range-based for loop. Quite useful if there are a lot of these. In this case, where it is only

D26438: Runners: Convert foreach to for

meven added a comment. In D26438#588686 , @ivan wrote: > @meven > > I hate Qt... defining `operator*` without `operator->` ... ugh > > I've approved the patch, sorry for the bad nitpick :) No worries, thanks for the review REPOSIT

D26438: Runners: Convert foreach to for

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6b6ae6162457: Runners: Convert foreach to for (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26438?vs=72867&id=72879 REVISION DETAIL

D26467: KCM runners: fix default button

meven added a comment. Depends on D26466 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26467 To: bport, #plasma, ervin, meven, crossi Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, r

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven added a comment. Anyone to review this ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, n

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY CCBUG: 379516 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven added a comment. It would probably be better to exclude squashfs drives from the drives indexed by baloo. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26478 To: meven, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampalou

D26386: Kicker/RecentDocuments: add icons to actions

meven added a comment. @hein is it fine for you ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26386 To: meven, #plasma, ngraham, hein Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, a

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 72964. meven added a comment. Handle BlacklistedApplicationsModel properly, prevent a warning 'duplicate connection name' REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72850&id=72964 BRANCH arcpatch-D

D26494: Runner/Windows make the window finding more reliable

meven created this revision. meven added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Call gatherInfo immediately after prepareForMatchSession QTimer::singleShot could dispatched g

D26386: Kicker/RecentDocuments: add icons to actions

meven planned changes to this revision. meven added inline comments. INLINE COMMENTS > actionlist.cpp:62 > > +if (!icon.isEmpty()) { > +map[QStringLiteral("icon")] = icon; Remove this if > recentcontactsmodel.cpp:93 > > -actionList << Kicker::createActionItem(i18n("Show

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven updated this revision to Diff 73031. meven added a comment. KCM/Component remove traces of Kdelibs4 migration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26478?vs=72930&id=73031 BRANCH master REVISION DETAIL https://phabricator.kde.org

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven updated this revision to Diff 73032. meven added a comment. Clean unrelated files REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26478?vs=73031&id=73032 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26478 AFFECTED FILES kc

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven updated this revision to Diff 73033. meven added a comment. Clean commit history REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26478?vs=73032&id=73033 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26478 AFFECTED FILES kcm

D26515: KCM/Component remove traces of Kdelibs4 migration

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Compiles REPOSITORY R119 Plasma Desktop BRANCH clean-component REVISION DETAIL https://phabricat

D26386: Kicker/RecentDocuments: add icons to actions

meven updated this revision to Diff 73035. meven added a comment. This revision is now accepted and ready to land. Make icon non-optionnal in Kicker::createActionItem, add a missing icon REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=72804

D26386: Kicker/RecentDocuments: add icons to actions

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4dca72bdf59a: Kicker/RecentDocuments: add icons to actions (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=73035&id=73036 REV

D26515: KCM/Component remove traces of Kdelibs4 migration

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bde038c07839: KCM/Component remove traces of Kdelibs4 migration (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26515?vs=73034&id=73039

D26518: ModuleView: Hide button when KCModule don't need them

meven added inline comments. INLINE COMMENTS > ModuleView.cpp:398 > +d->mReset->setVisible(buttons & KCModule::Apply); > d->mHelp->setEnabled(buttons & KCModule::Help ); > emit moduleChanged( change ); `d->mHelp->setVisible(buttons & KCModule::Help )` ? REPOSITORY R124 System Se

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven planned changes to this revision. meven added a comment. In D26111#589209 , @ivan wrote: > > Why not change the recentdocuments runner? > > Will do REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.or

D26398: [KCM/Activities] Use KConfigXT in ui

meven added inline comments. INLINE COMMENTS > ervin wrote in BlacklistedApplicationsModel.cpp:179 > I personally like that construct, but AFAIK it's rather unusual in KDE code, > so maybe for the sake of the future developer use something more "classic". > Either: > > const auto name = d->ap

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73054. meven marked 2 inline comments as done. meven added a comment. Review, code style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72964&id=73054 BRANCH arcpatch-D26398 REVISION DETAIL https://p

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73055. meven marked 2 inline comments as done. meven added a comment. In BlackListModel only acces concerned items isSaveNeeded and isDefault REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73054&id=73055

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73056. meven marked 2 inline comments as done. meven added a comment. Improve signals naming, and remove redundant ones REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73055&id=73056 BRANCH arcpatch-D263

D26494: Runner/Windows make the window finding more reliable

meven added a comment. Instead we might want to keep a cache of windows and desktopNames and use KWindowSystem::desktopNamesChanged and windowAdded / windowRemoved signals. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26494 To: meven, #plasma, ngraham, b

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73062. meven marked an inline comment as done. meven added a comment. Add Q_ASSERTs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73056&id=73062 BRANCH arcpatch-D26398 REVISION DETAIL https://phabri

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73063. meven added a comment. Only once commit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73062&id=73063 BRANCH arcpatch-D26398 REVISION DETAIL https://phabricator.kde.org/D26398 AFFECTED FILES

D26489: Use qmlRegisterAnonymousType

meven added inline comments. INLINE COMMENTS > draghelper.cpp:32 > { > -qmlRegisterType("org.kde.milou", 1, 0, "MimeData"); > + qmlRegisterAnonymousType("org.kde.milou", 1); > } indentation REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D26489 To: tcanabrava,

D26521: KCM/Component Make the email config default button work

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D26398 REVISION DETAIL https://phabricator.kde.org/D26521 AFF

D26111: Runner: make recentdocument use KActivityStats data

meven updated this revision to Diff 73086. meven added a comment. Instead of adding a runner update the documentrecent one REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=71865&id=73086 BRANCH arcpatch-D26111 REVISION DETAIL https://p

D26111: Runner: make recentdocument use KActivityStats data

meven updated this revision to Diff 73087. meven added a comment. Clean bad referrence REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=73086&id=73087 BRANCH arcpatch-D26111 REVISION DETAIL https://phabricator.kde.org/D26111 AFFECTED

D26533: Add a logging category for the backend

meven created this revision. meven added reviewers: apol, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY To get rid of tons of logs like : using... PackageKit::Transaction(0x55db7f249ab0) "/14940_dbaec

D26533: Add a logging category for the backend

meven updated this revision to Diff 73119. meven added a comment. Fix CMake( add _SRCS vars) REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26533?vs=73096&id=73119 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26533 AFFEC

D26533: Add a logging category for the backend

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:14 > Why adding it ? it's autogenerated so it's added by cmake directly The issue was that add_library takes directly a list of cpp directly, but ecm_qt_declare_logging_catego

D26533: Add a logging category for the backend

meven marked an inline comment as done. meven added a comment. ping @mlaurent REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26533 To: meven, apol, ngraham, mlaurent Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampalo

D26533: Add a logging category for the backend

This revision was automatically updated to reflect the committed changes. Closed by commit R134:160f10328366: Add a logging category for the backend (authored by meven). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26533?vs=73119&id=73121 RE

<    1   2   3   4   5   6   7   8   >