D26289: [KCM/Activity] Make default button work, modernize code

This revision was automatically updated to reflect the committed changes. Closed by commit R119:83b42833a00e: [KCM/Activity] Make default button work, modernize code (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ec0e184791ad: [KCM/Datetime] Convert a foreach, port away from KStandardDirs (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3bd210f13cca: [KCM/Component] Fix CfgFileManager::isDefaults (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72463=72466

D26323: [KCM/Component] Terminal port to KConfigXT, make isDefault work

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26323 AFFECTED

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven updated this revision to Diff 72461. meven added a comment. Include last commit only REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72460=72461 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26322 AFFECTED FILES

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven updated this revision to Diff 72460. meven added a comment. [KCM/Component] Terminal port to KConfig XT, make isDefault work REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72458=72460 BRANCH master REVISION DETAIL

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

meven added a comment. In D26234#584972 , @ngraham wrote: > In D26234#584969 , @ndavis wrote: > > > In D26234#584620 , @meven wrote: > > > > > I feel

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven updated this revision to Diff 72463. meven added a comment. Fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72462=72463 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26322 AFFECTED FILES

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

meven updated this revision to Diff 72455. meven added a comment. fix indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26295?vs=72454=72455 BRANCH arcpatch-D26295 REVISION DETAIL https://phabricator.kde.org/D26295 AFFECTED FILES

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

meven updated this revision to Diff 72454. meven marked an inline comment as done. meven added a comment. fix indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26295?vs=72453=72454 BRANCH arcpatch-D26295 REVISION DETAIL

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven created this revision. meven added a reviewer: ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The first RadioButtons in the radioLayout is the last in mDynamicRadioButtons TEST PLAN Defaults work

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven marked 3 inline comments as done. meven added a comment. In D26111#580344 , @meven wrote: > Two points raised by @broulik but not resolved : > > - should display a specific icon based on file mimetype ? > - should we allow to open a

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd4fd031eb6b: [KCM/Component] filemanager: make dolphin the default filemananger (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26121: Kicker/RecentDocument display file path as decoration

meven added a comment. This was done to match my proposed recentlyused krunner : D26111 And the computer should be good now : D26147 REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26121 REVISION DETAIL

D26147: Kickoff computer tab : don't display filepath for places in description

meven updated this revision to Diff 72041. meven added a comment. Use default fallthrough REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26147?vs=71962=72041 BRANCH arcpatch-D26147 REVISION DETAIL https://phabricator.kde.org/D26147 AFFECTED

D26121: Kicker/RecentDocument display file path as decoration

meven added a comment. In D26121#583212 , @ervin wrote: > LGTM, might need an update if D26122 lands though. No need to update here after D26122 , the code uses

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

meven planned changes to this revision. meven added a comment. Changes about componentchooserbrowser slipped here. I can't wait to forget about arc... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26100 To: meven, crossi, #plasma, ngraham, ervin Cc:

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72365. meven marked 2 inline comments as done. meven added a comment. Formatting & indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72102=72365 BRANCH arcpatch-D26179_2 REVISION DETAIL

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72366. meven added a comment. Formatting & indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72365=72366 BRANCH arcpatch-D26179_2 REVISION DETAIL https://phabricator.kde.org/D26179

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72368. meven added a comment. Remove unrelated changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72367=72368 BRANCH arcpatch-D26179_2 REVISION DETAIL https://phabricator.kde.org/D26179

D26068: [KCM/Activity] Use KConfigXT to store settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:df0a276b7eea: [KCM/Activity] Use KConfigXT to store settings (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26068?vs=72093=72369

D26068: [KCM/Activity] Use KConfigXT to store settings

meven added inline comments. INLINE COMMENTS > meven wrote in PrivacyTab.cpp:67 > That was not needed, will clean up D26287 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26068 To: meven, #plasma, ervin, crossi Cc:

D26287: [KCM/Activity] Clean unncessary destructor

meven created this revision. meven added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26287 AFFECTED

D26068: [KCM/Activity] Use KConfigXT to store settings

meven added inline comments. INLINE COMMENTS > davidedmundson wrote in PrivacyTab.cpp:67 > Why do we explicitly call deleteLater on these? That was not needed, will clean up REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26068 To: meven, #plasma, ervin,

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

meven updated this revision to Diff 72362. meven marked 3 inline comments as done. meven added a comment. Fix indentation issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26100?vs=72100=72362 BRANCH arcpatch-D26100_2 REVISION DETAIL

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72367. meven added a comment. Formatting & indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72366=72367 BRANCH arcpatch-D26179_2 REVISION DETAIL https://phabricator.kde.org/D26179

D26289: [KCM/Activity] Make default button work, modernize code

meven created this revision. meven added reviewers: Plasma, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN kcmshell5 activties Default button states follows those of the privacy and switching tabs REPOSITORY

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

meven added a comment. I feel the "raise maximum volume" button does not need to be always visible as most users won't ever use it, instead the mute toggle could use the space. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D26234 To: gvgeo,

D26287: [KCM/Activity] Clean unncessary destructor

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b616999bea2b: [KCM/Activity] Clean unncessary destructor (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26287?vs=72372=72382 REVISION

D26289: [KCM/Activity] Make default button work, modernize code

meven updated this revision to Diff 72399. meven marked 4 inline comments as done. meven added a comment. 4 newlines were missing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26289?vs=72375=72399 BRANCH arcpatch-D26289 REVISION DETAIL

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

This revision was automatically updated to reflect the committed changes. Closed by commit R119:967b6ac017e8: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit… (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26179: [KCM/Component] Clean up code of filemanager cfg

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7651c1f42b5e: [KCM/Component] Clean up code of filemanager cfg (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72402=72403

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72402. meven added a comment. cherry-pick on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72368=72402 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26179 AFFECTED FILES

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26295 AFFECTED

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

meven updated this revision to Diff 72396. meven added a comment. Add a KStandardDirs conversion REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26295?vs=72394=72396 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26295 AFFECTED

D26386: Kicker/RecentDocuments: add icons to actions

meven added inline comments. INLINE COMMENTS > contactentry.cpp:117 > > -actionList << Kicker::createActionItem(i18n("Show Contact > Information..."), QStringLiteral("showContactInfo")); > +actionList << Kicker::createActionItem(i18n("Show Contact > Information..."), QString(),

D26438: Runners: Convert foreach to for

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26438 AFFECTED FILES

D26386: Kicker/RecentDocuments: add icons to actions

meven updated this revision to Diff 72804. meven marked 2 inline comments as done. meven added a comment. Add icon identity for showContactInfo action REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=72755=72804 BRANCH arcpatch-D26386_1

D26467: KCM runners: fix default button

meven added a comment. Depends on D26466 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26467 To: bport, #plasma, ervin, meven, crossi Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26438: Runners: Convert foreach to for

meven updated this revision to Diff 72864. meven marked an inline comment as done. meven added a comment. Ensure windowList is const, use stdMap to loop over QMap key+value REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26438?vs=72810=72864

D26451: KCM/Component clean unused file

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7313066401d5: KCM/Component clean unused file (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26451?vs=72851=72875 REVISION DETAIL

D26438: Runners: Convert foreach to for

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6b6ae6162457: Runners: Convert foreach to for (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26438?vs=72867=72879 REVISION DETAIL

D26438: Runners: Convert foreach to for

meven updated this revision to Diff 72867. meven marked an inline comment as done. meven added a comment. Use a loop over bindObjects.constKeyValueBegin/bindObjects.constKeyValueEnd REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26438: Runners: Convert foreach to for

meven updated this revision to Diff 72866. meven marked an inline comment as done. meven added a comment. Add a ref REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26438?vs=72864=72866 BRANCH master REVISION DETAIL

D26416: Kicker/Documents optimization: Lazily build KFileItem

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1640e9f46ef6: Kicker/Documents optimization: Lazily build KFileItem (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26438: Runners: Convert foreach to for

meven added a comment. In D26438#588598 , @ivan wrote: > @davidedmundson > > Yes, the wrapper just serves for keyval iterators to be usable with a range-based for loop. Quite useful if there are a lot of these. In this case, where it is

D26438: Runners: Convert foreach to for

meven added a comment. In D26438#588686 , @ivan wrote: > @meven > > I hate Qt... defining `operator*` without `operator->` ... ugh > > I've approved the patch, sorry for the bad nitpick :) No worries, thanks for the review

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 72849. meven added a comment. KCM/Component clean unused file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72695=72849 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26398 AFFECTED

D26451: KCM/Component clean unused file

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Apparently a leftover file. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 72850. meven added a comment. Remove unwanted change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72849=72850 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26398 AFFECTED FILES

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven added a comment. It would probably be better to exclude squashfs drives from the drives indexed by baloo. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26478 To: meven, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY CCBUG: 379516 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven added a comment. Anyone to review this ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26386: Kicker/RecentDocuments: add icons to actions

meven added a comment. @hein is it fine for you ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26386 To: meven, #plasma, ngraham, hein Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 72964. meven added a comment. Handle BlacklistedApplicationsModel properly, prevent a warning 'duplicate connection name' REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72850=72964 BRANCH

D26494: Runner/Windows make the window finding more reliable

meven created this revision. meven added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Call gatherInfo immediately after prepareForMatchSession QTimer::singleShot could dispatched

D26386: Kicker/RecentDocuments: add icons to actions

meven planned changes to this revision. meven added inline comments. INLINE COMMENTS > actionlist.cpp:62 > > +if (!icon.isEmpty()) { > +map[QStringLiteral("icon")] = icon; Remove this if > recentcontactsmodel.cpp:93 > > -actionList << Kicker::createActionItem(i18n("Show

D26147: Kickoff computer tab : don't display filepath for places in description

meven added a comment. ping @hein REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26147 To: meven, ngraham, #plasma, #vdg, hein Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D26515: KCM/Component remove traces of Kdelibs4 migration

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bde038c07839: KCM/Component remove traces of Kdelibs4 migration (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26515?vs=73034=73039

D26515: KCM/Component remove traces of Kdelibs4 migration

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Compiles REPOSITORY R119 Plasma Desktop BRANCH clean-component REVISION DETAIL

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven updated this revision to Diff 73032. meven added a comment. Clean unrelated files REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26478?vs=73031=73032 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26478 AFFECTED FILES

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven updated this revision to Diff 73033. meven added a comment. Clean commit history REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26478?vs=73032=73033 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26478 AFFECTED FILES

D26386: Kicker/RecentDocuments: add icons to actions

meven updated this revision to Diff 73035. meven added a comment. This revision is now accepted and ready to land. Make icon non-optionnal in Kicker::createActionItem, add a missing icon REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26386: Kicker/RecentDocuments: add icons to actions

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4dca72bdf59a: Kicker/RecentDocuments: add icons to actions (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26386?vs=73035=73036

D26518: ModuleView: Hide button when KCModule don't need them

meven added inline comments. INLINE COMMENTS > ModuleView.cpp:398 > +d->mReset->setVisible(buttons & KCModule::Apply); > d->mHelp->setEnabled(buttons & KCModule::Help ); > emit moduleChanged( change ); `d->mHelp->setVisible(buttons & KCModule::Help )` ? REPOSITORY R124 System

D26478: KCM/baloo Display full mount point in list of excluded mount points

meven updated this revision to Diff 73031. meven added a comment. KCM/Component remove traces of Kdelibs4 migration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26478?vs=72930=73031 BRANCH master REVISION DETAIL

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73055. meven marked 2 inline comments as done. meven added a comment. In BlackListModel only acces concerned items isSaveNeeded and isDefault REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73054=73055

D26398: [KCM/Activities] Use KConfigXT in ui

meven added inline comments. INLINE COMMENTS > ervin wrote in BlacklistedApplicationsModel.cpp:179 > I personally like that construct, but AFAIK it's rather unusual in KDE code, > so maybe for the sake of the future developer use something more "classic". > Either: > > const auto name =

D26494: Runner/Windows make the window finding more reliable

meven added a comment. Instead we might want to keep a cache of windows and desktopNames and use KWindowSystem::desktopNamesChanged and windowAdded / windowRemoved signals. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26494 To: meven, #plasma, ngraham,

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73056. meven marked 2 inline comments as done. meven added a comment. Improve signals naming, and remove redundant ones REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73055=73056 BRANCH arcpatch-D26398

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73054. meven marked 2 inline comments as done. meven added a comment. Review, code style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72964=73054 BRANCH arcpatch-D26398 REVISION DETAIL

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven planned changes to this revision. meven added a comment. In D26111#589209 , @ivan wrote: > > Why not change the recentdocuments runner? > > Will do REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

meven added a comment. Porting with such feature regression is hard to justify. Perhaps we should port KFontDialog (it is ~150 lines of cpp) to kwidgetsaddons instead, `KFontChooser` is already there. Or better perhaps implement here a simple QDialog embedding `KFontChooser` and

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

meven added inline comments. INLINE COMMENTS > fonts.cpp:678 > > -QFont KFonts::applyFontDiff(const QFont , const QFont , int > fontDiffFlags) > -{ > -QFont font(fnt); > - > -if (fontDiffFlags & KFontChooser::FontDiffSize) { > -font.setPointSizeF(newFont.pointSizeF()); > -

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

meven added a comment. In D27808#625181 , @ahmadsamir wrote: > And another question, "General", "Menu", "Toolbar", how many users actually set these three to individual font families/styles/sizes? If anything this is just not relevant

D27998: Add workspace kcm option for dndToMove

meven added inline comments. INLINE COMMENTS > main.qml:150 > +text: i18n("Always ask what to do") > +enabled: !kcm.globalsSettings.isImmutable("dndToMove") > +checked: !kcm.globalsSettings.dndToMove You can nowadays write

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

meven added a comment. In D27808#625229 , @ahmadsamir wrote: > In D27808#625227 , @cfeck wrote: > > > We already lost fractional point sizes when porting from KFontDialog to QFontDialog. > >

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 77261. meven added a comment. Reversed resizing the window REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=76470=77261 BRANCH arcpatch-D26934 REVISION DETAIL https://phabricator.kde.org/D26934

D26934: KCM/Autostart Add a model to separate logic from UI

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > meven wrote in autostart.cpp:87 > The current default size was not very appropriate. > I took the liberty of changing this as well. > Before: > F8133214: Screenshot_20200226_140516.png >

D27998: [KCMs/Workspace] Add option for dndToMove

meven added inline comments. INLINE COMMENTS > main.qml:189 > +text: i18n("Always ask what to do") > +enabled: !kcm.globalsSettings.isImmutable("dndToMove") > +checked: !kcm.globalsSettings.dndToMove My comment "you can nowadays write

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

meven updated this revision to Diff 77365. meven added a comment. Add the recently disconnected device at the end of the list of devices REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27024?vs=77361=77365 BRANCH arcpatch-D27024 REVISION DETAIL

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

meven updated this revision to Diff 77361. meven added a comment. Rebase on master, and follow removal of singleton REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27024?vs=75847=77361 BRANCH arcpatch-D27024 REVISION DETAIL

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

meven updated this revision to Diff 77366. meven added a comment. Solid-device-automounter/kcm: correctly update automountOn REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27024?vs=77365=77366 BRANCH stash{0} REVISION DETAIL

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

meven updated this revision to Diff 77367. meven added a comment. Remove bad commit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27024?vs=77366=77367 BRANCH arcpatch-D27024 REVISION DETAIL https://phabricator.kde.org/D27024 AFFECTED FILES

D27971: Solid-device-automounter/kcm: correctly update automountOn

meven created this revision. meven added reviewers: bport, Plasma, ervin, crossi, hchain. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Open kcmshell5 device_automounter_kcm Play with the checkbox "Automatically

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8aa96ac72dbd: Solid-device-automounter/kcm: show disconnected known device when disconnecting… (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26111: Runner: make recentdocument use KActivityStats data

meven added a comment. I will this for a few days and merge if no more feedback is sent. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28829: Touchpad kcm: On X11 hide scroll speed as it is not supported

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fe4d395d792d: Touchpad kcm: On X11 hide scroll speed as it is not supported (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0cf73170479b: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Powerdevil] [Bug 383307] Brightness level is not remembered/restoring after sleep and levels up to maximum level

https://bugs.kde.org/show_bug.cgi?id=383307 Méven Car changed: What|Removed |Added CC||meven@enioka.com Status|REPORTED

D26111: Runner: make recentdocument use KActivityStats data

meven updated this revision to Diff 80516. meven added a comment. Rebasing after D28369 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=73087=80516 BRANCH arcpatch-D26111_1 REVISION DETAIL

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

meven updated this revision to Diff 80616. meven added a comment. Fix for loop REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28282?vs=80614=80616 BRANCH arcpatch-D28282 REVISION DETAIL https://phabricator.kde.org/D28282 AFFECTED FILES

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

meven updated this revision to Diff 80614. meven added a comment. Rebasing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28282?vs=78913=80614 BRANCH arcpatch-D28282 REVISION DETAIL https://phabricator.kde.org/D28282 AFFECTED FILES

D28154: Add users KCM

meven added a comment. Is the screenshot current ? ping @ngraham REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag,

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 80196. meven marked 11 inline comments as done. meven added a comment. Address review, fix an issue when adding a desktop item REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=79639=80196 BRANCH D26934-2

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 80200. meven added a comment. Use Qt::DisplayRole directly instead of using Roles::DisplayRole REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=80196=80200 BRANCH D26934-2 REVISION DETAIL

D26934: KCM/Autostart Add a model to separate logic from UI

meven added inline comments. INLINE COMMENTS > ervin wrote in autostartmodel.h:52 > Weeell... knowing about Qt::DisplayRole is kind of prerequisite to making > your own model. :-) As you want. IMO this is not a good pattern to expect reviewers to have any previous knowledge about enum values,

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 79639. meven marked 20 inline comments as done. meven added a comment. Make most dialogs use open/finished, make all dialogs modal... REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=78855=79639 BRANCH

D25449: Start of the new Formats KCM

meven added a comment. ping @tcanabrava REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25449 To: tcanabrava, ervin, #vdg, #plasma, mart, ngraham Cc: meven, ahiemstra, anthonyfieroni, mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, Orage,

D28544: RecentDocuments Runner: Cleanup and formatting

meven added a comment. Regarding the recentdocument krunner, I have a patch to make it rely on kactivity data : D26111 . It has been waiting for review of a while. This patch will introduce a lot of conflict, but I am ok either way, if this one get

<    2   3   4   5   6   7   8   >