Re: Plasma Wallpapers in QML

2012-09-14 Thread Sebastian Kügler
On Thursday, September 13, 2012 18:25:58 Aleix Pol wrote: > Hi, > So I was tired of KPeople for today and I've decided to play a bit > with wallpapers. > > What I did was to create a very very simple plugin (~40 sloc) that > lets you easily specify a wallpaper given a QML url. Now it's > hardcoded

Re: Status of QML Porting

2012-09-15 Thread Sebastian Kügler
On Saturday, September 15, 2012 12:16:26 Marco Martin wrote: > > battery This one's done and merged, released with 4.9, thanks to Viranch. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-de

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-15 Thread Sebastian Kügler
> On Sept. 14, 2012, 3 p.m., Sebastian Kügler wrote: > > The user can change the size of the calendar in two ways: > > > > - when the applet is in a panel / popup by dragging the edges > > - when it's on the desktop, using the applet handle > > &g

Randa Frameworks5 preps

2012-09-17 Thread Sebastian Kügler
Hey, [This email is mostly interesting to those of us meeting in Randa later this week] Before we meet in Randa, it makes sense to have a look at your dev setup, so that we can get started quickly. We shortly talked about this on IRC today. If you'd like to spare yourself some setup time in Ra

Re: Review Request: The preview action shouldn't be visible all the time

2012-09-17 Thread Sebastian Kügler
477/#comment15155> Do we setVisible(true) it when we change package? I don't see this in the code, but haven't tried. Something to check... - Sebastian Kügler On Sept. 17, 2012, 11:14 a.m., Giorgos Tsiapaliwkas wrote: > >

Re: Review Request: hide the konsole on the close project

2012-09-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106478/#review19079 --- Ship it! Ship It! - Sebastian Kügler On Sept. 17, 2012, 11

Re: Review Request: Device notifier: fix free space information

2012-09-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106490/#review19105 --- Ship it! Ship It! - Sebastian Kügler On Sept. 18, 2012, 12

Re: Review Request: Make it possible to configure a wallpaper from the viewer

2012-09-18 Thread Sebastian Kügler
rviewer/main.cpp <http://git.reviewboard.kde.org/r/106495/#comment15188> Coding style: { and } even for oneliners plasma/generic/tools/wallpaperviewer/main.cpp <http://git.reviewboard.kde.org/r/106495/#comment15189> whitespace - Sebastian Kügler On Sept. 18, 2012, 3:22 p.

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Sebastian Kügler
it to KDE/4.9 and master. - Sebastian Kügler On Sept. 18, 2012, 5:40 p.m., Ralf Jung wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Sebastian Kügler
> On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote: > > Patch looks good now, thanks a lot! > > > > Please commit it to KDE/4.9 and master. Ah, crap. I missed your question about the possible BIC issue. Can someone answer this question? """ Is

Re: Review Request: The preview action shouldn't be visible all the time

2012-09-19 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106477/#review19157 --- Ship it! Ship It! - Sebastian Kügler On Sept. 19, 2012, 11

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-19 Thread Sebastian Kügler
> On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote: > > Patch looks good now, thanks a lot! > > > > Please commit it to KDE/4.9 and master. > > Sebastian Kügler wrote: > Ah, crap. I missed your question about the possible BIC issue. Can

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-20 Thread Sebastian Kügler
On Thursday, September 20, 2012 11:40:41 Ralf Jung wrote: > Hi, > > >> Ralf Jung wrote: Actually, the patch presented here does not break > >> BC. This function I renamed is part of CalendarPrivate and > >> therefore can not be used from the outside. The BC breakage would > >> (possibly) be introd

Re: Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Sebastian Kügler
x27;t see any other way to fix this, and your patch looks clean. Please submit to KDE/4.9 and master. - Sebastian Kügler On Sept. 21, 2012, 3:57 p.m., Ralf Jung wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Fit Grid elements in Item

2012-09-24 Thread Sebastian Kügler
On Monday, September 24, 2012 11:45:22 David Edmundson wrote: > Although you've told the grid to anchor on the right hand side, you've > also (implicitly) told it it needs to be 4 buttons wide, and each > button is hardcoded to be at least 12 characters wide. > (plasmacomponents/qml/Button.qml:95).

Re: Fit Grid elements in Item

2012-09-24 Thread Sebastian Kügler
On Monday, September 24, 2012 14:14:39 David Edmundson wrote: > To clarify, by change I meant to consider adding a > minimumWidth/minimumHeight property, not removing the current > implicitWidth > > It's impossible for a user of the component to do this accurately > because it needs both the label

Re: Review Request: reuse knewstuff's itemsview class to provide smooth scrolling in wallpaper configuration screen

2012-09-24 Thread Sebastian Kügler
On Sunday, September 23, 2012 11:02:02 Commit Hook wrote: > Can this also pushed to 4.9 branch? Don't forget to push to master as well. (Or maybe I missed that one?) -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-d

Re: commit problem

2012-09-24 Thread Sebastian Kügler
On Tuesday, September 25, 2012 06:26:15 Reza Shah wrote: > Thanks, yesterday talked with Marco at #plasma and managed to solve this. A short note that it's solved would have been nice in this case, it saves others some time. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key I

Re: Fit Grid elements in Item

2012-09-25 Thread Sebastian Kügler
On Monday, September 24, 2012 22:06:00 Luiz Romário Santana Rios wrote: > This works nicely. Thank you all very much for the help. > > But here's another question: How do I set a different size for the "0" > and "=" buttons? Repeater doesn't let me set a property differently > based on the index a

Re: Fit Grid elements in Item

2012-09-25 Thread Sebastian Kügler
On Monday, September 24, 2012 22:37:03 Luiz Romário Santana Rios wrote: > And another thing: while this works for the width, the analogous code > for the height (height: (grid.height / grid.rows) - grid.spacing) does > this: http://oi48.tinypic.com/24l7jom.jpg . Why? That looks odd. Can you post t

Re: Plasma Wallpapers in QML

2012-09-25 Thread Sebastian Kügler
On Tuesday, September 25, 2012 10:24:04 Aleix Pol wrote: > On Tue, Sep 25, 2012 at 9:31 AM, Aaron J. Seigo wrote: > > On Tuesday, September 25, 2012 03:21:39 Aleix Pol wrote: > >> git clone kde:scratch/apol/qmlwallpapers > > > > works very nicely; would be even nicer if mouse events were passed >

Re: Behavior on systray icon clicking

2012-09-25 Thread Sebastian Kügler
On Tuesday, September 25, 2012 14:37:45 Kåre Särs wrote: > On Tuesday 25 September 2012 12:56:40 Aaron J. Seigo wrote: > > On Tuesday, September 25, 2012 13:33:11 Kåre Särs wrote: > > > I have spacial memory > > > > this is a basic part of human cognitive abilities. even toddlers who can > > only

Re: Fit Grid elements in Item

2012-09-25 Thread Sebastian Kügler
On Tuesday, September 25, 2012 12:42:58 Luiz Romário Santana Rios wrote: > And also, are there more plasmoids which are not in that listing? The list *should* be complete. If you find anything that's not in there, please add it. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 91

Re: Review Request: Move plasma tools into plasmate

2012-09-26 Thread Sebastian Kügler
On Wednesday, September 26, 2012 09:47:25 Aaron J. Seigo wrote: > http://git.reviewboard.kde.org/r/106580/#review19443 > > Ship it! > > as this generates large diffs, affects multiple repositories simultaneously > and is just really moving things around, i don't think this is very well > suited t

Re: plasma2 and ToolTipManager

2012-09-26 Thread Sebastian Kügler
On Wednesday, September 26, 2012 15:35:26 Marco Martin wrote: > comments? Sounds straightforward to do. Do we need WM support for the placement? -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Pla

Re: plasma: QGraphicsView-ectomy

2012-09-26 Thread Sebastian Kügler
On Wednesday, September 26, 2012 17:15:14 Aaron J. Seigo wrote: > > * PopupApplet: i don't think it should be a differerent class from > > Applet, still don't have a clear idea how to do that, but the only > > difference could be in desktop file > > i actually really like the idea that all aplets

Re: Move kde-workspace/plasma/generic/tools into plasmate

2012-09-26 Thread Sebastian Kügler
On Wednesday, September 26, 2012 14:14:16 Giorgos Tsiapaliokas wrote: > Hello, > > In the attached patch I move the kde-workspace/plasma/generic/tools into > plasmate > and also I move the plasmate into plasmate/plasmate. > > What do you think? Go for it. -- sebas http://www.kde.org | http://v

Re: plasma: QGraphicsView-ectomy

2012-09-26 Thread Sebastian Kügler
On Wednesday, September 26, 2012 17:15:14 Aaron J. Seigo wrote: > > * View: not sure what to do with this (also, there is still come code > > commented in applet and containment that was using views) I'm open to > > ideas on what the semantics of this should be. i would like not having > > views at

Re: Fit Grid elements in Item

2012-09-27 Thread Sebastian Kügler
On Wednesday, September 26, 2012 20:27:08 Luiz Romário Santana Rios wrote: > 2012/9/25 Luiz Romário Santana Rios : > > Em 25/09/2012 08:44, "Marco Martin" escreveu: > >> take a look at the > >> bettio/qml-gsoc-calculator branch, you should continue from that work > >> already done. > > > > Oh. >

Re: Review Request: Fix repositioning the toolbox when the widgets are locked

2012-09-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106457/#review19491 --- Ship it! Looks good. - Sebastian Kügler On Sept. 16, 2012

Re: Review Request: Avoid Calling setFailedToLaunch from Microblog Plasmoid

2012-09-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106622/#review19576 --- Ship it! Ship It! - Sebastian Kügler On Sept. 28, 2012, 12

Re: Display Configuration KCM design review

2012-10-02 Thread Sebastian Kügler
On Tuesday, October 02, 2012 14:29:24 Dan Vrátil wrote: > As some might notice [0], we are working with Alex Fiestas on new display > management for KDE. I'm now working on new KCM. Aaron suggested in comments > below the blog post that it would be nice to discuss design of the KCM with > you, Pl

Re: Review Request: Correct horizontalAlignment and verticalAlignment properties of TextArea

2012-10-03 Thread Sebastian Kügler
components as well? There's a changed copy of this component with different text-selection mechanics, so your patch would be useful there as well. - Sebastian Kügler On Oct. 3, 2012, 12:22 a.m., Romário Rios wrote: > > --- &

Re: Review Request: Fix TextArea Plasma component documentation

2012-10-03 Thread Sebastian Kügler
as well? There's a changed copy of this component with different text-selection mechanics, so your patch would be useful there as well. - Sebastian Kügler On Oct. 3, 2012, 1:31 a.m., Romário Rios wrote: > > --- > This is an

Re: [RFC] Trigger KRunner on top screenedge

2012-10-03 Thread Sebastian Kügler
On Wednesday, October 03, 2012 13:44:06 Martin Gräßlin wrote: > just wanted some feedback on an idea I got today. What about binding the > showing of KRunner on hitting the top screen edge? > > Given that KRunner slides in from the top edge it would end up in a neat > functionality, throw the cu

Re: Button component width

2012-10-03 Thread Sebastian Kügler
On Wednesday, October 03, 2012 22:44:20 Mark wrote: > You really seem to be thinking in plasma active. And in there it might > actually work and benefit in every possible way. On the desktop things > like this just don't work. Devs want to have freedom and certainly > don't want to be limited. One

Re: Review Request: Fix TextArea Plasma component documentation

2012-10-04 Thread Sebastian Kügler
On Wednesday, October 03, 2012 23:52:52 Romário Rios wrote: > But > kde-runtime/plasma/declarativeimports/plasmacomponents/platformcomponents/t > ouch/TextArea.qml has no documentation. Am I missing something? No, you're right. The touch components are switched internally, the docs are the same.

Re: Review Request: Trigger KRunner from screenedge

2012-10-04 Thread Sebastian Kügler
On Thursday, October 04, 2012 12:27:11 Martin Gräßlin wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106721/ > Trigger KRunner from screenedge > > New screen edge action is adde

Re: [RFC] Trigger KRunner on top screenedge

2012-10-07 Thread Sebastian Kügler
On Wednesday, October 03, 2012 17:28:24 Martin Gräßlin wrote: > On Wednesday 03 October 2012 16:15:40 Sebastian Kügler wrote: > > On Wednesday, October 03, 2012 13:44:06 Martin Gräßlin wrote: > > > just wanted some feedback on an idea I got today. What about binding the > >

Re: Review Request: Fix battery applet screen power management

2012-10-10 Thread Sebastian Kügler
On Wednesday, October 10, 2012 15:43:11 Lukáš Tinkl wrote: > Good catch, is this code only in master or also in 4.9 branch? Should be the same in both, this fix needs to go into both branches. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 _

Re: Review Request: Device notifier: show mounted device and path

2012-10-12 Thread Sebastian Kügler
ttp://git.reviewboard.kde.org//r/106755/#scomment101> This tooltip looks really odd and out of place this way.:/ - Sebastian Kügler On Oct. 12, 2012, 9:41 a.m., Jonathan Marten wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request: Fix padding to the left and right of text in a textField

2012-10-12 Thread Sebastian Kügler
On Thursday, October 11, 2012 15:09:07 David Edmundson wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106797/ > --- > > Rev

Re: Review Request: Device notifier: show mounted device and path

2012-10-12 Thread Sebastian Kügler
On Friday, October 12, 2012 13:42:35 Lamarque Vieira Souza wrote: > This tooltip looks really odd and out of place this way.:/ > The transparency effect does not look good here. I would like to know how to > disable it too, there is this bug against the QML shutdown dialog with the > same problem:

Review Request: Containments expose an AppletContainer

2012-10-12 Thread Sebastian Kügler
with a new Containment, works as expected. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Containments expose an AppletContainer

2012-10-12 Thread Sebastian Kügler
with a new Containment, works as expected. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Fix PlasmaExtras.DisappearAnimation

2012-10-12 Thread Sebastian Kügler
--- animated a FrameSvgItem appearing and disappearing, works as expected, no apparent side effects. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma: QGraphicsView-ectomy

2012-10-17 Thread Sebastian Kügler
On Monday, October 15, 2012 18:45:01 Marco Martin wrote: > On Monday 24 September 2012, Marco Martin wrote: > > Hi all, > > I've committed in the kdelibs branch plasma/mart/qgvremoval a pretty big > > diff. it makes Applet inherit only from QObject this causes a nice doino > > effect: all api that

Re: Doxygen for QML components

2012-10-17 Thread Sebastian Kügler
On Wednesday, October 17, 2012 16:09:51 Aurélien Gâteau wrote: > Are you OK with me following up with maintainers of api.kde.org so that > doxyqml is used to generate documentation there? +1 :) Thanks, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 __

Review Request: Fix screenChanged signal in javascript appletinterface

2012-10-17 Thread Sebastian Kügler
/appletinterface.cpp:605 Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.cpp f2ccf61 Diff: http://git.reviewboard.kde.org/r/106936/diff/ Testing --- Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel

Review Request: Fix ReferenceErrors in ListItem

2012-10-17 Thread Sebastian Kügler
Diff: http://git.reviewboard.kde.org/r/106937/diff/ Testing --- tried the news app and widgetgallery, no regressions seen. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: fix batterymonitor layout to scale with high resolution screens

2012-10-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106962/#review20600 --- Ship it! Ship It! - Sebastian Kügler On Oct. 20, 2012, 12

plans for Plasma Desktop default containment in QML

2012-10-22 Thread Sebastian Kügler
Hi fellow Plasma devs, I've been working on a QML port of our default desktop containment. It's still very immature, and a few feature are lacking, but it lead me to think about how we could go about replacing the default desktop with this eventually. Now it won't be ready (in sufficient qualit

Re: plans for Plasma Desktop default containment in QML

2012-10-22 Thread Sebastian Kügler
On Monday, October 22, 2012 17:19:32 todd rme wrote: > Can you submit it to kde-look.org in the meantime? Does plasma > support installing containments through GHNS? Sure, and I don't know. :) I'll roll a package once I've got a few more features in, and when feedback starts making sense (i.e.

Re: plans for Plasma Desktop default containment in QML

2012-10-24 Thread Sebastian Kügler
Hey, On Wednesday, October 24, 2012 11:39:59 Marco Martin wrote: > On Monday 22 October 2012, Sebastian Kügler wrote: > > being merged in the process), some are things that we have been shipping > > in the MobileComponents QML module for some time. (MobileComponents has > >

Re: using device targets in qml plasmoids

2012-10-24 Thread Sebastian Kügler
On Wednesday, October 24, 2012 11:41:17 Aaron J. Seigo wrote: > thoughts? Not quite happy with it, with my experience from the microblog app. There, the orthogonal input / layout makes complete sense, as you get the following combinations: touch / widget: perfect for smartphone screen, using

Re: plans for Plasma Desktop default containment in QML

2012-10-24 Thread Sebastian Kügler
On Monday, October 22, 2012 13:33:45 Sebastian Kügler wrote: > My overall thinking is that I'd like the infrastructural work to be complete > for the 4.10 release (which seems achievable to me if we don't run into > architectural problems) so that Plasma 4.10 brings everything n

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-24 Thread Sebastian Kügler
On Tuesday, October 23, 2012 14:53:43 Andreas Demmer wrote: > I would also suggest to give the label text at least some shadows since the > current white is somewhat hard to read: > > http://wstaw.org/m/2012/10/23/plasma-desktopr24762.png Doesn't look like it's using the correct color from the t

Re: using device targets in qml plasmoids

2012-10-24 Thread Sebastian Kügler
On Wednesday, October 24, 2012 13:58:19 Aaron J. Seigo wrote: > On Wednesday, October 24, 2012 12:16:37 Sebastian Kügler wrote: > > On Wednesday, October 24, 2012 11:41:17 Aaron J. Seigo wrote: > > > thoughts? > > > > I think screensize/layout and input meth

Re: using device targets in qml plasmoids

2012-10-24 Thread Sebastian Kügler
On Wednesday, October 24, 2012 15:35:39 Aaron J. Seigo wrote: > On Wednesday, October 24, 2012 14:58:32 Sebastian Kügler wrote: > > I've also found that I don't need touch-specific stuff in the app code > > itself, the input specific things are already sorted in PlasmaCo

Re: using device targets in qml plasmoids

2012-10-24 Thread Sebastian Kügler
On Wednesday, October 24, 2012 16:36:35 Aaron J. Seigo wrote: > On Wednesday, October 24, 2012 16:09:23 Sebastian Kügler wrote: > > By the way, something notmart and I discussed a few days ago ... it would > > be handy if we had the input method ("touch", ...) accessible f

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread Sebastian Kügler
. plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml <http://git.reviewboard.kde.org/r/107026/#comment16439> Why remove this fade in animation? - Sebastian Kügler On Oct. 24, 2012, 6:20 p.m., David Edmundson

dependency problem with logout from kde-runtime scriptengine

2012-10-28 Thread Sebastian Kügler
Hey, Context: I'm working on the QML/JavaScript scriptengine in kde-runtime right now to add all the features necessary to write full-featured desktop containments in QML, with the goal to port the desktop containment to QML. (More on the in my email "plans for Plasma Desktop default containmen

QActions in QML

2012-10-28 Thread Sebastian Kügler
On Thursday, October 25, 2012 20:00:25 Aaron J. Seigo wrote: > not automatically, no. but QActions are QObjects, so you can attach to their > signals in the QML. And it's quite wonky, for example offering a list of QActions (QDeclarativeListProperty or QList, even with the payload casted to QObje

Re: Microblog port to Akonadi pushed into a branch

2012-10-28 Thread Sebastian Kügler
Hi Martin, On Saturday, October 27, 2012 19:23:46 Martin Klapetek wrote: > I've just pushed my port of Microblog declarative plasmoid in a branch - > mklapetek/akonadi_port (kde:declarative-plasmoids). Setting this up needs > kdepim-libs from master, kde:libkfacebook (currently in kdereview), > kd

Re: QML style guide

2012-10-29 Thread Sebastian Kügler
On Monday, October 29, 2012 21:42:18 Aaron J. Seigo wrote: > http://community.kde.org/Plasma/QMLStyle I'm probably cool with the outcome, whatever the details are and will start adopting right now. :) Thanks for bringing it up, -- sebas http://www.kde.org | http://vizZzion.org | GPG Ke

Re: QML style guide

2012-10-30 Thread Sebastian Kügler
Hey, On Tuesday, October 30, 2012 14:14:05 Dmitry Ashkadov wrote: > 30.10.2012 13:15, Aaron J. Seigo пишет: > >> 1. I think you should explain why you have chosen such style instead of > >> another one. Your decision should be justified. > > > > this is the death of style guides. for many style

Re: QML style guide

2012-10-30 Thread Sebastian Kügler
On Tuesday, October 30, 2012 12:25:14 Dmitry Ashkadov wrote: > First of all, it a good idea! > > 1. I think you should explain why you have chosen such style instead of > another one. Your decision should be justified. For example: I don't > understand why you put brace on new line in case of fun

Re: QActions in QML

2012-10-30 Thread Sebastian Kügler
On Monday, October 29, 2012 13:46:18 Marco Martin wrote: > On Monday 29 October 2012, Daker Fernandes Pinheiro wrote: > > > > Daker Fernandes Pinheiro > > > > http://codecereal.blogspot.com > > > isn't QAction already registered as "action" primitive type? > > > > At least not on QtQuick 1.1 > >

Re: QML style guide

2012-10-30 Thread Sebastian Kügler
On Tuesday, October 30, 2012 11:35:50 Aaron J. Seigo wrote: > > >> 5. Vim: > > >>> The {{{ and }}} are just for the sakes of vim's automatic folding. > > >> > > >> Do we all use vim? I think no. So, we must never force developers use > > >> vim. > > > > > > i mostly agree :) i don't think this forc

Re: QActions in QML

2012-10-30 Thread Sebastian Kügler
On Tuesday, October 30, 2012 16:01:37 Kevin Krammer wrote: > On Tuesday, 2012-10-30, Sebastian Kügler wrote: > > On Monday, October 29, 2012 13:46:18 Marco Martin wrote: > > > On Monday 29 October 2012, Daker Fernandes Pinheiro wrote: > > > > > > Daker

Re: QActions in QML

2012-10-30 Thread Sebastian Kügler
On Sunday, October 28, 2012 22:33:55 Daker Fernandes Pinheiro wrote: > This just worked: > http://paste.kde.org/584660/ > Where QAction is > http://paste.kde.org/584672/ I saw that, but you're cheating :) Creating a new Type that wraps QAction is always possible, but it's not a good solution. A

Review Request: Declarative bindings for ToolBox

2012-10-31 Thread Sebastian Kügler
ed5c8ae Diff: http://git.reviewboard.kde.org/r/107150/diff/ Testing --- Using this with my proof-of-concept desktop containment, seems to work as expected, for example screen locking changes are picked up as expected. Thanks, Sebastian Kügler

Review Request: AppletContainer has moved to scriptengine

2012-10-31 Thread Sebastian Kügler
n and system tray in plasma-device and plasma-desktop and plasmoidviewer, no errors. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Add Package bindings from MobileComponents to PlasmaCore

2012-10-31 Thread Sebastian Kügler
Diff: http://git.reviewboard.kde.org/r/107166/diff/ Testing --- Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Declarative bindings for ToolBox

2012-11-01 Thread Sebastian Kügler
Hi Marco, Thanks for the review! On Thursday, November 01, 2012 12:29:25 Marco Martin wrote: > I'm quite on the fence with this. > I'm not sure it should be the qml containment to explicitly create the > toolbox, but more: > > the c++ part of the containment scriptengine loads and parses the qml

Re: Review Request: Add Package bindings from MobileComponents to PlasmaCore

2012-11-01 Thread Sebastian Kügler
On Thursday, November 01, 2012 12:59:56 Aaron J. Seigo wrote: > even right now, even with generic packages, all sorts of files can be > fetched: org.kde.active.launcher, org.kde.activityswitcher, > org.kde.active.widgetsexplorer, etc. > > the security / cleanliness aspect of this is not opened up

Re: Review Request: Fix bold text in battery-monitor tooltip

2012-11-02 Thread Sebastian Kügler
! plasma/generic/applets/batterymonitor/contents/code/logic.js <http://git.reviewboard.kde.org/r/107173/#comment16614> The first agument is a comment for the translators. It won't need to be bold. - Sebastian Kügler On Nov. 1, 2012, 10:26 p.m., Michele Gas

Re: Review Request: Fix bold text in battery-monitor tooltip

2012-11-05 Thread Sebastian Kügler
> On Nov. 2, 2012, 11:18 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/batterymonitor/contents/code/logic.js, line 68 > > <http://git.reviewboard.kde.org/r/107173/diff/1/?file=93189#file93189line68> > > > > The first agument is a comment for the

Re: Review Request: digital clock widget - popup focus

2012-11-05 Thread Sebastian Kügler
ted this comment as reply to the bugreport. - Sebastian Kügler On Aug. 20, 2012, 6:07 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-05 Thread Sebastian Kügler
iewer.cpp <http://git.reviewboard.kde.org/r/107209/#comment16678> bool visible - Sebastian Kügler On Nov. 5, 2012, 2:25 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-05 Thread Sebastian Kügler
> On Nov. 5, 2012, 3 p.m., Sebastian Kügler wrote: > > plasmate/previewer/plasmoid/previewcontainment.h, line 42 > > <http://git.reviewboard.kde.org/r/107209/diff/1/?file=93718#file93718line42> > > > > add the bool visible also here > > Antonis Tsia

Re: Fwd: Help

2012-11-06 Thread Sebastian Kügler
Hi Mike, The forums at http://forum.kde.org has friendly people who can most likely run you through those steps. On Monday, November 05, 2012 13:33:33 Chani wrote: > From: Mike Vassalotti > I use Linux Open SUSE in Oracle Virtual Box. Everything is working > fine except for one: I cannot get t

Re: QML Buttons and SVG images

2012-11-06 Thread Sebastian Kügler
Hey Dmitry On Tuesday, November 06, 2012 14:22:39 Dmitry A. Ashkadov wrote: > So, if I understand you right, now I shouldn't use QML Button instead of > IconWidget? If I remove IconWidget then: IconWidget is something we want to get rid of at some point anyway. > * I will have to work with QActi

Re: Review Request: Plasmate: Port QDialog to KDialog

2012-11-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107230/#review21505 --- Ship it! Ship It! - Sebastian Kügler On Nov. 6, 2012, 8:33

Review Request: ToolBox bindings for declarative containments

2012-11-06 Thread Sebastian Kügler
://git.reviewboard.kde.org/r/107232/diff/ Testing --- Using this with QML Desktop Containment, works as advertised above. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Declarative bindings for ToolBox

2012-11-06 Thread Sebastian Kügler
https://git.reviewboard.kde.org/r/107232/ Discarding this one. - Sebastian Kügler On Oct. 31, 2012, 1:41 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revi

Re: Review Request: ToolBox bindings for declarative containments

2012-11-07 Thread Sebastian Kügler
s with QML Desktop Containment, works as advertised above. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-07 Thread Sebastian Kügler
oid/previewcontainment.cpp <http://git.reviewboard.kde.org/r/107209/#comment16773> Better compare it to its actual state, rather than its default state. plasmate/previewer/plasmoid/previewcontainment.cpp <http://git.reviewboard.kde.org/r/107209/#comment16772> remove that one b

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-08 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/#review21628 --- Ship it! Good to go :) - Sebastian Kügler On Nov. 8, 2012

Re: Introducing Homerun

2012-11-19 Thread Sebastian Kügler
On Wednesday, November 14, 2012 11:30:58 Aurélien Gâteau wrote: > > > * Browsable models > > > If you list the content of a dir > > > > I would stick to the standard directory listing model for this rather than > > invent something new. Search returns from a Runner may return a directory; > > click

Re: Introducing Homerun

2012-11-19 Thread Sebastian Kügler
On Tuesday, November 13, 2012 11:54:50 Tomaz Canabrava wrote: > So krunner is broken and I should step in to fix that :) > just tried here ( alt+f2, dolphin, repeat 6 times ) and I got a looot of new > instances of dolphin ^^ That's a feature, not a bug. KRunner remembers what you "always" do. Cho

Re: Review Request: Containments expose an AppletContainer

2012-11-20 Thread Sebastian Kügler
://techbase.kde.org/Development/Tutorials/Plasma/QML/API#Containments - Sebastian Kügler On Oct. 13, 2012, 12:43 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboa

Re: Review Request: Declarative bindings for ToolBox

2012-11-20 Thread Sebastian Kügler
://techbase.kde.org/Development/Tutorials/Plasma/QML/API#Containments and http://techbase.kde.org/Development/Tutorials/Plasma/JavaScript/API-PlasmoidObject#Containment_specific - Sebastian Kügler On Oct. 31, 2012, 1:41 p.m., Sebastian Kügler wrote

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22303 --- Ship it! Ship It! - Sebastian Kügler On Nov. 21, 2012, 9

[RFC] New (QML) Desktop Containment

2012-11-21 Thread Sebastian Kügler
Hi, As you might know, I'm porting our desktop containment to QML. The platformy bits are now nearly complete (and merged into master cq. 4.10. On the UI side, progress has also been rather good. There's a QML ToolBox now, and I've got a proof-of-concept version of the containment itself going,

Re: [RFC] New (QML) Desktop Containment

2012-11-21 Thread Sebastian Kügler
Hola, On Wednesday, November 21, 2012 20:42:09 Alex Fiestas wrote: > On Wednesday 21 November 2012 20:10:06 Sebastian Kügler wrote: > > As you might know, I'm porting our desktop containment to QML. The > > platformy bits are now nearly complete (and merged into master cq.

Re: [RFC] New (QML) Desktop Containment

2012-11-21 Thread Sebastian Kügler
Ciao Marco, On Wednesday, November 21, 2012 21:13:13 Marco Martin wrote: > On Wednesday 21 November 2012, Sebastian Kügler wrote: > > I've recorded a ~3 minute movie that shows the current state: > > http://www.youtube.com/watch?v=zbSuNrn3qoU > > loo

Re: [RFC] New (QML) Desktop Containment

2012-11-21 Thread Sebastian Kügler
On Wednesday, November 21, 2012 21:13:13 Marco Martin wrote: > > * dropping stuff onto the containment doesn't work > > as far i seen, the items (not sure if they all do, or just mousearea) just > eat the dropevent. > maybe the containment implementation in the scriptengine should > filterChildE

Re: [RFC] New (QML) Desktop Containment

2012-11-22 Thread Sebastian Kügler
Hi, On Thursday, November 22, 2012 12:45:38 Aaron J. Seigo wrote: > On Wednesday, November 21, 2012 20:10:06 Sebastian Kügler wrote: > > * less visual clutter (especially caused by applet handle when unlocked) > > how is it less visual clutter when the unlocked state, which

Re: [RFC] New (QML) Desktop Containment

2012-11-22 Thread Sebastian Kügler
Hey, On Thursday, November 22, 2012 13:31:40 Aaron J. Seigo wrote: > On Thursday, November 22, 2012 13:05:05 Sebastian Kügler wrote: > > The idea is to make locked mode the default > > so to do anything to the system, one first has to discover that it can be > unlocked, th

<    1   2   3   4   5   6   7   8   9   10   >