Re: [platform-dev] Regarding SWT patch reviews

2019-04-16 Thread Conrad Groth
These (high) expectations were the reason why I stepped back from providing further SWT patches for windows. Am 16. April 2019 15:51:43 MESZ schrieb Niraj Modi : >Updated FAQ entry: >https://www.eclipse.org/swt/faq.php#swtpatchtestingdetails with below >note >suggesting the importance of this

Re: [platform-dev] Regarding SWT patch reviews

2019-04-16 Thread Lars Vogel
I think the feedback of the PMC was that these requirement are to strong. I will prepare a Gerrit to make this text more welcoming and add to as reviewer, Niraj. Best regards, Lars On Tue, Apr 16, 2019 at 3:51 PM Niraj Modi wrote: > > Updated FAQ entry: >

Re: [platform-dev] Regarding SWT patch reviews

2019-04-16 Thread Daniel Megert
> +1 to Alex opinion. Our target should be to longer the entrance barriers for new contributors not increase them. +1 too. Dani From: Lars Vogel To: "Eclipse platform general developers list." Date: 16.04.2019 14:02 Subject:Re: [platform-dev] Regarding SWT patch reviews

Re: [platform-dev] Regarding SWT patch reviews

2019-04-16 Thread Nikita Nemkin
On Tue, Apr 16, 2019 at 4:38 PM Niraj Modi wrote: > Hi All, > In order to speed up the patch review cycle, we have framed a checklist of > testing that's needed against an SWT patch submitted for review. > Here is the complete list that needs to be associated with the patch: The list looks

Re: [platform-dev] Regarding SWT patch reviews

2019-04-16 Thread Lars Vogel
s/longer/lower Lars Vogel schrieb am Di., 16. Apr. 2019, 14:01: > +1 to Alex opinion. Our target should be to longer the entrance barriers > for new contributors not increase them. > > Especially in SWT Win and Mac in which only very few committers are active. > > > > Aleksandar Kurtakov

Re: [platform-dev] Regarding SWT patch reviews

2019-04-16 Thread Aleksandar Kurtakov
On Tue, Apr 16, 2019 at 2:38 PM Niraj Modi wrote: > Hi All, > In order to speed up the patch review cycle, we have framed a checklist of > testing that's needed against an SWT patch submitted for review. > Here is the complete list that needs to be associated with the patch: > >- Results of

[platform-dev] Regarding SWT patch reviews

2019-04-16 Thread Niraj Modi
Hi All, In order to speed up the patch review cycle, we have framed a checklist of testing that's needed against an SWT patch submitted for review. Here is the complete list that needs to be associated with the patch: Results of the test snippet (if any) associated with that specified bug.