Re: [platform-dev] Marking nested projects as derived, what are the risks?

2020-01-22 Thread Alexander Fedorov
Hello, -1 for setting derived=true for nested resources as consequences are unpredictable. There is a set of API calls like: IWorkspaceRoot.findContainersForLocationURI(URI) IWorkspaceRoot.findFilesForLocationURI(URI) I'm using it for complex IDE scenarios to understand about possible

Re: [platform-dev] Mass changes again

2020-01-22 Thread Aleksandar Kurtakov
On Wed, Jan 22, 2020 at 1:29 PM Lakshmi P Shanmugam wrote: > > Mac and Windows builds are unstable for probably a year now (or even > more!). > The Mac and Windows builds are stable. But, the tests in e4.ui.tests and > ui.tests.* have been failing, many of them for several releases. It should >

Re: [platform-dev] Mass changes again

2020-01-22 Thread Lakshmi P Shanmugam
> Mac and Windows builds are unstable for probably a year now (or even more!). The Mac and Windows builds are stable. But, the tests in e4.ui.tests and ui.tests.* have been failing, many of them for several releases. It should be investigated if the tests are unstable.   Kalyan has been opening

Re: [platform-dev] Marking nested projects as derived, what are the risks?

2020-01-22 Thread Andrey Loskutov
Mickael, Resources API is not about UI. "Hidden resources are invisible to most clients" means almost all clients will never get hidden resources at all in almost all "usual" Resources API calls. So this is NOT the API you want. There is NO API for what do you want to achieve, therefore you need

Re: [platform-dev] Marking nested projects as derived, what are the risks?

2020-01-22 Thread Mickael Istria
On Wed, Jan 22, 2020 at 10:04 AM Andrey Loskutov wrote: > I fully agree with Tom. > In one of the my answers I've already suggested to think about something > like boolean IResource::isNested() API. > If we do that, then we need to change all clients to read this new state. I'm really looking

Re: [platform-dev] Marking nested projects as derived, what are the risks?

2020-01-22 Thread Andrey Loskutov
I fully agree with Tom. In one of the my answers I've already suggested to think about something like boolean IResource::isNested() API.   Regarding isHidden() question: NO. As javadoc on setHidden() says: Hidden resources are invisible to most clients.   Kind regards, Andrey Loskutov

Re: [platform-dev] Marking nested projects as derived, what are the risks?

2020-01-22 Thread Tom Schindl
Hi, I think the only correct solution is to enhance the core API and then adjust all components. Is it a lot of work? yes! But I think it is the only viable long term solution. Tom Von meinem iPhone gesendet > Am 22.01.2020 um 09:34 schrieb Mickael Istria : > >  > Hi all, > > So I'm

Re: [platform-dev] Marking nested projects as derived, what are the risks?

2020-01-22 Thread Mickael Istria
Hi all, So I'm making progress in my thoughts around those issues. What about hidden resources? To rephrase "Marking folders for nested projects as hidden, what are the risks?" I'm not really sure of what hidden implies under the hood, but the documentation seems pretty flexible in usage. Maybe