Re: [platform-dev] Commit messages

The "why" should become clear from the bug description. Obviously it is important in the commit message but the "what" is more important. All depends on the change obviously but all commits that include a bugnummer should follow the convention. We can improve on the template in the wiki and e.g.

Re: [platform-dev] Commit messages

I'd rather vote for *why* something has changed. Tom On 2020-10-24 16:53, Wim Jongman wrote: In general, I would say that the commit message must clearly explain to others what has changed. On Sat, Oct 24, 2020 at 2:39 PM Alex Blewitt wrote: On 24 Oct 2020, at 13:12, Wim Jongman

Re: [platform-dev] Commit messages

Thanks Wim to bringing this up. We have [1] for commit message conventions, but it is unfortunately not really followed in the platform. The only thing is used is the link the bug number in commit title - this is good, but that is too less for a good commit message. My main point is: all non

Re: [platform-dev] Commit messages

In general, I would say that the commit message must clearly explain to others what has changed. On Sat, Oct 24, 2020 at 2:39 PM Alex Blewitt wrote: > > > On 24 Oct 2020, at 13:12, Wim Jongman wrote: > > > > Andrey recently pointed out on a couple of commits that commit messages > could be

Re: [platform-dev] Commit messages

Perhaps standardize in the recommendations from: https://chris.beams.io/posts/git-commit/ The seven rules of a great Git commit message *Keep in mind: This has

Re: [platform-dev] Commit messages

> On 24 Oct 2020, at 13:12, Wim Jongman wrote: > > Andrey recently pointed out on a couple of commits that commit messages could > be better. I agree with that. Do you have specific or generic types of advice of what could be made better about the commit messages? Alex Sent from my iPhone

[platform-dev] Commit messages

Hello, Andrey recently pointed out on a couple of commits that commit messages could be better. I agree with that. Can we discuss this? Cheers, Wim A list of recent commits is here: https://git.eclipse.org/c/platform/eclipse.platform.ui.git/log/ ___