Re: [PATCH 5/5] thinkpad_acpi: Convert dbg_printk to tp_dbg and tp_vdbg

2012-06-23 Thread Joe Perches
On Sat, 2012-06-23 at 21:40 -0300, Henrique de Moraes Holschuh wrote: > On Sun, 17 Jun 2012, Joe Perches wrote: > > Use a more current logging style. > > > > Add #define DEBUG and use pr_debug to enable dynamic debugging. > > Coalesce formats and align arguments. > > > > Signed-off-by: Joe Perche

Re: [PATCH 5/5] thinkpad_acpi: Convert dbg_printk to tp_dbg and tp_vdbg

2012-06-23 Thread Henrique de Moraes Holschuh
On Sun, 17 Jun 2012, Joe Perches wrote: > Use a more current logging style. > > Add #define DEBUG and use pr_debug to enable dynamic debugging. > Coalesce formats and align arguments. > > Signed-off-by: Joe Perches Joe, are there any extra procedures required from the user to get the debug mess

Re: [PATCH 2/5] thinkpad_acpi: Use struct dev_pm_ops instead of legacy PM routines

2012-06-23 Thread Henrique de Moraes Holschuh
On Sun, 17 Jun 2012, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Make the thinkpad_acpi driver define its PM callbacks through > a struct dev_pm_ops object rather than by using legacy PM hooks > in struct platform_driver. > > Signed-off-by: Rafael J. Wysocki Acked-by: Henrique de Mo

Re: [PATCH 1/5] thinkpad_acpi: Drop pm_message_t arguments from suspend routines

2012-06-23 Thread Henrique de Moraes Holschuh
On Sun, 17 Jun 2012, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Multiple suspend routines in drivers/platform/x86/thinkpad_acpi.c > use take pm_message_t arguments that aren't used by any of them. > Make those routines take no arguments as that's what they should do. > > Signed-off-b

[PATCH] sonypi: Use struct dev_pm_ops for power management

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the sonypi driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct platform_driver. Signed-off-by: Rafael J. Wysocki --- Hi, If there are no objections, I'd like to push this patch for 3.6 through the linux-

[PATCH 13/21] hp_accel: Use struct dev_pm_ops for power management

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the hp_accel driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/platform/x86/hp_accel.c | 15 --- 1 file changed, 8 insertions(

[PATCH 3/21] ACPI / PM: Make acpi_bus_type use driver struct dev_pm_ops callbacks

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Modify acpi_bus_type so that it executes PM callbacks provided by drivers through their struct dev_pm_ops objects, if present, while still allowing the legacy ACPI PM callbacks to take precedence. This will make it possible to convert ACPI drivers one by one to handling PM

[PATCH 16/21] toshiba_bluetooth: Use struct dev_pm_ops for power management

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the toshiba_bluetooth driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/platform/x86/toshiba_bluetooth.c | 10 ++ 1 file changed,

[PATCH 10/21] ACPI: Use struct dev_pm_ops for power management in the power driver

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the ACPI power resource driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/power.c | 12 1 file changed, 8 insertions(+),

[PATCH 15/21] panasonic-laptop: Use struct dev_pm_ops for power management

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the panasonic-laptop driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/platform/x86/panasonic-laptop.c | 16 +++- 1 file chang

[PATCH 14/21] sony-laptop: Use struct dev_pm_ops for power management

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the sony-laptop driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/platform/x86/sony-laptop.c | 20 1 file changed, 12

[PATCH 7/21] ACPI: Use struct dev_pm_ops for power management in the AC driver

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the ACPI AC adapter driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/ac.c | 17 - 1 file changed, 12 insertions(+),

[PATCH 8/21] ACPI: Use struct dev_pm_ops for power management in the battery driver

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the ACPI battery driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/battery.c | 15 +++ 1 file changed, 11 insertions(+),

[PATCH 9/21] ACPI: Use struct dev_pm_ops for power management in the button driver

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the ACPI button driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/button.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletio

[PATCH 12/21] toshiba_acpi: Use struct dev_pm_ops for power management

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the toshiba_acpi driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/platform/x86/toshiba_acpi.c | 14 -- 1 file changed, 8 inse

[PATCH 5/21] ACPI: Use struct dev_pm_ops for power management in the thermal driver

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the ACPI thermal driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/thermal.c | 17 ++--- 1 file changed, 10 insertions(+)

[PATCH 4/21] ACPI: Use struct dev_pm_ops for power management in the fan driver

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the ACPI fan driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/fan.c | 21 +++-- 1 file changed, 11 insertions(+), 10

[PATCH 2/21] ACPI / PM: Make acpi_bus_type use struct dev_pm_ops for PM handling

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the acpi_bus_type bus type define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct bus_type. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/scan.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-)

[PATCH 1/21] ACPI / PM: Drop pm_message_t argument from device suspend callback

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki None of the drivers implementing the ACPI device suspend callback uses the pm_message_t argument of it, so this argument may be dropped entirely from that callback. This will simplify switching the ACPI bus type to PM handling based on struct dev_pm_ops. Signed-off-by: R

[PATCH 18/21] acpi_power_meter: Use struct dev_pm_ops for power management

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the ACPI power meter driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/hwmon/acpi_power_meter.c | 13 + 1 file changed, 9 inse

[PATCH 19/21] ACPI / PM: Do not execute legacy driver PM callbacks

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Since all ACPI drivers in the tree should have been switched to power management handling based on struct dev_pm_ops, modify the ACPI bus type driver so that is doesn't execute legacy driver power management callbacks from the functions pointed to by the members of the acp

[PATCH 17/21] xo15-ebook: Use struct dev_pm_ops for power management

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the xo15-ebook driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/platform/x86/xo15-ebook.c |8 +--- 1 file changed, 5 insertions(+),

[PATCH 20/21] ACPI / PM: Drop legacy driver PM callbacks that are not used any more

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Since the legacy ACPI driver PM callbacks included into struct acpi_device_ops are not used any more, drop them. Signed-off-by: Rafael J. Wysocki --- include/acpi/acpi_bus.h |4 1 file changed, 4 deletions(-) Index: linux/include/acpi/acpi_bus.h ==

[PATCH 21/21] ACPI / PM: Drop PM callbacks from the ACPI bus type

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Since the ACPI bus type's PM callbacks only execute the driver ones without doing anything else, they can be dropped, because the driver callbacks will be executed by the PM core directly if bus type (or other subsystem) callbacks are not present. Signed-off-by: Rafael J.

[PATCH 11/21] ACPI: Use struct dev_pm_ops for power management in the SBS driver

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the ACPI Smart Battery System driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/sbs.c | 10 ++ 1 file changed, 6 insertions(+

[PATCH 6/21] ACPI: Use struct dev_pm_ops for power management in processor driver

2012-06-23 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Make the ACPI processor driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct acpi_device_ops. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/processor_driver.c |6 -- drivers/acpi/processor_idle.c

[PATCH 0/21] ACPI / PM: Switch ACPI bus type and drivers to dev_pm_ops

2012-06-23 Thread Rafael J. Wysocki
Hi all, The following patchset converts the ACPI bus type and all of the ACPI drivers to the power management handling based on struct dev_pm_ops. It does that in the following way: (1) The (unused) pm_message_t argument is dropped from the ACPI driver suspend callback throughout the tree (p