Re: [PATCH 1/2] samsung-laptop: Add broken-acpi-video quirk for NC210/NC110

2014-10-21 Thread Darren Hart
On Thu, Oct 16, 2014 at 02:36:30PM +0200, Hans de Goede wrote: Hi Hans, Apoligies for the late response, travel and illness are taking their toll. > Reported (and tested) here: > https://bugzilla.redhat.com/show_bug.cgi?id=861573 The patch header is required to be sufficient to describe the pro

Re: [PATCH 2/2] acer-wmi: Add acpi_backlight=video quirk for the Acer KAV80

2014-10-21 Thread Darren Hart
On Thu, Oct 16, 2014 at 02:36:31PM +0200, Hans de Goede wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1128309 Hi Hans, As with 1/2, the content is fine, but please take the time to provide enough context in the commit log that a reader of git log can understand what is going on without req

Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

2014-10-21 Thread Darren Hart
On Sat, Oct 18, 2014 at 12:13:23AM +0300, Jani Nikula wrote: > Documentation/kbuild/kconfig-language.txt warns to use select with care, > and in general use select only for non-visible symbols and for symbols > with no dependencies, because select will force a symbol to a value > without visiting t

Re: [PATCH] drivers: platform: change 0x20 to I8042_STR_AUXDATA in i8042 filters

2014-10-21 Thread Darren Hart
On Sat, Oct 18, 2014 at 02:57:20AM +0300, Giedrius Statkevicius wrote: > From: Giedrius Statkevičius > > Instead of using a magic constant 0x20 in some drivers to get data only > from the KBC port we should use the constant defined in i8042.h with > the same value. Also, this makes these drivers

Re: [PATCH] dell-wmi: Update code for processing WMI events

2014-10-21 Thread Darren Hart
On Tue, Oct 21, 2014 at 12:15:24AM +0200, Pali Rohár wrote: > WMI buffer can contains more events. First value in buffer is length of event > followed by data of specified length. After that is next length and next data. > When length is zero then there is no more events in bufffer. > > This patch

Re: [PATCH RFC] platform: hp_accel: add a i8042 filter to remove accelerometer data

2014-10-21 Thread Darren Hart
On Sat, Oct 18, 2014 at 11:59:22PM +0300, Giedrius Statkevicius wrote: > Hello, Hi Giedrius, > this patch fixes bug #84941 from the kernel bugzilla. Basically, it > seems that the accelerometer sends some signals as button presses > through the keyboard bus. The keys in the report are 0xa5-0xa8 b