Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

2014-10-22 Thread Tomi Valkeinen
On 18/10/14 00:13, Jani Nikula wrote: Documentation/kbuild/kconfig-language.txt warns to use select with care, and in general use select only for non-visible symbols and for symbols with no dependencies, because select will force a symbol to a value without visiting the dependencies. Select

Re: [PATCH] dell-wmi: Update code for processing WMI events

2014-10-22 Thread Pali Rohár
On Tuesday 21 October 2014 23:32:12 Darren Hart wrote: On Tue, Oct 21, 2014 at 12:15:24AM +0200, Pali Rohár wrote: WMI buffer can contains more events. First value in buffer is length of event followed by data of specified length. After that is next length and next data. When length is

[PATCH] asus-nb-wmi: Add wapf4 quirk for the X550VB

2014-10-22 Thread Stanislaw Gruszka
As reported here: http://bugzilla.redhat.com/show_bug.cgi?id=1089731#c23 the X550VB needs wapf=4 too. Signed-off-by: Stanislaw Gruszka sgrus...@redhat.com --- drivers/platform/x86/asus-nb-wmi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c

Re: [PATCH RFC] platform: hp_accel: add a i8042 filter to remove accelerometer data

2014-10-22 Thread Giedrius Statkevicius
On 2014.10.22 00:45, Darren Hart wrote: On Sat, Oct 18, 2014 at 11:59:22PM +0300, Giedrius Statkevicius wrote: Hello, Hi Giedrius, this patch fixes bug #84941 from the kernel bugzilla. Basically, it seems that the accelerometer sends some signals as button presses through the keyboard

Re: [PATCH RFC] platform: hp_accel: add a i8042 filter to remove accelerometer data

2014-10-22 Thread Éric Piel
On 22/10/14 15:20, Giedrius Statkevicius wrote: : My questions are these: - Does any system with the accelerometer whose ACPI id is HPQ0004 or HPQ6007 run into the same issues? - If so, what are the scancodes reported by atkbd? - If not, then where can I find some documentation to find

Re: [PATCH RFC] platform: hp_accel: add a i8042 filter to remove accelerometer data

2014-10-22 Thread Giedrius Statkevicius
On 2014.10.22 17:19, Éric Piel wrote: On the HP laptop I had (with HPQ0004), no fake keys were reported. I guess this is a new feature, then. It should be noted that on my laptop, the accelerometer is completely decoupled from the hard disk. For example, when freefall is detected, nothing

[PATCH 6/8] eeepc-laptop: replace magic numbers with defines

2014-10-22 Thread Frans Klaver
eeepc_[gs]et_fan_ctrl uses some magic numbers. These numbers mean something more than just the number. Describe them with macros instead of comments in one of the functions. Signed-off-by: Frans Klaver franskla...@gmail.com --- drivers/platform/x86/eeepc-laptop.c | 16 ++-- 1 file

[PATCH 8/8] eeepc-laptop: don't assume get_acpi succeeds

2014-10-22 Thread Frans Klaver
In eeepc_hotk_thaw, we assume that get_acpi() will effectively return a bool. However, it is possible that get_acpi() returns an error instead. We should not be writing error values to the ACPI device, even though it's quite possible that we couldn't contact the ACPI device in the first place.

[PATCH 3/8] eeepc-laptop: define rfkill notifier nodes only once

2014-10-22 Thread Frans Klaver
The rfkill notifier node names are used in three different places. As a matter of style, it is better to store them somewhere and have the compiler warn us about typos in the function arguments. Signed-off-by: Frans Klaver franskla...@gmail.com --- drivers/platform/x86/eeepc-laptop.c | 22