Hi again,
Peter Feuerer writes:
Hi Darren,
thank you very much for your reply.
Darren Hart writes:
On Fri, Nov 28, 2014 at 03:20:50PM +0100, Peter Feuerer wrote:
acerhdf has been doing an on-off fan control using hysteresis by
post-manipulating the outcome of thermal subsystem trip point
Hi Darren,
thank you very much for your reply.
Darren Hart writes:
On Fri, Nov 28, 2014 at 03:20:50PM +0100, Peter Feuerer wrote:
acerhdf has been doing an on-off fan control using hysteresis by
post-manipulating the outcome of thermal subsystem trip point handling.
This patch enables acerhd
Sorry for late reply. A few other tasks occupied my time.
Method(ARBT) is defined to enable/disable BIOS handling the radio,
where 1 is enable and 0 is disable, for your information.
However, I checked Latitude E5440, and its ARBT is empty such as
Method (ARBT, 1, NotSerialized)
{
}
This matche
The hotkey enabling code is being used by toshiba_acpi_setup_keyboard
and also by toshiba_acpi_resume.
This patch creates a new function called toshiba_acpi_enable_hotkeys
to be used by these two functions to avoid duplicating code.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_a
Currently the function toshiba_acpi_notify only takes care of hotkeys,
however, the TOS devices receive more events that can be useful.
This patch changes the function to be able to handle more events,
and in the process, move all hotkey related code residing in it to
a new function called tos
These patches change the current code to accomodate the handling
of more events, since so far, it only handles hotkey events (0x80),
move the hotkey enabling code to a sub function to avoid duplication,
and add event 0x92 which indicates a change in the keyboard backlight
mode.
Changes since V1:
-
A previous patch added support to handle more events.
This patch adds support to update the sysfs group whenever we receive
a 0x92 event, which indicates a change in the keyboard backlight mode.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 13 +++--
1 file chang
On Tue, Dec 02, 2014 at 10:36:31PM -0700, Azael Avalos wrote:
> The hotkey enabling code is being used by
> *_setup_keyboard and also by *_resume.
>
> This patch creates a new function called
> toshiba_acpi_enable_hotkeys to be used by
> these two functions to avoid duplicating
> code.
42 is a li
On Tue, Dec 02, 2014 at 10:36:32PM -0700, Azael Avalos wrote:
> Currently the function toshiba_acpi_notify only
> takes care of hotkeys, however, the TOS
> devices receive more events that can be useful.
>
> This patch changes the function to be able to
> handle more events, and in the process
On Fri, Nov 28, 2014 at 03:20:51PM +0100, Peter Feuerer wrote:
> added critical trip point which represents the temperature limit.
Nitpic, Add ^
> Added return -EINVAL in case wrong trip point is provided.
Add (we are going to add it with this patch, it wasn't added previously). It's a
nitpic. B
On Fri, Nov 28, 2014 at 03:20:50PM +0100, Peter Feuerer wrote:
> acerhdf has been doing an on-off fan control using hysteresis by
> post-manipulating the outcome of thermal subsystem trip point handling.
> This patch enables acerhdf to use the bang-bang governor, which is
> intended for on-off cont
On Tue, Dec 02, 2014 at 04:08:58PM +0100, Gabriele Mazzotta wrote:
> On Tuesday 02 December 2014 12:06:45 Gabriele Mazzotta wrote:
> > On Thursday 27 November 2014 12:41:19 Alex Hung wrote:
> > > On Sun, Nov 23, 2014 at 8:52 AM, Pali Rohár wrote:
> > > > On Saturday 22 November 2014 03:09:06 Darre
On Sun, Nov 23, 2014 at 03:50:45PM +0100, Pali Rohár wrote:
> This patch adds support for configuring keyboard backlight settings on
> supported
> Dell laptops. It exports kernel leds interface and uses Dell SMBIOS tokens or
> keyboard class interface.
>
> With this patch it is possible to set:
>
On Wed, Dec 03, 2014 at 01:01:59PM +0300, Dan Carpenter wrote:
> The original code had a static checker warning:
>
> drivers/platform/x86/dell-laptop.c:1389 kbd_led_timeout_store()
> warn: this array is probably non-NULL. 'quirks->kbd_timeouts'
>
> This warning does indicate a bug. I
On Thursday 04 December 2014 00:16:23 Gabriele Mazzotta wrote:
> Keyboard illumination level changes are performed by the BIOS,
> so no events should be reported on keypress. This is already
> done on systems using the legacy keymap, do it also for
> systems that don't use it.
>
> Signed-off-by: G
The WMI events associated to KEY_WLAN are for all the radio devices
available. Use KEY_RFKILL instead since it's more appropriate.
Signed-off-by: Gabriele Mazzotta
---
drivers/platform/x86/dell-wmi.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/
Currently dell-wmi reports keypresses for WMI events that are
notifications of changes performed by the BIOS.
This patch series make sure that no keypresses are sent for those
events so that nothing is done from userspace.
Gabriele Mazzotta (3):
dell-wmi: Use appropriate keycode for radio state
The state of radio devices is changed directly by the BIOS when hotkeys
are pressed, so no events should be reported.
Signed-off-by: Gabriele Mazzotta
---
drivers/platform/x86/dell-wmi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/dell-wmi.c b/dr
Keyboard illumination level changes are performed by the BIOS, so no
events should be reported on keypress. This is already done on systems
using the legacy keymap, do it also for systems that don't use it.
Signed-off-by: Gabriele Mazzotta
---
drivers/platform/x86/dell-wmi.c | 11 ---
1
Hi Darren / platform-driver-x86 list,
Peter Feuerer writes:
please apply this series of patches.
did you find time for my patchseries already?
Is there any problem with it?
--
kind regards,
--peter;
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body
Add the documentation for the new sysfs interface of dell-laptop
that allows to configure the keyboard illumination on Dell systems.
Signed-off-by: Gabriele Mazzotta
Signed-off-by: Pali Rohár
---
.../ABI/testing/sysfs-platform-dell-laptop | 60 ++
1 file changed, 60
On Wednesday 03 December 2014 14:38:15 Gabriele Mazzotta wrote:
> On Wednesday 03 December 2014 14:24:11 Pali Rohár wrote:
> > On Wednesday 03 December 2014 14:12:54 Henrique de Moraes
> >
> > Holschuh wrote:
> > > On Wed, 03 Dec 2014, Pali Rohár wrote:
> > > > Ok, and what about KEY_KBDILLUMTOGGL
On Wednesday 03 December 2014 14:24:11 Pali Rohár wrote:
> On Wednesday 03 December 2014 14:12:54 Henrique de Moraes
>
> Holschuh wrote:
> > On Wed, 03 Dec 2014, Pali Rohár wrote:
> > > Ok, and what about KEY_KBDILLUMTOGGLE when bios also handle
> > > keyboard backlight level? Should be this key f
On Wednesday 03 December 2014 14:12:54 Henrique de Moraes
Holschuh wrote:
> On Wed, 03 Dec 2014, Pali Rohár wrote:
> > Ok, and what about KEY_KBDILLUMTOGGLE when bios also handle
> > keyboard backlight level? Should be this key filtered too?
>
> IME, heck yes.
>
> If you ever make the mistake of
On Wed, 03 Dec 2014, Pali Rohár wrote:
> Ok, and what about KEY_KBDILLUMTOGGLE when bios also handle
> keyboard backlight level? Should be this key filtered too?
IME, heck yes.
If you ever make the mistake of sending to userspace something the
BIOS/kernel already reacted to, they will find a way
On Wednesday 03 December 2014 13:40:42 Pavel Machek wrote:
> On Sun 2014-11-23 14:41:17, Pali Rohár wrote:
> > Hello,
> >
> > pressing some keys on laptops could cause some side effects.
> >
> > Example scenario 1:
> >
> > Laptop has Fn key for enabling/disabling WIFI and when that
> > key is pr
On Sun 2014-11-23 14:41:17, Pali Rohár wrote:
> Hello,
>
> pressing some keys on laptops could cause some side effects.
>
> Example scenario 1:
>
> Laptop has Fn key for enabling/disabling WIFI and when that key
> is pressed BIOS is doing two things:
>
> 1) Switch hard rfkill state of WIFI
> 2
The original code had a static checker warning:
drivers/platform/x86/dell-laptop.c:1389 kbd_led_timeout_store()
warn: this array is probably non-NULL. 'quirks->kbd_timeouts'
This warning does indicate a bug. I have added a .needs_kbd_timeouts
flag which is true if the .kbd_timeou
28 matches
Mail list logo
