On Sun, Nov 23, 2014 at 03:38:26AM +0100, Pali Rohár wrote:
> Oops, I lost this mail somewhere...
>
> I copied these ids from windows driver inf file. I did not tested
> them because I do not have machine which reports these ids. It
> looks like all SMOXX devices have same acpi structure (one IR
On Thu, Dec 04, 2014 at 08:22:44PM -0700, Azael Avalos wrote:
> These patches change the current code to accomodate the handling
> of more events, since so far, it only handles hotkey events (0x80),
> move the hotkey enabling code to a sub function to avoid duplication,
> and add event 0x92 which i
On Thu, Dec 04, 2014 at 12:16:20AM +0100, Gabriele Mazzotta wrote:
> Currently dell-wmi reports keypresses for WMI events that are
> notifications of changes performed by the BIOS.
> This patch series make sure that no keypresses are sent for those
> events so that nothing is done from userspace.
A previous patch added support to handle more events.
This patch adds support to update the sysfs group whenever we receive
a 0x92 event, which indicates a change in the keyboard backlight mode,
removing the update group code from toshiba_kbd_bl_mode_store, as it is
no longer needed there.
Signed
Currently the function toshiba_acpi_notify only takes care of hotkeys,
however, the TOS devices receive more events that can be useful.
This patch changes the function to be able to handle more events,
and in the process, move all hotkey related code residing in it to
a new function called tos
The hotkey enabling code is being used by
*_setup_keyboard and also by *_resume.
This patch creates a new function called
toshiba_acpi_enable_hotkeys to be used by
these two functions to avoid duplicating
code.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 40 +++
These patches change the current code to accomodate the handling
of more events, since so far, it only handles hotkey events (0x80),
move the hotkey enabling code to a sub function to avoid duplication,
and add event 0x92 which indicates a change in the keyboard backlight
mode.
Changes since V3:
-
On Thu, Dec 04, 2014 at 08:10:49PM -0700, Azael Avalos wrote:
> Hi Darren,
>
> 2014-12-03 6:12 GMT-07:00 Darren Hart :
> > On Wed, Dec 03, 2014 at 11:42:04PM -0700, Azael Avalos wrote:
> >> @@ -1971,41 +2008,22 @@ error:
> >> static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event
On Wed, Dec 03, 2014 at 06:41:33PM +0100, Gabriele Mazzotta wrote:
> Add the documentation for the new sysfs interface of dell-laptop
> that allows to configure the keyboard illumination on Dell systems.
>
> Signed-off-by: Gabriele Mazzotta
> Signed-off-by: Pali Rohár
If nobody else would prefe
Hi Darren,
2014-12-03 6:12 GMT-07:00 Darren Hart :
> On Wed, Dec 03, 2014 at 11:42:04PM -0700, Azael Avalos wrote:
>> @@ -1971,41 +2008,22 @@ error:
>> static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event)
>> {
>> struct toshiba_acpi_dev *dev = acpi_driver_data(acpi_dev)
On Wed, Dec 03, 2014 at 11:42:04PM -0700, Azael Avalos wrote:
> @@ -1971,41 +2008,22 @@ error:
> static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event)
> {
> struct toshiba_acpi_dev *dev = acpi_driver_data(acpi_dev);
> - u32 hci_result, value;
> - int retries = 3;
On Thu, Dec 04, 2014 at 10:55:32AM +0100, Pali Rohár wrote:
>
> Darren, I think that if we do not solve problem with duplicate
> key events (in dell-wireless.c) we should postpone these patches
> to later kernel version. It is better to not have such regression
> as it confuse software like Net
On Thu, Dec 04, 2014 at 04:16:25PM +0800, Alex Hung wrote:
> HI Darren and Pali,
>
> It was great that we had a lot of discussion but it seems Dell BIOS
> implementation varies from one series to another. Both work looks good
> either one is fine with me.
>
> But I think I can do a little more: I
On Fri, Dec 05, 2014 at 03:03:49AM +0100, Pali Rohár wrote:
> On Wednesday 03 December 2014 09:43:21 Darren Hart wrote:
> > On Sun, Nov 23, 2014 at 03:50:45PM +0100, Pali Rohár wrote:
> > > This patch adds support for configuring keyboard backlight
> > > settings on supported Dell laptops. It expor
On Thu, Dec 04, 2014 at 11:16:47AM +0100, Pali Rohár wrote:
> > > seconds not supported). + cbRES4, byte1 Maximum
> > > acceptable minutes value (0 if minutes not supported). +
> > > cbRES4, byte2 Maximum acceptable hours value (0 if hours
> > > not supported). + cbRES4, byte3 Maxiomum accept
On Wednesday 03 December 2014 09:43:21 Darren Hart wrote:
> On Sun, Nov 23, 2014 at 03:50:45PM +0100, Pali Rohár wrote:
> > This patch adds support for configuring keyboard backlight
> > settings on supported Dell laptops. It exports kernel leds
> > interface and uses Dell SMBIOS tokens or keyboard
On Wednesday 03 December 2014 12:51:37 Darren Hart wrote:
> On Thu, Dec 04, 2014 at 09:50:02AM +0100, Gabriele Mazzotta
wrote:
> > On Wednesday 03 December 2014 00:43:21 Darren Hart wrote:
> > > > + int kbd_timeouts[];
> > > >
> > > > };
> > > >
> > > > static struct quirk_entry *quirks;
On Thu, Dec 04, 2014 at 09:50:02AM +0100, Gabriele Mazzotta wrote:
> On Wednesday 03 December 2014 00:43:21 Darren Hart wrote:
> > > + int kbd_timeouts[];
> > >
> > > };
> > >
> > > static struct quirk_entry *quirks;
> > >
> > > @@ -76,6 +89,10 @@ static int __init dmi_matched(const struct
On Thursday 04 December 2014 10:42:37 Pali Rohár wrote:
> On Wednesday 03 December 2014 08:33:25 Darren Hart wrote:
> > On Wed, Dec 03, 2014 at 01:01:59PM +0300, Dan Carpenter wrote:
> > > The original code had a static checker warning:
> > > drivers/platform/x86/dell-laptop.c:1389
> > > kbd_le
On Wednesday 03 December 2014 09:43:21 Darren Hart wrote:
> On Sun, Nov 23, 2014 at 03:50:45PM +0100, Pali Rohár wrote:
> > This patch adds support for configuring keyboard backlight
> > settings on supported Dell laptops. It exports kernel leds
> > interface and uses Dell SMBIOS tokens or keyboard
Thanks for info!
Do you know if Latitude E5440 has Fn wifi key or HW switch?
My Latitude E6440 has only HW switch and ARBT is empty too.
On Thursday 04 December 2014 07:52:21 Alex Hung wrote:
> Sorry for late reply. A few other tasks occupied my time.
>
> Method(ARBT) is defined to enable/disab
On Thursday 04 December 2014 09:16:25 Alex Hung wrote:
> HI Darren and Pali,
>
> It was great that we had a lot of discussion but it seems Dell
> BIOS implementation varies from one series to another. Both
> work looks good either one is fine with me.
>
Alex, am I right that your dell-wireless.c
On Wednesday 03 December 2014 08:33:25 Darren Hart wrote:
> On Wed, Dec 03, 2014 at 01:01:59PM +0300, Dan Carpenter wrote:
> > The original code had a static checker warning:
> > drivers/platform/x86/dell-laptop.c:1389
> > kbd_led_timeout_store() warn: this array is probably
> > non-NUL
On Wednesday 03 December 2014 00:43:21 Darren Hart wrote:
> > + int kbd_timeouts[];
> >
> > };
> >
> > static struct quirk_entry *quirks;
> >
> > @@ -76,6 +89,10 @@ static int __init dmi_matched(const struct
> > dmi_system_id *dmi)>
> > return 1;
> > }
> >
> >
> > +static struct qu
On Tue, Dec 02, 2014 at 11:33:25PM -0800, Darren Hart wrote:
>
> Dan, any objection to Pali rolling this into another revision?
No problem, that's fine.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to majord...
HI Darren and Pali,
It was great that we had a lot of discussion but it seems Dell BIOS
implementation varies from one series to another. Both work looks good
either one is fine with me.
But I think I can do a little more: I am collecting a number of
systems to try out these patches. This should
26 matches
Mail list logo
