Re: [PATCH v3 28/35] msi-laptop: Port to new backlight interface selection API

2015-06-17 Thread joeyli
On Tue, Jun 16, 2015 at 04:28:06PM +0200, Hans de Goede wrote: > Port the backlight selection logic to the new backlight interface > selection API. > > This commit also removes various obsolete pr_xxx messages related to > backlight interface selection. These are obsolete because they assume > the

Re: [PATCH 19/22] fjes: update_zone_task

2015-06-17 Thread Joe Perches
On Thu, 2015-06-18 at 09:49 +0900, Taku Izumi wrote: > This patch adds update_zone_task. > diff --git a/drivers/platform/x86/fjes/fjes_hw.c > b/drivers/platform/x86/fjes/fjes_hw.c [] > +static void fjes_hw_update_zone_task(struct work_struct *work) > +{ Some of the line length can be removed her

Re: [PATCH 02/22] fjes: Hardware initialization routine

2015-06-17 Thread Joe Perches
On Thu, 2015-06-18 at 09:49 +0900, Taku Izumi wrote: > This patch adds hardware initialization routine to be > invoked at driver's .probe routine. Trivial notes: Please run all your patches through scripts/checkpatch.pl and fix whatever messages it emits as you think appropriate. > diff --git a/

Re: [PATCH 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver

2015-06-17 Thread Joe Perches
On Thu, 2015-06-18 at 09:49 +0900, Taku Izumi wrote: > This patch adds the basic code of FUJITSU Extended Socket > Network Device driver. [] > diff --git a/drivers/platform/x86/fjes/fjes_main.c > b/drivers/platform/x86/fjes/fjes_main.c [] > +static acpi_status fjes_get_acpi_resource(struct acpi_re

Re: [PATCH 22/22] fjes: ethtool support

2015-06-17 Thread Stephen Hemminger
On Thu, 18 Jun 2015 09:49:47 +0900 Taku Izumi wrote: > +static void fjes_get_ethtool_stats(struct net_device *netdev, > + struct ethtool_stats *stats, u64 *data) > +{ > + struct fjes_adapter *adapter = netdev_priv(netdev); > + int i; > + char *p = NULL; Although harmless,

[PATCH 07/22] fjes: net_device_ops.ndo_open and .ndo_stop

2015-06-17 Thread Taku Izumi
This patch adds net_device_ops.ndo_open and .ndo_stop callback. These function is called when network device activation and deactivation. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes.h | 2 +- drivers/platform/x86/fjes/fjes_hw.c | 150 drivers/platfo

[PATCH 06/22] fjes: buffer address regist/unregistration routine

2015-06-17 Thread Taku Izumi
This patch adds buffer address regist/unregistration routine. This function is mainly invoked when network device's activation (open) and deactivation (close) in order to retist/unregist shared buffer address. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 189 +

[PATCH 15/22] fjes: net_device_ops.ndo_vlan_rx_add/kill_vid

2015-06-17 Thread Taku Izumi
This patch adds net_device_ops.ndo_vlan_rx_add_vid and net_device_ops.ndo_vlan_rx_kill_vid callback. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 27 +++ drivers/platform/x86/fjes/fjes_hw.h | 2 ++ drivers/platform/x86/fjes/fjes_main.c | 40 +++

[PATCH 13/22] fjes: net_device_ops.ndo_change_mtu

2015-06-17 Thread Taku Izumi
This patch adds net_device_ops.ndo_change_mtu. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_main.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/platform/x86/fjes/fjes_main.c b/drivers/platform/x86/fjes/fjes_main.c index eeda824..725

[PATCH 12/22] fjes: net_device_ops.ndo_get_stats64

2015-06-17 Thread Taku Izumi
This patch adds net_device_ops.ndo_get_stats64 callback. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_main.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/platform/x86/fjes/fjes_main.c b/drivers/platform/x86/fjes/fjes_main.c index 97bf487..eeda824 1

[PATCH 14/22] fjes: net_device_ops.ndo_tx_timeout

2015-06-17 Thread Taku Izumi
This patch adds net_device_ops.ndo_tx_timeout callback. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/fjes/fjes_main.c b/drivers/platform/x86/fjes/fjes_main.c index 72541a7..84727d8 100644 --

[PATCH 09/22] fjes: raise_intr_rxdata_task

2015-06-17 Thread Taku Izumi
This patch add raise_intr_rxdata_task. Extended Socket Network Device is shared memory based, so someone's transmission denotes other's reception. In order to notify receivers, sender has to raise interruption of receivers. raise_intr_rxdata_task does this work. Signed-off-by: Taku Izumi --- dr

[PATCH 16/22] fjes: interrupt_watch_task

2015-06-17 Thread Taku Izumi
This patch adds interrupt_watch_task. This task is used to prevent delay of interrupts. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes.h | 5 + drivers/platform/x86/fjes/fjes_main.c | 40 ++- 2 files changed, 44 insertions(+), 1 deletion(-)

[PATCH 08/22] fjes: net_device_ops.ndo_start_xmit

2015-06-17 Thread Taku Izumi
This patch adds net_device_ops.ndo_start_xmit callback, which is called when sending packets. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes.h | 1 + drivers/platform/x86/fjes/fjes_hw.c | 58 +++ drivers/platform/x86/fjes/fjes_hw.h | 12 +++ drivers/platform/x8

[PATCH 10/22] fjes: tx_stall_task

2015-06-17 Thread Taku Izumi
This patch adds tx_stall_task. When receiver's buffer is full, sender stops its tx queue. This task is used to monitor receiver's status and when receiver's buffer is avairable, it resumes tx queue. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes.h | 2 ++ drivers/platform/x86

[PATCH 17/22] fjes: force_close_task

2015-06-17 Thread Taku Izumi
This patch adds force_close_task. This task is used to close network device forcibly. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes.h | 1 + drivers/platform/x86/fjes/fjes_main.c | 13 + 2 files changed, 14 insertions(+) diff --git a/drivers/platform/x86/fjes/fj

[PATCH 20/22] fjes: epstop_task

2015-06-17 Thread Taku Izumi
This patch adds epstop_task. This task is used to process other receiver's cancellation request. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 34 ++ drivers/platform/x86/fjes/fjes_hw.h | 1 + drivers/platform/x86/fjes/fjes_main.c | 1 +

[PATCH 11/22] fjes: NAPI polling function

2015-06-17 Thread Taku Izumi
This patch adds NAPI polling function and receive related work. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 46 + drivers/platform/x86/fjes/fjes_hw.h | 6 ++ drivers/platform/x86/fjes/fjes_main.c | 179 ++ 3 files changed, 23

[PATCH 21/22] fjes: handle receive cancellation request interrupt

2015-06-17 Thread Taku Izumi
This patch adds implementation of handling IRQ of other receiver's receive cancellation request. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_main.c | 85 +++ 1 file changed, 85 insertions(+) diff --git a/drivers/platform/x86/fjes/fjes_main.c b/d

[PATCH 22/22] fjes: ethtool support

2015-06-17 Thread Taku Izumi
This patch adds implementation for ethtool support. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/Makefile | 2 +- drivers/platform/x86/fjes/fjes.h | 2 + drivers/platform/x86/fjes/fjes_ethtool.c | 135 +++ drivers/platform/x86/fjes/fjes_ma

[PATCH 18/22] fjes: unshare_watch_task

2015-06-17 Thread Taku Izumi
This patch adds unshare_watch_task. Shared buffer's status can be changed into unshared. This task is used to monitor shared buffer's status. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes.h | 3 + drivers/platform/x86/fjes/fjes_main.c | 152

[PATCH 19/22] fjes: update_zone_task

2015-06-17 Thread Taku Izumi
This patch adds update_zone_task. Zoning information can be changed by user. This task is used to monitor if zoning information is changed or not. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 183 ++ drivers/platform/x86/fjes/fjes_hw.h

[PATCH 04/22] fjes: platform_driver's .probe and .remove routine

2015-06-17 Thread Taku Izumi
This patch implements platform_driver's .probe and .remove routine, and also adds board specific private data structure. This driver registers net_device at platform_driver's .probe routine and unregisters net_device at its .remove routine. Signed-off-by: Taku Izumi --- drivers/platform/x86/fje

[PATCH 02/22] fjes: Hardware initialization routine

2015-06-17 Thread Taku Izumi
This patch adds hardware initialization routine to be invoked at driver's .probe routine. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/Makefile| 2 +- drivers/platform/x86/fjes/fjes_hw.c | 305 ++ drivers/platform/x86/fjes/fjes_hw.h | 254

[PATCH 05/22] fjes: ES information acquisition routine

2015-06-17 Thread Taku Izumi
This patch adds ES information acquisition routine. ES information can be retrieved issuing information request command. ES information includes which receiver is same zone. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 101 ++ drivers/plat

[PATCH 03/22] fjes: Hardware cleanup routine

2015-06-17 Thread Taku Izumi
This patch adds hardware cleanup routine to be invoked at driver's .remove routine. Signed-off-by: Taku Izumi --- drivers/platform/x86/fjes/fjes_hw.c | 66 + drivers/platform/x86/fjes/fjes_hw.h | 1 + 2 files changed, 67 insertions(+) diff --git a/drivers/pl

[PATCH 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver

2015-06-17 Thread Taku Izumi
This patch adds the basic code of FUJITSU Extended Socket Network Device driver. When "PNP0C02" is found in ACPI DSDT, it evaluates "_STR" to check if "PNP0C02" is for Extended Socket device driver and retrieves ACPI resource information. Then creates platform_device. Signed-off-by: Taku Izumi -

[PATCH 00/22] FUJITSU Extended Socket network device driver

2015-06-17 Thread Taku Izumi
This patchsets adds FUJITSU Extended Socket network device driver. Extended Socket network device is a shared memory based high-speed network interface between Extended Partitions of PRIMEQUEST 2000 E2 series. You can get some information about Extended Partition and Extended Socket by referring

Re: [PATCH v2 00/32] acpi-video: Rewrite backlight interface selection logic

2015-06-17 Thread Rafael J. Wysocki
On Wed, Jun 17, 2015 at 5:39 AM, Darren Hart wrote: > On Tue, Jun 16, 2015 at 01:22:40AM +0200, Rafael Wysocki wrote: >> On Friday, June 12, 2015 01:23:19 PM Hans de Goede wrote: >> > Hi All, >> > >> > Here is v2 of my rewrite / cleanup of the acpi-video (and platform/x86) >> > backlight interface

Re: Possible broken MM code in dell-laptop.c?

2015-06-17 Thread Michal Hocko
On Tue 16-06-15 20:43:34, Darren Hart wrote: [...] > Michal - thanks for the context. > > I'm surprised by your recommendation to use __free_page() out here in platform > driver land. > > I'd also prefer that the driver consistently free the same address to avoid > confusion. > > For these reaso