[PATCH] thermal: consistently use int for temperatures

2015-07-06 Thread Sascha Hauer
The thermal code uses int, long and unsigned long for temperatures in different places. Using an unsigned type limits the thermal framework to positive temperatures without need. Also several drivers currently will report temperatures near UINT_MAX for temperatures below 0°C. This will probably im

Re: [PATCH] thermal: consistently use int for temperatures

2015-07-06 Thread Geert Uytterhoeven
On Mon, Jul 6, 2015 at 9:19 AM, Sascha Hauer wrote: > The thermal code uses int, long and unsigned long for temperatures > in different places. > > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > temperatures

Re: [PATCH 3/3] dell-laptop: Do not cache hwswitch state

2015-07-06 Thread Pali Rohár
On Thursday 02 July 2015 02:42:04 Darren Hart wrote: > On Wed, Jul 01, 2015 at 08:08:21PM +0200, Pali Rohár wrote: > > It can be changed at runtime so make sure that dell-laptop knows > > always current state. It can be modified by userspace utility > > smbios-wireless-ctl. > > > > Signed-off-by:

[PATCH v2 3/3] dell-laptop: Do not cache hwswitch state

2015-07-06 Thread Pali Rohár
It can be changed at runtime so make sure that dell-laptop knows always current state. It can be modified by userspace utility smbios-wireless-ctl. Signed-off-by: Pali Rohár --- drivers/platform/x86/dell-laptop.c | 85 ++-- 1 file changed, 61 insertions(+), 24 d

[PATCH v2 1/3] dell-laptop: Clear buffer before each SMBIOS call

2015-07-06 Thread Pali Rohár
Make sure that before initializing SMBIOS call input buffer does not contain any garbage (e.g. values from previous SMBIOS call). This fix problem with passing undefined/random parameters to SMBIOS functions. Signed-off-by: Pali Rohár --- drivers/platform/x86/dell-laptop.c | 11 ++- 1

[PATCH v2 2/3] dell-laptop: Check return value of each SMBIOS call

2015-07-06 Thread Pali Rohár
Make sure that return value of each SMBIOS call is properly checked and do not continue of processing (received) information if call failed. Signed-off-by: Pali Rohár --- drivers/platform/x86/dell-laptop.c | 83 +--- 1 file changed, 58 insertions(+), 25 deletion

Re: [PATCH] thermal: consistently use int for temperatures

2015-07-06 Thread Jean Delvare
On Mon, 6 Jul 2015 09:19:49 +0200, Sascha Hauer wrote: > The thermal code uses int, long and unsigned long for temperatures > in different places. > > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > temperat

Re: [PATCH] thermal: consistently use int for temperatures

2015-07-06 Thread Lukasz Majewski
Hi Sascha, > The thermal code uses int, long and unsigned long for temperatures > in different places. > > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > temperatures near UINT_MAX for temperatures below 0°

Re: [PATCH] thermal: consistently use int for temperatures

2015-07-06 Thread Darren Hart
On Mon, Jul 06, 2015 at 09:19:49AM +0200, Sascha Hauer wrote: > The thermal code uses int, long and unsigned long for temperatures > in different places. > > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > te

Re: [PATCH] thermal: consistently use int for temperatures

2015-07-06 Thread Heiko Stübner
Am Montag, 6. Juli 2015, 09:19:49 schrieb Sascha Hauer: > The thermal code uses int, long and unsigned long for temperatures > in different places. > > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > temperat

Re: [PATCH v2 06/22] fjes: buffer address regist/unregistration routine

2015-07-06 Thread Yasuaki Ishimatsu
On Wed, 24 Jun 2015 11:55:38 +0900 Taku Izumi wrote: > This patch adds buffer address regist/unregistration routine. > > This function is mainly invoked when network device's > activation (open) and deactivation (close) > in order to retist/unregist shared buffer address. registe

Re: [PATCH v2 1/3] dell-laptop: Clear buffer before each SMBIOS call

2015-07-06 Thread Darren Hart
On Mon, Jul 06, 2015 at 12:08:55PM +0200, Pali Rohár wrote: > Make sure that before initializing SMBIOS call input buffer does not > contain any garbage (e.g. values from previous SMBIOS call). This fix > problem with passing undefined/random parameters to SMBIOS functions. > > Signed-off-by: Pali

Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8

2015-07-06 Thread Darren Hart
On Mon, Jul 06, 2015 at 09:35:40AM +0800, Alex Hung wrote: > ATK4001 is an ACPI device for wireless hotkey, similar to how Dell and > HP are doing it. It is just ASUS who decides LED should be controlled > by software unlike HP whose LED is driven by hardware pins on mini > card. Alex, please ref