RE: [PATCH v2] thermal: consistently use int for temperatures

2015-07-21 Thread Zhang, Rui
> -Original Message- > From: Punit Agrawal [mailto:punit.agra...@arm.com] > Sent: Tuesday, July 21, 2015 6:52 PM > To: Sascha Hauer > Cc: linux...@vger.kernel.org; Zhang, Rui; Eduardo Valentin; linux- > ker...@vger.kernel.org; Jean Delvare; Peter Feuerer; Heiko Stuebner; > Lukasz Majewski

Re: [PATCH v2] thermal: consistently use int for temperatures

2015-07-21 Thread Punit Agrawal
Hi Sascha, Sascha Hauer writes: > The thermal code uses int, long and unsigned long for temperatures > in different places. > > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > temperatures near UINT_MAX for

Re: Incorrect key code parsing in dell-wmi.c since 5ea2559

2015-07-21 Thread Pali Rohár
On Saturday 04 July 2015 19:06:48 Pali Rohár wrote: > Hello, > > I found another problem in dell-wmi.c code which is still partially in > mainline kernel since commit 5ea2559726b786283236835dc2905c23b36ac91c: > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5ea2559726

Re: [PATCH] thermal: consistently use int for temperatures

2015-07-21 Thread Sascha Hauer
Hi Punit, On Fri, Jul 17, 2015 at 12:14:36PM +0100, Punit Agrawal wrote: > Hi Sascha, > > Sascha Hauer writes: > > > The thermal code uses int, long and unsigned long for temperatures > > in different places. > > > > Using an unsigned type limits the thermal framework to positive > > temperatur

[PATCH v2] thermal: consistently use int for temperatures

2015-07-21 Thread Sascha Hauer
The thermal code uses int, long and unsigned long for temperatures in different places. Using an unsigned type limits the thermal framework to positive temperatures without need. Also several drivers currently will report temperatures near UINT_MAX for temperatures below 0°C. This will probably im