abled, but toggle key disabled wifi)
c 1 0 N/A (invalid state)
d 1 1 1
State "a" is where we are failing currently I believe?
Do we know if DELRBTN and DELLABCE are always a TOGGLE or a SLIDER respectively?
I'm wondering if these should be separate drivers.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
device in DSDT.dsl and paste it here please.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
_info() and stop telling people
> > to report it to IBM.
>
> IBM? Those reports go directly to me.
>
> > Signed-off-by: David Herrmann <dh.herrm...@gmail.com>
>
> Acked-by: Henrique de Moraes Holschuh <h...@hmh.eng.br>
Thanks, Queued.
--
Darren Hart
Intel Open S
Qipeng, can you comment on my understanding of the DSDT and the driver?
On Wed, Oct 14, 2015 at 10:16:06PM -0700, Darren Hart wrote:
> On Sat, Oct 10, 2015 at 03:07:53AM +, Zha, Qipeng wrote:
> >
> > >Everything is quite okay, except this BAR thingy.
> >
> > &
an you take a look at this bug report regarding a 4.2 regression for rfkill
after the introduction of the dell-rbtn driver please.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message
umer, Level, ActiveLow, Exclusive, ,
> > > ,
> > > ) {40} // IPC1 IRQ
> > > })
> > >
> > > …
> > > }
> > > }//end scope
> >
>
> --
> Andy Shevchenko <andriy.shevche...@intel.com>
commit message (suggested by Darren)
> - leave only fix of a potential bug in patch 5
Thank you Andy, queued to testing.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to ma
hanks,
> IO (Decode16, 0x400, 0x480, 0x4, 0x80) // ACPI IO
> Base address
> Interrupt (ResourceConsumer, Level, ActiveLow, Exclusive, , , ) {40}
> // IPC1 IRQ
> })
>
> …
> }
> }//end scope
--
Darren Hart
Intel Open
On Sun, Oct 11, 2015 at 09:12:54AM -0300, Henrique de Moraes Holschuh wrote:
> On Sat, 10 Oct 2015, Darren Hart wrote:
> > The Lenovo ThinkPad Yogo 12 has a button on the side by the power and volume
> > keys with a padlock icon on it, I presume intended to be used as Screenlock.
&g
On Sat, Oct 10, 2015 at 11:41:47AM -0700, Darren Hart wrote:
> From: Darren Hart <dvh...@infradead.org>
>
> thinkpad_acpi reports "unhandled HKEY event 0x60c0" when switching
> between laptop and tent/tablet mode on the ThinkPad Yoga 12. This key is
> reported b
es, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
intel_mid_identify_cpu();
> - if (platform == 0)
> - return -ENODEV;
> - return pci_register_driver(_driver);
> -}
> -
> -static void __exit intel_scu_ipc_exit(void)
> -{
> - pci_unregister_driver(_driver);
> -}
> +module_pci_driver(ipc_driver);
>
> MODULE_AUTHOR(&
> >
> > While here, protect dev member assignment in ->remove() since user
> > may
> > potentially call unbind from sysfs even if driver is built-in.
>
> This part is still right.
OK.
With my minor comment to 1/5 and this change, care to send a v2?
--
Darren
On Sat, Oct 10, 2015 at 06:40:34PM -0300, Henrique de Moraes Holschuh wrote:
> On Sat, 10 Oct 2015, Darren Hart wrote:
> > On Sat, Oct 10, 2015 at 11:41:47AM -0700, Darren Hart wrote:
> > > From: Darren Hart <dvh...@infradead.org>
> > >
> > > thinkpad
instead (as a
hotkey).
Is this a keymap change candidate? If so, How do I map 0x6020 to a scancode?
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to majord...@vger.kernel.org
More
t;intel_scu_ipc", ))
> - return -EBUSY;
> + err = devm_request_irq(>dev, dev->irq, ioc, 0, "intel_scu_ipc",
You switched to using pci_name(dev) above, seems to me the same rationale should
apply here. Any reason not to use pci_name(dev) here instead of "i
ems to be the latest I have from you and checkpatch still reports
several basic coding style errors about comment blocks and comparison constant
location.
See my response to v1 regarding that on Sep 18.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send
it function.
An acpidump would be good to see, along with the couple minor changes requested.
I want this to get into next sooner rather than later, so I'm queueing to
testing today. If we could get the next rev and the acpidump out soon, we can
get to linux-next this weekend which would be ideal for
size, pdev->name)) {
> > + dev_err(>dev, "Failed to request iomem
> > resouce\n");
> > + return -EBUSY;
> > + }
> > +
> > + res1 = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> > + if (!res1) {
> > +
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.ha...@samsung.com>
[dvhart: clarify commit msg, drop superfluous else block]
Signed-off-by: Darren Hart <dvh...@linux.intel.com>
See below for an additional change.
> ---
> Hi,
>
&g
e it or act on it
> > differently ;)
> >
> >
>
> Thanks for your patch and it reminds me to remove those interfaces in
> acer-wmi.
> Please let me check and I am thinking direct remove those interfaces.
Joey, I will wait to hear from you on this patch (or a repla
a suspended state, enable_irq_wake is recommended to be used for
> the wakeup.
>
> This patch removes the use of IRQF_NO_SUSPEND flags and uses newly
> introduce PM wakeup APIs dev_pm_{set,clear}_wake_irq.
>
> Cc: Darren Hart <dvh...@infradead.org>
> Cc: platform-
gned-off-by: Azael Avalos <coproscef...@gmail.com>
Queued to testing, thanks Azael.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t; >
> > Reported-by: Randy Dunlap <rdun...@infradead.org>
> > Signed-off-by: Lee Jones <lee.jo...@linaro.org>
>
> Works for me. Thanks.
>
> Acked-by: Randy Dunlap <rdun...@infradead.org>
Lee,
Since this appears to be the result of a patch applie
caught up on
platform-driver-x86 work over the weekend and throughout the week. My apologies
folks.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to majord...@vger.kerne
y have a global
> variable named "hotkey_event_type" and the result of the HCI_SYSTEM_EVENT
> query can be checked directly from the function.
>
> Signed-off-by: Azael Avalos <coproscef...@gmail.com>
Applied, thanks Azael.
--
Darren Hart
Intel Open Source Technology Ce
On Mon, Sep 21, 2015 at 07:28:59PM +0200, Oleksij Rempel wrote:
> Am 21.09.2015 um 19:12 schrieb Darren Hart:
> > On Sat, Sep 19, 2015 at 07:45:31AM +0200, Oleksij Rempel wrote:
> >> Hi,
> >>
> >> Am 19.09.2015 um 00:31 schrieb Darren Hart:
> >>> O
On Sat, Sep 19, 2015 at 07:45:31AM +0200, Oleksij Rempel wrote:
> Hi,
>
> Am 19.09.2015 um 00:31 schrieb Darren Hart:
> > On Mon, Sep 14, 2015 at 11:16:30AM +0200, Oleksij Rempel wrote:
> >> Afters suspend/resume cycle with closed lid the kbd backlight level
ng on things caught be
checkpatch.pl, please run it and incorporate those fixes in your next revision.
Another note, official Intel guidance is to include "All rights reserved."
following the Intel copyright, typically on the following line. You'll find
numerous examples within the kernel.
i].name;
Just one line here is fine. Alternatively, alias the long path to plt_config as
*pcfg and use throughout.
> +
> + return 0;
> +}
> +
> +static inline int telemetry_get_iossevtname(enum telemetry_unit telem_unit,
> + const cha
ers/platform/x86/Makefile
> +++ b/drivers/platform/x86/Makefile
> @@ -60,3 +60,5 @@ obj-$(CONFIG_INTEL_SMARTCONNECT)+= intel-smartconnect.o
> obj-$(CONFIG_PVPANIC) += pvpanic.o
> obj-$(CONFIG_ALIENWARE_WMI) += alienware-wmi.o
> obj-$(CONFIG_INTEL_PMC_IPC) += intel_p
; obj-$(CONFIG_INTEL_PMC_IPC) += intel_pmc_ipc.o
> +obj-$(CONFIG_INTEL_PUNIT_IPC)+= intel_punit_ipc.o
> +obj-$(CONFIG_INTEL_TELEMETRY)+= intel_telemetry_core.o
> intel_telemetry_pltdrv.o intel_telemetry_debugfs.o
> --
> 1.7.9.5
>
>
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Signed-off-by: Azael Avalos <coproscef...@gmail.com>
Queued to testing for 4.4.
Let me know if you were expecting 4.3
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a
dev:
> + input_free_device(toshiba_wmi_input_dev);
> + return err;
> +}
> +
> +static void toshiba_wmi_input_destroy(void)
> +{
> + wmi_remove_notify_handler(TOSHIBA_WMI_EVENT_GUID);
> + sparse_keymap_free(toshiba_wmi_input_dev);
> + input_unregister_device(toshiba
continue;
> + }
> + }
> +
> + if ((suspend_shlw_ctr_exit < suspend_shlw_ctr_temp) ||
> + (suspend_deep_ctr_exit < suspend_deep_ctr_temp) ||
> + (suspend_shlw_res_exit < suspend_shlw_res_temp) ||
> + (suspend_dee
implifying code in the process.
>
> Signed-off-by: Azael Avalos <coproscef...@gmail.com>
Queued to testing for 4.4.
Thanks Azael.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
On Fri, Sep 18, 2015 at 03:45:05PM -0600, Azael Avalos wrote:
> Hi Darren,
>
> 2015-09-18 15:37 GMT-06:00 Darren Hart <dvh...@infradead.org>:
> > On Wed, Sep 09, 2015 at 11:28:20AM -0600, Azael Avalos wrote:
> >> The driver currently uses the hotkey enabling value
On Fri, Sep 18, 2015 at 10:15:03AM +0530, Souvik Kumar Chakravarty wrote:
> Telemetry Device is created by the pmc_ipc driver. Resources
> are populated according to the BIOS tables.
> Telemetry platform driver implements the telemetry interfaces.
> Currently it supports ApolloLake. It uses the
gt; that hey are hex values.
>
> Simply add the 0x prefix to avoid such confussion.
>
> Signed-off-by: Azael Avalos <coproscef...@gmail.com>
Queued to testing for 4.4.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line &q
pported = 1;
> + } else if (hci_write(dev, HCI_SYSTEM_EVENT, 1) == TOS_SUCCESS)
Ahem.
Missing the brace at the end and wreaking havoc on the poor compiler!
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
T_MANUFACTURER_NAME_ADDR,
> data->bat_manufacturer_name,
> BAT_MANUFACTURER_NAME_LEN);
> --
> 1.9.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> platform-driver-x86" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PIs in its Probe when do module
> init.
As you know, cross driver calls is something we work to avoid specifically for
the issues of load order, etc. As this is a new driver, there shouldn't be in
users of this currently. Is it expected there will be in the near future?
--
Darre
For example:
ERROR: patch seems to be corrupt (line wrapped?)
#72: FILE: arch/x86/include/asm/intel_telemetry.h:11:
or
ERROR: spaces required around that '=' (ctx:WxV)
#83: FILE: arch/x86/include/asm/intel_telemetry.h:22:
+ TELEM_PSS =3D 0,
the 3D after every = character repeats man
. That patch series had some issues, so I'm waiting for a v2 which I
can apply and review properly.
Both of these are 4.4 candidates and I'd like them in next for as long as
possible, so please watch for Andriy's upcoming review. Thanks for sticking with
it.
--
Darren Hart
Intel Open Source Technol
d a new test function, hp_wmi_bios_2008_later() & simplify
> hp_wmi_bios_2009_later(), which fixes a bug in cases where
> an improper value is returned. Probably also fixes Bug #69131.
>
> Add missing __init tag.
>
> Signed-off-by: Kyle Evans <kvan...@gmail.com>
Thanks Kyle, pushed
models out there affected by this regression as well.
>
> Cc: <sta...@vger.kernel.org> # 4.1+
> Signed-off-by: Azael Avalos <coproscef...@gmail.com>
Queued for 4.3, thanks!
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the l
gt; Hopefully this patch can go into one of the 4.3 RCs, as the changes are
> there and to avoid shipping a broken feature support.
Queued for 4.3, thanks Azael.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x
;bios" in the call to hp_wmi_bios_2008_later. Which
suggests this version was not compile tested. As I cannot test the code myself
without hardware, I depend on submitters even more to do the testing, so it is
really important that you have tested the exact patch that I send to Linus.
--
D
rite dell_wmi_notify function to always process WMI buffer as
> [length, type, data...].
>
> What do you think about it? It also simplify notify code as there is one
> branch for dell_new_hk_type and one for old parsing (with that entry[1]).
>
Without documentation for the
I've re-reviewed, built myself, queued to testing, and it's now getting the
0-day treatment. Provided that comes back good - hopefully tonight, I'll push to
for-next, and you'll see it in next in the morning, and to Linus on Friday
before the close of the merge window for 4.3.
--
Darren Ha
On Wed, Sep 09, 2015 at 04:32:34PM -0400, Kyle Evans wrote:
>
>
> On 09/08/2015 04:22 PM, Darren Hart wrote:
> >On Tue, Sep 08, 2015 at 01:29:39PM -0500, Kyle Evans wrote:
> >> From 7d11e942d2c84919ded37b46a72be59f34141c5d Mon Sep 17 00:00:00 2001
> >>Fr
PE can be contained within those wrappers, which is
arguably the point of a wrapper function - to abstract away things like that.
For the original use of hp_wmi_bios_2009_later, only the == 4 case would need to
be updated to deal with the boolean logic.
Perhaps I'm missing something about how
On Sun, Sep 06, 2015 at 10:40:05AM +0200, Corentin Chary wrote:
> Looks good.
>
> Acked-by: Corentin Chary <corentin.ch...@gmail.com>
Thanks, queued for testing. Should make 4.3.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the li
On Tue, Sep 01, 2015 at 08:11:26AM +, Andriy Shevchenko wrote:
> On Mon, 2015-08-31 at 12:38 -0700, Darren Hart wrote:
> > On Thu, Aug 27, 2015 at 12:38:37AM +0800, Qipeng Zha wrote:
> > > This driver provides support for P-Unit mailbox IPC on Intel
> > > platform
On Tue, Sep 01, 2015 at 01:30:27PM -0400, Josh Boyer wrote:
> On Fri, Aug 28, 2015 at 1:56 PM, Darren Hart <dvh...@infradead.org> wrote:
> > On Wed, Aug 26, 2015 at 05:04:01AM -0700, Joe Perches wrote:
> >> On Wed, 2015-08-26 at 00:22 -0700, Darren Hart wrote:
> >>
> + .driver_data = _asus_wapf4,
> + },
> + {
> + .callback = dmi_matched,
> .ident = "ASUSTeK COMPUTER INC. X501U",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC
: %d\n", irq);
> + return -EBUSY;
> + }
> + ipcdev.irq = irq;
> + }
> +
> + ret = intel_punit_get_bars(pdev);
> + if (ret)
> + return ret;
> +
This white space usage of the ret, if(ret) return ret block is t
/thinkpad_acpi.o.new
609276184 824 67935 1095f
drivers/platform/x86/thinkpad_acpi.o.old
Signed-off-by: Joe Perches j...@perches.com
Acked-by: Henrique de Moraes Holschuh h...@hmh.eng.br
Queued, thanks.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from
On Wed, Aug 26, 2015 at 05:04:01AM -0700, Joe Perches wrote:
On Wed, 2015-08-26 at 00:22 -0700, Darren Hart wrote:
On Tue, Aug 18, 2015 at 11:30:25PM +0800, Chen Yu wrote:
Since Surface Pro 3 does not follow the specs of Windows ACPI Design
Guide for SoC Platform, code in drivers/input
,
Please always include the maintainer from MAINTAINERS on Cc when submitting
kernel patches. See Documentation/SubmittingPatches.
For example:
$ scripts/get_maintainer.pl -f drivers/platform/x86/hp-wmi.c
Darren Hart dvh...@infradead.org (maintainer:X86 PLATFORM DRIVERS)
platform-driver-x86
request to do same thing for iTco.
I agree it's better to update pmc driver to use mfd_add_devices to create
punit and iTco device.
Does this mean there sill be a v4 I should be waiting for?
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line
the value
Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com
Thanks Giedrius, queued.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message to majord...@vger.kernel.org
More
'
tree for changing the lpc_ich_info into itco_wdt_platform_data.
Btw, is there a reason that intel_pmc_ipc doesn't use the mfd_* API
since it's concerned with multiple functions?
Qipeng?
I saw the v2 come in, but didn't see this question addressed in the changelog.
--
Darren Hart
Intel Open
notice:
Copyright (c) 2015, Intel Corporation.
All rights reserved.
But the (c) generally always goes after Copyright
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message to majord
for target 'drivers/platform/x86/intel_punit_ipc.ko'
failed
make: *** [drivers/platform/x86/intel_punit_ipc.ko] Error 2
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message to majord
On Wed, Aug 12, 2015 at 09:06:08AM +0200, Corentin Chary wrote:
On Wed, Aug 5, 2015 at 10:29 PM, Darren Hart dvh...@infradead.org wrote:
On Wed, Jul 29, 2015 at 09:31:23PM +0200, Łukasz Stelmach wrote:
Asus F3M has two keys labeled with an icon of a touchpad. The first,
reported as 0x6B
On Thu, Aug 06, 2015 at 11:55:29AM -0700, Joe Perches wrote:
On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote:
On Thu, Aug 06, 2015 at 11:20:44AM +, Chen, Yu C wrote:
[]
Is it ok to keep these codes and add comments like:
It's your code Yu, do whatever you think appropriate
On Thu, Aug 06, 2015 at 10:21:15AM -0600, Azael Avalos wrote:
Hi Darren,
2015-08-05 17:21 GMT-06:00 Darren Hart dvh...@infradead.org:
On Wed, Aug 05, 2015 at 04:23:49PM -0600, Azael Avalos wrote:
Hi Darren,
2015-08-05 14:21 GMT-06:00 Darren Hart dvh...@infradead.org:
@@ -1131,14
mailbox IPC driver
50f6db8 asus-laptop: Add key found on Asus F3M
6615e04 MAINTAINERS: Remove Toshiba Linux mailing list address
Regards,
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message
by these notification codes, then pass
* (EV_KEY, event code(key_code), value(pressed)) to input layer.
*/
The commentary is useful regardless. However, I suspect Joe was
referring to the approach pairing the PRESS and RELEASE cases?
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from
. Is there a
compelling reason to add the redundant check?
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
when you prepared these patches
perhaps?
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
...@buzzard.org.uk
-L: tlinux-us...@tce.toshiba-dme.co.jp
W: http://www.buzzard.org.uk/toshiba/
S: Maintained
F: drivers/char/toshiba.c
--
2.4.5
Thanks,
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad Fn + F9 */
{KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad */
{KE_KEY, 0x6C, { KEY_SLEEP } }, /* Suspend */
{KE_KEY, 0x6D, { KEY_SLEEP } }, /* Hibernate */
--
2.1.4
--
Darren Hart
Intel Open Source Technology Center
*/
+ { HPQ6001, 0},
{ , 0},
};
I haven't determined the reason yet, but when saving this to apply, I get an
encoded blob of text instead of the patch. How did you send this email?
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe
On Wed, Aug 05, 2015 at 01:54:21PM -0700, Darren Hart wrote:
On Sun, Aug 02, 2015 at 10:59:29PM +, Powell, Michael wrote:
Prevents acer-wmi from blocking wifi on HP Omen 15 laptops
Wow, you managed to miss both my automated scans for patches that fail
to Cc the maintainer :-) Patchwork
);
+}
+
+MODULE_AUTHOR(Zha Qipeng qipeng@intel.com);
+MODULE_DESCRIPTION(Intel Punit IPC driver);
+MODULE_LICENSE(GPL);
+
+/* Some modules are dependent on this, so init earlier */
+fs_initcall(intel_punit_ipc_init);
+module_exit(intel_punit_ipc_exit);
--
1.8.3.2
--
Darren Hart
Intel Open Source
On Wed, Aug 05, 2015 at 04:23:49PM -0600, Azael Avalos wrote:
Hi Darren,
2015-08-05 14:21 GMT-06:00 Darren Hart dvh...@infradead.org:
@@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct
toshiba_acpi_dev *dev, u32 state)
result = sci_write(dev, SCI_USB_THREE, state
On Wed, Aug 05, 2015 at 04:15:13PM -0600, Azael Avalos wrote:
Hi Darren,
2015-08-05 3:38 GMT-06:00 Darren Hart dvh...@infradead.org:
On Fri, Jul 31, 2015 at 09:58:13PM -0600, Azael Avalos wrote:
Currently the driver prints *not supported if any of the features
queried are in fact
} }, /* Hibernate */
--
2.1.4
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
in the neighborhood means
you need to split the patch across distinct functional boundaries.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message to majord...@vger.kernel.org
More majordomo info
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
/platform/x86/toshiba_acpi.c:1292:2: warning: ISO C90 forbids mixed
declarations and code [-Wdeclaration-after-statement]
int is_lcd = (value HCI_VIDEO_OUT_LCD) ? 1 : 0;
^
Did it not?
...
Thanks,
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line
on the
sysfs functions.
Signed-off-by: Azael Avalos coproscef...@gmail.com
Queued, thanks Azael!
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message to majord...@vger.kernel.org
More
)
return;
And otherwise return. So this last if test doesn't do anything. If you feel
the context is relevant, consider just including it as a comment.
Thanks,
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
we will have to revert if someone complains and can't
work around it, so we need to be clear about this in the commit message at the
very least.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body
On Mon, Jul 20, 2015 at 04:49:51PM -0600, Azael Avalos wrote:
Hi Darren,
2015-07-20 15:55 GMT-06:00 Darren Hart dvh...@infradead.org:
On Thu, Jul 16, 2015 at 05:38:57PM -0600, Azael Avalos wrote:
Commit f11f999e9890 (toshiba_acpi: Refuse to load on machines with
buggy INFO
was moved to the *add
function, as the {__get, set}_lcd_brightness functions amke use of it.
make
I can make minor typographical corrections, but please do be more careful :)
Signed-off-by: Azael Avalos coproscef...@gmail.com
Otherwise, looks good. No need to resend.
--
Darren Hart
Intel
interface - unless of course you
choose to resend the 3 at the same time, and I'll pick those up.
Thanks Azael,
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message to majord...@vger.kernel.org
made on this patch, and while I was
at it, solved a couple of the issues reported by such check ;-)
I'm still digging into the code, and will provide a patch later on
with all the needed changes :-)
Looks good, thanks Azael.
--
Darren Hart
Intel Open Source Technology Center
tests, checkpatch, build, and ninja-check.
As this is the first series that I've received since enabling a lot of new
automation, I wanted to say thanks for clean series that is ready review. Nice.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line
of TOS1900
devices too, and in case some programs are still using that interface,
hotkeys reporting should now work on these devices.
Signed-off-by: Azael Avalos coproscef...@gmail.com
Thanks, queued to for-review.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from
On Mon, Jul 13, 2015 at 04:44:54PM +0200, Christophe JAILLET wrote:
'{ }' and memset will both reset the cbuf buffer.
Only once is enough and this can be done outside fo the mutex.
Signed-off-by: Christophe JAILLET christophe.jail...@wanadoo.fr
Queued, thanks Christophe.
--
Darren Hart
On Tue, Jul 07, 2015 at 04:25:18PM +0200, Pali Rohár wrote:
On Monday 06 July 2015 15:43:28 Darren Hart wrote:
On Mon, Jul 06, 2015 at 09:35:40AM +0800, Alex Hung wrote:
ATK4001 is an ACPI device for wireless hotkey, similar to how Dell and
HP are doing it. It is just ASUS who decides
for the merge
commit is intended to be in the tag now.
Thanks,
Darren Hart
Intel Open Source Technology Center
The following changes since commit 5ee7041e5bc0fe8ba04a554dc2f9a18f709bc005:
MAINTAINERS: Orphan x86 driver msi-wmi (2015-06-15 13:39:35 -0700)
are available in the git repository
Single line body.
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
,
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform-driver-x86
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 07, 2015 at 04:04:57PM +0200, Pali Rohár wrote:
On Monday 06 July 2015 15:39:37 Darren Hart wrote:
On Mon, Jul 06, 2015 at 12:08:55PM +0200, Pali Rohár wrote:
Make sure that before initializing SMBIOS call input buffer does not
contain any garbage (e.g. values from previous
...
drivers/platform/x86/acerhdf.c | 9
drivers/platform/x86/intel_mid_thermal.c | 9
For these two:
Reviewed-by: Darren Hart dvh...@linux.intel.com
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line
Rohár pali.ro...@gmail.com
Queued all 3 to fixes. Thanks Pali.
(I made a few minor grammatical fixes tot he commit messages, review the changes
if you like in the fixes branch)
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe platform
101 - 200 of 497 matches
Mail list logo
