Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

2015-11-06 Thread David Herrmann
Hi Darren! On Wed, Oct 21, 2015 at 4:44 PM, Darren Hart <dvh...@infradead.org> wrote: > On Wed, Oct 21, 2015 at 12:33:52PM -0200, Henrique de Moraes Holschuh wrote: >> On Wed, Oct 21, 2015, at 08:46, David Herrmann wrote: >> > The thinkpad_acpi driver currently emits error

[PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

2015-10-21 Thread David Herrmann
are supported by the i915 driver just fine. Downgrade the error message to a normal pr_info() and stop telling people to report it to IBM. Signed-off-by: David Herrmann <dh.herrm...@gmail.com> --- drivers/platform/x86/thinkpad_acpi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH] platform/x86/toshiba-apci.c possible bad if test?

2014-08-20 Thread David Herrmann
Hi On Fri, Jun 13, 2014 at 5:04 AM, Nick xerofo...@gmail.com wrote: diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 76441dc..dfd2243 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -1238,7 +1238,7 @@

Re: [PATCH] ACPI / Video: blacklist some samsung laptops

2012-02-20 Thread David Herrmann
Hi Len On Sun, Feb 19, 2012 at 8:56 PM, Corentin Chary corentin.ch...@gmail.com wrote: On Mon, Jan 30, 2012 at 9:26 AM, Corentin Chary corentin.ch...@gmail.com wrote: On Tue, Jan 17, 2012 at 8:08 AM, Corentin Chary corenti...@iksaif.net wrote: On these laptops, the ACPI video is not

Re: [PATCH] ACPI / Video: blacklist some samsung laptops

2012-01-09 Thread David Herrmann
on my N210 with linux-3.2. Feel free to add a: Tested-by: David Herrmann dh.herrm...@googlemail.com I will talk to the intel drm developers about the intel_backlight issues as they don't seem related to this driver. Thanks David -- To unsubscribe from this list: send the line unsubscribe platform

Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

2011-11-25 Thread David Herrmann
On Thu, Nov 24, 2011 at 8:07 AM, Corentin Chary corentin.ch...@gmail.com wrote: Hi David,I refreshed the patches on the github repo, could you re-try them ?Thanks Works great. The error message doesn't appear anymore. The devices still work as expected. Tested-by: David Herrmann dh.herrm

Re: [PATCH 03/15] samsung-laptop: don't handle backlight if handled by acpi/video

2011-11-23 Thread David Herrmann
couldn't find the samsung backlight and so I tried the intel back light again and now it works. So: Tested-by: David Herrmann dh.herrm...@googlemail.com My model is Samsung N210 btw. Regards David -- To unsubscribe from this list: send the line unsubscribe platform-driver-x86 in the body

Re: [PATCH 15/15] samsung-laptop: promote myself as maintainer of samsung-laptop

2011-11-23 Thread David Herrmann
. I've commented on a few patches about some small stuff. But it didn't break any existing stuff / introduce regressions. Feel free to carry this on the patches: Tested-by: David Herrmann dh.herrm...@googlemail.com I haven't had the time to review the code more deeply, though. I might do that later

Re: [PATCH 08/15] samsung-laptop: add battery life extender support

2011-11-23 Thread David Herrmann
On Wed, Nov 23, 2011 at 5:54 PM, Corentin Chary corentin.ch...@gmail.com wrote: My BIOS provides this option, too. However, this driver does not detect it on my machine. During initialization I get: samsung_laptop: SABI command 0x0078 failed with completion flag 0xaa Maybe you can help

Re: [PATCH 08/15] samsung-laptop: add battery life extender support

2011-11-23 Thread David Herrmann
On Wed, Nov 23, 2011 at 7:11 PM, Corentin Chary corentin.ch...@gmail.com wrote: On Wed, Nov 23, 2011 at 6:10 PM, David Herrmann dh.herrm...@googlemail.com wrote: On Wed, Nov 23, 2011 at 5:54 PM, Corentin Chary corentin.ch...@gmail.com wrote: My BIOS provides this option, too. However

Re: [patch 5/8] Platform: Fix error path in samsung-laptop init

2011-09-20 Thread David Herrmann
Hi Greg On Fri, Sep 2, 2011 at 12:50 AM, gre...@suse.de wrote: samsung_init() should not return success if not all devices are initialized. Otherwise, samsung_exit() will dereference sdev NULL pointers and others. Signed-off-by: David Herrmann dh.herrm...@googlemail.com Cc: stable sta

Re: [PATCH] Platform: Brightness quirk for samsung laptop driver

2011-08-26 Thread David Herrmann
of */        sdev = platform_device_register_simple(samsung, -1, NULL, 0);        if (IS_ERR(sdev)) Thank you, Jason. Tested-by: David Herrmann dh.herrm...@googlemail.com And Greg, could you actually git add the new samsung patches in your repository? You added them to series but didn't submit

[PATCH] Platform: Fix error path in samsung-laptop init

2011-08-23 Thread David Herrmann
samsung_init() should not return success if not all devices are initialized. Otherwise, samsung_exit() will dereference sdev NULL pointers and others. Signed-off-by: David Herrmann dh.herrm...@googlemail.com --- drivers/platform/x86/samsung-laptop.c |3 +-- 1 files changed, 1 insertions

[PATCH] Platform: Brightness quirk for samsung laptop driver

2011-08-23 Thread David Herrmann
/to brightness level 0. This patch adds detection and a non-intrusive workaround for the above issues. Signed-off-by: David Herrmann dh.herrm...@googlemail.com --- Hi This patch is originally from Jason Stubbs. See here: http://git.kernel.org/?p=linux/kernel/git/gregkh/patches.git;a=blob;f=platform