Re: [PATCH 3/3] Capture cable events created by Alienware GFX Amplifier.

2015-05-28 Thread Greg KH
On Thu, May 28, 2015 at 01:50:02PM -0500, Mario Limonciello wrote: > > > On 05/28/2015 01:30 PM, Greg KH wrote: > >On Wed, May 27, 2015 at 06:46:05PM -0500, Mario Limonciello wrote: > >Then fix the GPU drivers. > > > >Fix the GPU drivers. > > > >

Re: [PATCH 3/3] Capture cable events created by Alienware GFX Amplifier.

2015-05-28 Thread Greg KH
On Wed, May 27, 2015 at 06:46:05PM -0500, Mario Limonciello wrote: > > > On 05/27/2015 02:37 PM, Limonciello, Mario wrote: > >These events are outputted via the keyboard controller. > >Right now the only actionable event is to restart the system > >if the cable is removed, but the others are doc

Re: [PATCH 3/3] Capture cable events created by Alienware GFX Amplifier.

2015-05-28 Thread Greg KH
On Wed, May 27, 2015 at 02:37:02PM -0500, Mario Limonciello wrote: > These events are outputted via the keyboard controller. > Right now the only actionable event is to restart the system > if the cable is removed, What? No, that's not an acceptable "event" at all. You don't reboot for something

Re: [PATCH 0/2] toshiba_acpi: Qosmio backlight and keymap fixes

2014-08-04 Thread Greg KH
On Mon, Aug 04, 2014 at 09:21:00AM -0600, Azael Avalos wrote: > The following two patches fixes some issues regarding > the backlight method on Qosmios series X500/X505 and > X75-A (and probably others too), as well as adding > the latter to the new alternate keymap list. > > Azael Avalos (2): >

Re: [PATCH 2/2] toshiba_acpi: Add Qosmio X75-A to the alt keymap dmi list

2014-08-04 Thread Greg KH
On Mon, Aug 04, 2014 at 09:21:02AM -0600, Azael Avalos wrote: > The Toshiba Qosmio X75-A series models also come with > the new keymap layout. > > This patch adds this model to the alt_keymap_dmi list, > along with an extra key found on these models. > > Signed-off-by: Azael Avalos > --- > driv

Re: [PATCH 1/2] toshiba_acpi: Add extra check to backlight code

2014-08-04 Thread Greg KH
On Mon, Aug 04, 2014 at 09:21:01AM -0600, Azael Avalos wrote: > Some Toshiba models (most notably Qosmios) come with an > incomplete backlight method where the AML code doesn't > check for write or read commands and always returns > HCI_SUCCESS and the actual brightness (and in some > cases the max

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote: > On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: > > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > > >

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > We should prefer `const struct pci_device_id` over > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > > This issue was reported by checkpatch. >

Re: [PATCH] gpio: removes all usage of gpiochip_remove retval

2014-05-29 Thread Greg KH
On Thu, May 29, 2014 at 11:54:52PM +0200, abdoulaye berthe wrote: > Signed-off-by: abdoulaye berthe Why? -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordom

Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver

2013-04-05 Thread Greg KH
On Fri, Apr 05, 2013 at 02:33:40PM -0700, Jacob Pan wrote: > On Fri, 5 Apr 2013 13:23:09 -0700 > Greg KH wrote: > > > On Wed, Apr 03, 2013 at 10:35:51AM -0700, Jacob Pan wrote: > > > On Wed, 3 Apr 2013 09:35:09 -0700 > > > Greg KH wrote: > > > > &

Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver

2013-04-05 Thread Greg KH
On Wed, Apr 03, 2013 at 11:03:08AM -0700, Jacob Pan wrote: > On Wed, 3 Apr 2013 09:30:52 -0700 > Greg KH wrote: > > > On Tue, Apr 02, 2013 at 05:17:14PM -0700, Jacob Pan wrote: > > > On Tue, 2 Apr 2013 16:48:05 -0700 > > > Greg KH wrote: > > > > &

Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver

2013-04-05 Thread Greg KH
On Wed, Apr 03, 2013 at 10:35:51AM -0700, Jacob Pan wrote: > On Wed, 3 Apr 2013 09:35:09 -0700 > Greg KH wrote: > > > On Tue, Apr 02, 2013 at 09:48:18PM -0700, Jacob Pan wrote: > > > > Let's step back and start over, what exactly are you trying to > > >

Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver

2013-04-03 Thread Greg KH
On Tue, Apr 02, 2013 at 09:48:18PM -0700, Jacob Pan wrote: > > Let's step back and start over, what exactly are you trying to tell > > userspace? What data do you have that you need to express to it? How > > do you want userspace to see/use it? > > It is a good idea to step back and let me expla

Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver

2013-04-03 Thread Greg KH
On Tue, Apr 02, 2013 at 05:17:14PM -0700, Jacob Pan wrote: > On Tue, 2 Apr 2013 16:48:05 -0700 > Greg KH wrote: > > > On Tue, Apr 02, 2013 at 04:33:57PM -0700, Jacob Pan wrote: > > > On Tue, 2 Apr 2013 16:00:42 -0700 > > > Greg KH wrote: > &g

Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver

2013-04-02 Thread Greg KH
On Tue, Apr 02, 2013 at 04:53:40PM -0700, Jacob Pan wrote: > On Tue, 2 Apr 2013 16:00:42 -0700 > Greg KH wrote: > > > And, one final complaint, never use "raw" kobjects, for loads of good > > reasons, not the least being you just prevented userspace from seeing

Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver

2013-04-02 Thread Greg KH
On Tue, Apr 02, 2013 at 04:33:57PM -0700, Jacob Pan wrote: > On Tue, 2 Apr 2013 16:00:42 -0700 > Greg KH wrote: > > > > +#include "intel_rapl.h" > > > +#include "../../../fs/sysfs/sysfs.h" > > > > WTF? > > > > Oh, that&#x

Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver

2013-04-02 Thread Greg KH
On Tue, Apr 02, 2013 at 04:00:42PM -0700, Greg KH wrote: > I'm not even going to review the rest of this file, please fix that up > first, before sending it out again. And, when you do so, please cc: me. It's like a train wreck, you just can't tear away your eyes... You r

Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver

2013-04-02 Thread Greg KH
On Tue, Apr 02, 2013 at 03:15:36PM -0700, Jacob Pan wrote: > RAPL(Running Average Power Limit) interface provides platform software > with the ability to monitor, control, and get notifications on SOC > power consumptions. Since its first appearance on Sandy Bridge, more > features have being added

Re: [PATCH] samsung-laptop: Disable if CONFIG_EFI=y

2012-11-05 Thread Greg KH
On Sun, Nov 04, 2012 at 05:35:06PM +, Matt Fleming wrote: > From: Matt Fleming > > We've started getting reports of users seeing Machine Check Exceptions > when booting their Samsung laptops in UEFI mode, > > https://bugzilla.kernel.org/show_bug.cgi?id=47121 > > This module seems to be

Re: [PATCH] samsung-laptop: Disable if CONFIG_EFI=y

2012-11-05 Thread Greg KH
On Mon, Nov 05, 2012 at 09:12:01AM +, Corentin Chary wrote: > On Sun, Nov 4, 2012 at 7:37 PM, Alan Cox wrote: > >> Acked-by: Corentin Chary > > > > This is totally bogus and prevents users build a kernel which can work in > > either mode. As such its a regression. > > Arg.. Sorry for that, I

Re: [PATCH] acer-wmi: support Lenovo ideapad S205 10382JG wifi switch

2012-08-30 Thread Greg KH
On Thu, Aug 30, 2012 at 10:39:41AM +0800, Lee, Chun-Yi wrote: > Found another Lenovo ideapad S205 the product name is 10382JG, it has > a 0x78 EC register exposes the state of wifi hardware switch on the machine. > > So, add this patch to support Lenovo ideapad S205-10382JG wifi hardware > switch

Re: [PATCH] apple-gmux: Add support for message box interface (as found in MBP10,1/Retina MacBook Pro)

2012-08-13 Thread Greg KH
On Mon, Aug 13, 2012 at 08:01:33PM +0200, Bernhard Froemel wrote: > On 08/13/2012 07:09 PM, Seth Forshee wrote: > > Matthew also made some progress with this last week, at least > > enough to get the backlight working. From what I remember of > > looking at his changes these look fairly similar, bu

Re: Need help to understand USB driver mechanism

2012-06-22 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Jun 22, 2012 at 08:33:50AM +0530, Vishal Nandanwar wrote: > Yes, I am reading it simultaneously. > > But to do hands on, which driver one should try as mass storage driver > (for pen driver) i

Re: Need help to understand USB driver mechanism

2012-06-21 Thread Greg KH
On Fri, Jun 22, 2012 at 07:35:55AM +0530, Vishal Nandanwar wrote: > Hi Alan, > > Thanks for your reply. It really helps. > > What approach one should use to learn the device drivers? "Linux Device Drivers", third edition, free online. Have you tried that? -- To unsubscribe from this list: send

Re: [PATCH 3.0.y] acer-wmi: No wifi rfkill on Sony machines

2012-04-10 Thread Greg KH
On Sun, Apr 01, 2012 at 01:40:07PM -0500, Jonathan Nieder wrote: > From: Lee, Chun-Yi > Date: Fri, 23 Mar 2012 12:36:44 +0800 > > commit 5719b81988f3c24ff694dc3a37e35b35630a3966 upstream. > > The wireless rfkill should charged by sony-laptop but not acer-wmi. > So, add Sony's SNY5001 acpi device

Re: [PATCH 3.0.y] acer-wmi: No wifi rfkill on Lenovo machines

2012-03-16 Thread Greg KH
On Fri, Mar 16, 2012 at 02:11:21PM +0800, joeyli wrote: > Hi Ike, > > 於 五,2012-03-16 於 12:03 +0800,Ike Panhc 提到: > > On 03/15/2012 06:17 AM, Jonathan Nieder wrote: > > > Greg KH wrote: > > >> On Wed, Mar 14, 2012 at 04:53:27PM -0500, Jonathan Nieder wrote: >

Re: [PATCH 3.0.y] acer-wmi: No wifi rfkill on Lenovo machines

2012-03-14 Thread Greg KH
On Wed, Mar 14, 2012 at 04:53:27PM -0500, Jonathan Nieder wrote: > Hi Greg, > > Please consider applying 461e74377cfc (acer-wmi: No wifi rfkill on > Lenovo machines, 2012-02-03) to the 3.2.y and 3.0.y trees. Now applied. greg k-h -- To unsubscribe from this list: send the line "unsubscribe platf

Re: [PATCH linux-3.1.y] ideapad: Check if acpi already handle backlight power to avoid a page fault

2012-01-12 Thread Greg KH
On Tue, Jan 10, 2012 at 06:42:56PM -0600, Jonathan Nieder wrote: > From: René Bollford > Date: Sun, 23 Oct 2011 09:56:42 +0200 > > commit d4afc7754a60b885b63ef23fd194984e2d53a4e6 upstream. > > This patch avoid a page fault in the ideapad-laptop extras when > turning the backlight power on or off

Re: [PATCH linux-3.1.y] ideapad: Check if acpi already handle backlight power to avoid a page fault

2012-01-11 Thread Greg KH
On Wed, Jan 11, 2012 at 10:40:28AM -0600, Jonathan Nieder wrote: > Greg KH wrote: > >> On 01/11/2012 08:42 AM, Jonathan Nieder wrote: > > >>> From: René Bollford > >>> Date: Sun, 23 Oct 2011 09:56:42 +0200 > >>> > >>> commit d4afc

Re: [PATCH linux-3.1.y] ideapad: Check if acpi already handle backlight power to avoid a page fault

2012-01-11 Thread Greg KH
On Wed, Jan 11, 2012 at 07:47:33PM +0800, Ike Panhc wrote: > Thanks, and this is necessary for 3.1.y > > On 01/11/2012 08:42 AM, Jonathan Nieder wrote: > > From: René Bollford > > Date: Sun, 23 Oct 2011 09:56:42 +0200 > > > > commit d4afc7754a60b885b63ef23fd194984e2d53a4e6 upstream. > > > > Thi

Re: [PATCH v2 00/16] samsung-laptop updates

2011-11-27 Thread Greg KH
On Sat, Nov 26, 2011 at 10:59:57AM +0100, Corentin Chary wrote: > Hi Matthew, Greg > > I recently got a Samsung Series 9 from Intel, so I took some > time to add support for some features. > > In this series, I moved a lot of code, tried to follow more > closely the SABI interface, added some fea

Re: [PATCH v2 16/16] samsung-laptop: promote myself as maintainer of samsung-laptop

2011-11-27 Thread Greg KH
On Sat, Nov 26, 2011 at 11:00:13AM +0100, Corentin Chary wrote: > Signed-off-by: Corentin Chary Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: [PATCH v2 15/16] samsung-laptop: tweak traces

2011-11-27 Thread Greg KH
On Sat, Nov 26, 2011 at 11:00:12AM +0100, Corentin Chary wrote: > - don't output error when probing features at load > - print the SABI signature if samsung_sabi_init() > succeed > > Signed-off-by: Corentin Chary Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "un

Re: [PATCH v2 14/16] samsung-laptop: dump model and version informations

2011-11-27 Thread Greg KH
On Sat, Nov 26, 2011 at 11:00:11AM +0100, Corentin Chary wrote: > We still need to figure out exactly what each of different fields > represent, but they contain at least model and version informations. > > Signed-off-by: Corentin Chary Acked-by: Greg Kroah-Hartman -- To unsubscribe from this l

Re: [PATCH v2 13/16] samsung-laptop: make the dmi check less strict

2011-11-27 Thread Greg KH
On Sat, Nov 26, 2011 at 11:00:10AM +0100, Corentin Chary wrote: > This enable the driver for everything that look like > a laptop and is from vendor "SAMSUNG ELECTRONICS CO., LTD.". > Note that laptop supported by samsung-q10 seem to have a different > vendor strict. > > Also remove every log outp

Re: [PATCH v2 12/16] samsung-laptop: add true rfkill support for swsmi

2011-11-27 Thread Greg KH
On Sat, Nov 26, 2011 at 11:00:09AM +0100, Corentin Chary wrote: > The wireless status get and get commands seems to use one > byte per device. First byte is for wlan and third is for bluetooh, > we will have to find what the other are for. > > Signed-off-by: Corentin Chary Acked-by: Greg Kroah-H

Re: [PATCH v2 11/16] samsung-laptop: add keyboard backlight support

2011-11-27 Thread Greg KH
On Sat, Nov 26, 2011 at 11:00:08AM +0100, Corentin Chary wrote: > Signed-off-by: Corentin Chary Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

Re: [PATCH v2 03/16] samsung-laptop: don't handle backlight if handled by acpi/video

2011-11-27 Thread Greg KH
On Sat, Nov 26, 2011 at 11:00:00AM +0100, Corentin Chary wrote: > samsung-laptop is not at all related to ACPI, but since this interface > is not documented at all, and the driver has to use it at load to > understand how it works on the laptop, I think it's a good idea to > disable it if a better

Re: [PATCH 13/15] samsung-laptop: make the dmi check less strict

2011-11-23 Thread Greg KH
On Wed, Nov 23, 2011 at 08:17:08AM +0100, Corentin Chary wrote: > On Tue, Nov 22, 2011 at 11:27 PM, Greg KH wrote: > > On Tue, Nov 22, 2011 at 11:02:44PM +0100, Corentin Chary wrote: > >> This enable the driver for everything that look like > >> a laptop and is from ven

Re: [PATCH 03/15] samsung-laptop: don't handle backlight if handled by acpi/video

2011-11-23 Thread Greg KH
On Wed, Nov 23, 2011 at 07:58:20AM +0100, Corentin Chary wrote: > On Tue, Nov 22, 2011 at 11:16 PM, Greg KH wrote: > > On Tue, Nov 22, 2011 at 11:02:34PM +0100, Corentin Chary wrote: > >> samsung-laptop is not at all related to ACPI, but since this interface > >> is not

Re: [PATCH 12/15] samsung-laptop: add true rfkill support for swsmi

2011-11-23 Thread Greg KH
On Wed, Nov 23, 2011 at 07:37:17AM +0100, Corentin Chary wrote: > On Tue, Nov 22, 2011 at 11:24 PM, Greg KH wrote: > > On Tue, Nov 22, 2011 at 11:02:43PM +0100, Corentin Chary wrote: > >> Signed-off-by: Corentin Chary > > > > What happens on machines that don't

Re: [PATCH 02/15] samsung-laptop: move code into init/exit functions

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:33PM +0100, Corentin Chary wrote: > Create _init()/_exit() function for each subsystem, remove > the local struct samsung_laptop * and only keep a > struct platform_device * that can only be used in samsung_init() > and samsung_exit(). > > Signed-off-by: Corentin Char

Re: [PATCH 13/15] samsung-laptop: make the dmi check less strict

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:44PM +0100, Corentin Chary wrote: > This enable the driver for everything that look like > a laptop and is from vendor "SAMSUNG ELECTRONICS CO., LTD.". > Note that laptop supported by samsung-q10 seem to have a different > vendor strict. > > Also remove every log outp

Re: [PATCH 15/15] samsung-laptop: promote myself as maintainer of samsung-laptop

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:46PM +0100, Corentin Chary wrote: > Signed-off-by: Corentin Chary Signed-off-by: Greg Kroah-Hartman YEAH! Note, I am willing to dig up my old "special Linux bios" machine for testing if you want me to verify nothing gets broken after you respin this patch seri

Re: [PATCH 14/15] samsung-laptop: dump model and version informations

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:45PM +0100, Corentin Chary wrote: > We still need to figure out exactly what each of different fields > represent, but they contain at least model and version informatiosn. > > Signed-off-by: Corentin Chary For every time the driver loads? That's not nice, how abou

Re: [PATCH 12/15] samsung-laptop: add true rfkill support for swsmi

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:43PM +0100, Corentin Chary wrote: > Signed-off-by: Corentin Chary What happens on machines that don't support this? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majord...@vger.kernel

Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:42PM +0100, Corentin Chary wrote: > Signed-off-by: Corentin Chary What happens on boxes that don't have this type of hardware? Will the LED device still show up, yet it will not work? You should be able to trigger this off of the model type somehow, much like the v

Re: [PATCH 10/15] samsung-laptop: cleanup KConfig

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:41PM +0100, Corentin Chary wrote: > Signed-off-by: Corentin Chary Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: [PATCH 09/15] samsung-laptop: add usb charge support

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:40PM +0100, Corentin Chary wrote: > Signed-off-by: Corentin Chary > --- > .../ABI/testing/sysfs-driver-samsung-laptop|8 ++ > drivers/platform/x86/samsung-laptop.c | 82 > > 2 files changed, 90 insertions(+), 0 deletio

Re: [PATCH 08/15] samsung-laptop: add battery life extender support

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:39PM +0100, Corentin Chary wrote: > Signed-off-by: Corentin Chary > --- > .../ABI/testing/sysfs-driver-samsung-laptop| 10 +++ > drivers/platform/x86/samsung-laptop.c | 82 > > 2 files changed, 92 insertions(+), 0 deleti

Re: [PATCH 06/15] samsung-laptop: add small debugfs interface

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:37PM +0100, Corentin Chary wrote: > Signed-off-by: Corentin Chary You should describe what the debugfs interface does please. I have an idea, and I like it a lot, but still, it would be nice to let the others know :) Acked-by: Greg Kroah-Hartman -- To unsubscribe

Re: [PATCH 07/15] samsung-laptop: remove selftest

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:38PM +0100, Corentin Chary wrote: > We can now do the self test using debugfs, so remove the code > and keep the debug flag to enable more traces. > > Signed-off-by: Corentin Chary Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH 04/15] samsung-laptop: use a sysfs group

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:35PM +0100, Corentin Chary wrote: > Will be usefull later when we will have more platform sysfs files. We will? For what? > > Signed-off-by: Corentin Chary Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe platform-driver

Re: [PATCH 01/15] samsung-laptop: put all local variables in a single structure

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:32PM +0100, Corentin Chary wrote: > Even if this driver can only be loaded once, it is still a good > idea to create some kind of context structure. > > Signed-off-by: Corentin Chary Acked-by: Greg Kroah-Hartman > --- > drivers/platform/x86/samsung-laptop.c | 2

Re: [PATCH 05/15] samsung-laptop: ehance SABI support

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:36PM +0100, Corentin Chary wrote: > * SABI command are on 16 bits, not 8 Are you sure about that? I guess this would work, and we rely on the bits being in the right order so everything works properly? > * SABI can read/write up to 11 byte of data It can? > * Ther

Re: [PATCH 03/15] samsung-laptop: don't handle backlight if handled by acpi/video

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 11:02:34PM +0100, Corentin Chary wrote: > samsung-laptop is not at all related to ACPI, but since this interface > is not documented at all, and the driver has to use it at load to > understand how it works on the laptop, I think it's a good idea to > disable it if a better

Re: [patch 0/8] Samsung Laptop driver patches - resend

2011-11-13 Thread Greg KH
On Sun, Nov 13, 2011 at 10:52:29AM +0100, Corentin Chary wrote: > However, I have a quick question: what does "wireless button" control > exactly ? Because my laptop (SwSmi@ one), seems to have a totally > different command to control rfkill (both for bluetooth and wlan). My > guess is that command

Re: [patch 0/8] Samsung Laptop driver patches - resend

2011-11-07 Thread Greg KH
On Sun, Nov 06, 2011 at 11:54:39PM +0100, Corentin Chary wrote: > Just got a 90X3A from Intel and I'll try to take a look at samsung-laptop > since some features are missing (keyboard backlight for example). Try adding your device to this driver. Or, watch out, as newer Samsung devices support ba

Re: [patch 5/8] Platform: Fix error path in samsung-laptop init

2011-09-20 Thread Greg KH
On Tue, Sep 20, 2011 at 02:21:54PM +0200, David Herrmann wrote: > Hi Greg > > On Fri, Sep 2, 2011 at 12:50 AM, wrote: > > samsung_init() should not return success if not all devices are initialized. > > Otherwise, samsung_exit() will dereference sdev NULL pointers and others. > > > > Signed-off-

[patch 0/8] Samsung Laptop driver patches - resend

2011-09-20 Thread Greg KH
Hi Matthew, Here is a resend of the samsung-laptop patches, with the correct authorship info in it. Sorry about the last batch, 'quilt mail' strips them off when sending them out, despite the information being in the original patch. The patches are against Linus's current tree, but should apply

[patch 3/8] Platform: samsung_laptop: samsung backlight for R528/R728

2011-09-20 Thread Greg KH
From: Smelov Andrey patch works for me, but I need to add "acpi_backlight=vendor" to kernel params Signed-off-by: Smelov Andrey Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/samsung-laptop.c |9 + 1 file changed, 9 insertions(+) --- a/drivers/platform/x

[patch 8/8] Platform: fix samsung-laptop DMI identification for N220 model

2011-09-20 Thread Greg KH
From: Raul Gutierrez Segales This is a follow-up for commit 78a7539b, which didn't cover the Samsung N220 laptop. With this backlight brightness works nicely on the N220 netbook. Signed-off-by: Raul Gutierrez Segales Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/samsung-laptop.c

[patch 7/8] Platform: Samsung laptop DMI info for NC210/NC110

2011-09-20 Thread Greg KH
From: Jason Stubbs This patch just adds the DMI info for the samsung laptop driver to work with the NC210/NC110. It needs the brightness quirk patch for proper support. Signed-off-by: Jason Stubbs Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/samsung-laptop.c |9 + 1

[patch 6/8] Platform: Brightness quirk for samsung laptop driver

2011-09-20 Thread Greg KH
From: Jason Stubbs On some Samsung laptops the brightness regulation works slightly different. All SABI commands except for set_brightness work as expected. The behaviour of set_brightness is as follows: - Setting a new brightness will only step one level toward the new brightness level. For e

[patch 5/8] Platform: Fix error path in samsung-laptop init

2011-09-20 Thread Greg KH
From: David Herrmann samsung_init() should not return success if not all devices are initialized. Otherwise, samsung_exit() will dereference sdev NULL pointers and others. Signed-off-by: David Herrmann Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/samsung-laptop.c |

[patch 4/8] platform: samsung_laptop: fix samsung brightness min/max calculations

2011-09-20 Thread Greg KH
From: Jason Stubbs The min_brightness value of the sabi_config is incorrectly used in brightness calculations. For the config where min_brightness = 1 and max_brightness = 8, the user visible range should be 0 to 7 with hardware being set in the range of 1 to 8. What is actually happening is that

[patch 2/8] Platform: samsung_laptop: add support for X520 machines.

2011-09-20 Thread Greg KH
From: Tommaso Massimi my samsung laptop would be very happy if you add these lines to the file drivers/platform/x86/samsung-laptop.c Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/samsung-laptop.c |9 + 1 file changed, 9 insertions(+) --- a/drivers/platfor

[patch 1/8] platform: samsung_laptop: add dmi information for Samsung R700 laptops

2011-09-20 Thread Greg KH
From: Stefan Beller My DMI model is this: >dmesg |grep DMI [0.00] DMI present. [0.00] DMI: SAMSUNG ELECTRONICS CO., LTD. SR700/SR700, BIOS 04SR 02/20/2008 adding dmi information of Samsung R700 laptops This adds the dmi information of Samsungs R700 laptops. Signed-off-by: Stefan

Re: [PATCH] Platform: Brightness quirk for samsung laptop driver

2011-09-01 Thread Greg KH
On Fri, Aug 26, 2011 at 01:31:38PM +0200, David Herrmann wrote: > On Fri, Aug 26, 2011 at 11:58 AM, Jason Stubbs wrote: > > From: Jason Stubbs > > > > On some Samsung laptops the brightness regulation works slightly different. > > All SABI commands except for set_brightness work as expected. The

Re: [PATCH] Platform: Brightness quirk for samsung laptop driver

2011-08-25 Thread Greg KH
On Thu, Aug 25, 2011 at 01:27:26PM +1000, Jason Stubbs wrote: > On 08/25/2011 09:10 AM, Greg KH wrote: > >On Tue, Aug 23, 2011 at 06:05:27PM +0200, David Herrmann wrote: > >>From: Jason Stubbs > >> > >>On some samsung laptops the brightness regulation wo

Re: [PATCH] Platform: Brightness quirk for samsung laptop driver

2011-08-24 Thread Greg KH
On Tue, Aug 23, 2011 at 06:05:27PM +0200, David Herrmann wrote: > From: Jason Stubbs > > On some samsung laptops the brightness regulation works slightly different. > All SABI commands except for set_brightness work as expected. The behaviour > of set_brightness is as follows: > > - Setting a ne

Re: [RFC 1/5] platform-drivers-x86: add support for Technologic Systems TS-5xxx detection

2011-05-03 Thread Greg KH
On Tue, May 03, 2011 at 10:39:19AM +0100, Alan Cox wrote: > > > I had a look at other drivers, and /sys/devices/platform/ts/ seems to be > > > a good place to hold those entries (one per options as you suggested). > > > Do you agree with that? > > > > No, this is not a platform device, is it? Onl

Re: [RFC 1/5] platform-drivers-x86: add support for Technologic Systems TS-5xxx detection

2011-05-02 Thread Greg KH
On Mon, May 02, 2011 at 05:07:29PM -0400, Vivien Didelot wrote: > Hi, > > Thanks you all for your comments, I'll consider them carefully. > > Excerpts from Greg KH's message of 2011-04-29 19:32:30 -0400: > > On Fri, Apr 29, 2011 at 06:21:48PM -0400, Vivien Didelot wrote: > > > +/proc filesystem >

Re: [RFC 1/5] platform-drivers-x86: add support for Technologic Systems TS-5xxx detection

2011-04-29 Thread Greg KH
On Fri, Apr 29, 2011 at 06:21:48PM -0400, Vivien Didelot wrote: > +/proc filesystem > + > + > +Information about the TS board is available through the /proc/ts-sbcinfo. Really? Why? As you now have added a new kernel/user ABI, it must be documented in Documentation/ABI/ Please i

Re: [PATCH 0/4] Fix up samsung-laptop.c duplication

2011-04-08 Thread Greg KH
On Fri, Apr 08, 2011 at 05:02:02PM +0200, Michal Marek wrote: > Hi, > > The samsung-laptop.c driver got merged into drivers/platform/x86/, but a > copy also stayed in drivers/staging and further fixes got applied there. > A parallel build decides randomly which version to link into > samsung-lapto

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread Greg KH
On Tue, Mar 15, 2011 at 07:50:28AM -0400, James Bottomley wrote: > On Mon, 2011-03-14 at 20:09 -0700, Greg KH wrote: > > On Mon, Mar 14, 2011 at 10:26:05PM -0400, James Bottomley wrote: > > > On Sat, 2011-03-12 at 23:23 +0300, Vasiliy Kulikov wrote: > > > > > Vasi

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-14 Thread Greg KH
On Mon, Mar 14, 2011 at 10:26:05PM -0400, James Bottomley wrote: > On Sat, 2011-03-12 at 23:23 +0300, Vasiliy Kulikov wrote: > > > Vasiliy Kulikov (20): > > > mach-ux500: mbox-db5500: world-writable sysfs fifo file > > > leds: lp5521: world-writable sysfs engine* files > > > leds: lp5523: world-

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-13 Thread Greg KH
On Sun, Mar 13, 2011 at 07:49:04PM +0200, Nikolai Kondrashov wrote: > On 03/13/2011 06:18 PM, Greg KH wrote: > >I really don't know, sorry. Try messing with the actual_brightness file > >instead, that's the one to use. > Sure, thank you :) > > Still, what ab

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-13 Thread Greg KH
On Sun, Mar 13, 2011 at 03:02:00PM +0200, Nikolai Kondrashov wrote: > On 03/13/2011 12:55 PM, Richard Schütz wrote: > >That sounds like the driver is interfering with the ACPI video driver. > >Add "acpi_backlight=vendor" to your kernel boot parameters and try again. > Thank you, this helped :) > >

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-13 Thread Greg KH
On Sun, Mar 13, 2011 at 12:03:20PM +0200, Nikolai Kondrashov wrote: > Sometime ago I've found this hack on some forum, which I use currently > to set the brightness: > > setpci -s 00:02.0 f4.b="$HEX_BYTE" > > It allows finer control of the brightness, but it seems it operates directly > on the vi

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-11 Thread Greg KH
On Fri, Mar 11, 2011 at 10:23:41PM +0200, Nikolai Kondrashov wrote: > On 03/11/2011 10:20 PM, Nikolai Kondrashov wrote: > >It fails to insert without "force" with the same message. With force it > >installs, but doesn't seem to work, at least for brightness buttons. > Oh, and upon insertion both ba

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-11 Thread Greg KH
On Fri, Mar 11, 2011 at 10:20:41PM +0200, Nikolai Kondrashov wrote: > On 03/11/2011 09:34 PM, Greg KH wrote: > >Ok, this shows you are not loading the driver I sent to you, this is the > >"original" one I sent, which will fail for your machine. > Sorry, I didn'

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-11 Thread Greg KH
On Fri, Mar 11, 2011 at 07:44:22PM +, Matthew Garrett wrote: > On Fri, Mar 11, 2011 at 11:35:12AM -0800, Greg KH wrote: > > On Fri, Mar 11, 2011 at 05:43:39PM +, Matthew Garrett wrote: > > > Applied, thanks. > > > > Great, any pointers to where it was applie

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-11 Thread Greg KH
On Fri, Mar 11, 2011 at 05:43:39PM +, Matthew Garrett wrote: > Applied, thanks. Great, any pointers to where it was applied? I think I need to send you a few more 'add a new device id' patches and I want to make sure I get the right version to patch against. thanks, greg k-h -- To unsubscri

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-11 Thread Greg KH
On Fri, Mar 11, 2011 at 09:07:15PM +0200, Nikolai Kondrashov wrote: > On 03/11/2011 07:03 PM, Greg KH wrote: > >Are you sure this was the driver you just built that I sent you? Can > >you send the output of 'modinfo samsung-laptop'? > Yes, I'm pretty

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-11 Thread Greg KH
On Fri, Mar 11, 2011 at 09:12:07AM +0200, Nikolai Kondrashov wrote: > On 03/10/2011 11:15 PM, Greg KH wrote: > >Are you sure the driver is loaded? > It doesn't load - it fails on inserting. > I should've probably reminded you that in my recent messages. > > >Wha

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-10 Thread Greg KH
On Thu, Mar 10, 2011 at 11:05:09PM +0200, Nikolai Kondrashov wrote: > On 03/10/2011 08:09 PM, Greg KH wrote: > >Great, here's a new version of the samsung-laptop.c file, can you > >replace it whereever you were building the previous one, rebuild it and > >test it for

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-10 Thread Greg KH
On Thu, Mar 10, 2011 at 07:28:00PM +0200, Nikolai Kondrashov wrote: > On 03/10/2011 07:19 PM, Greg KH wrote: > >Can you provide me the output of: > > grep . /sys/class/dmi/id/* > >so I can try to add support for this machine to the driver? > Sure, here it is. Great,

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-10 Thread Greg KH
On Thu, Mar 10, 2011 at 07:13:14PM +0200, Nikolai Kondrashov wrote: > Hi Greg, > > On Thu, Mar 10, 2011 at 7:01 PM, Greg KH wrote: > > Ok, then I'm afraid that this driver will not support your laptop, > > sorry. > Oh, heck! I forgot I've upgraded my netbook to

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-03-10 Thread Greg KH
On Thu, Mar 10, 2011 at 09:00:36AM +0200, Nikolai Kondrashov wrote: > Hi Greg, > > On 02/26/2011 12:50 AM, Greg KH wrote: > >On Sat, Feb 26, 2011 at 12:49:17AM +0300, Nikolai Kondrashov wrote: > >>On 02/26/2011 12:03 AM, Greg KH wrote: > >>>This should wo

Re: [stable] [PATCH] [stable-37] ideapad: read brightness setting when have brightness key notify

2011-03-07 Thread Greg KH
On Tue, Mar 08, 2011 at 10:37:41AM +0800, Ike Panhc wrote: > On 03/08/2011 12:18 AM, Greg KH wrote: > > On Mon, Mar 07, 2011 at 06:35:25PM +0800, Ike Panhc wrote: > >> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=25922 > >> > >> On ideapad Y530, the brig

Re: [stable] [PATCH] [stable-37] ideapad: read brightness setting when have brightness key notify

2011-03-07 Thread Greg KH
On Mon, Mar 07, 2011 at 06:35:25PM +0800, Ike Panhc wrote: > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=25922 > > On ideapad Y530, the brightness key notify will be blocked if the last notify > is not responsed by getting the brightness value. Read value when we get the > notify shall fi

[PATCH] Platform: add Samsung Laptop platform driver

2011-03-04 Thread Greg KH
From: Greg Kroah-Hartman This adds the samsung-laptop driver to the kernel. It now supports all known Samsung laptops that use the SABI interface. Signed-off-by: Greg Kroah-Hartman --- Documentation/ABI/testing/sysfs-driver-samsung-laptop | 19 drivers/platform/x86/Kconfig

[PATCH] Platform: add Samsung Laptop platform driver

2011-02-27 Thread Greg KH
From: Greg Kroah-Hartman This adds the samsung-laptop driver to the kernel. It now supports all known Samsung laptops that use the SABI interface. Signed-off-by: Greg Kroah-Hartman --- Documentation/ABI/testing/sysfs-driver-samsung-laptop | 19 drivers/platform/x86/Kconfig

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-02-25 Thread Greg KH
On Sat, Feb 26, 2011 at 12:49:17AM +0300, Nikolai Kondrashov wrote: > On 02/26/2011 12:03 AM, Greg KH wrote: > >This should work, as we support the N150/N210/N220 versions. > > > >Can you provide the output of: > > grep ./sys/class/dmi/id/* > > > >so I

[PATCH] Platform: add Samsung Laptop platform driver

2011-02-25 Thread Greg KH
From: Greg Kroah-Hartman This adds the samsung-laptop driver to the kernel. It now supports all known Samsung laptops that use the SABI interface. Signed-off-by: Greg Kroah-Hartman --- Documentation/ABI/testing/sysfs-driver-samsung-laptop | 19 drivers/platform/x86/Kconfig

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-02-25 Thread Greg KH
On Wed, Feb 16, 2011 at 01:06:00PM +0300, Nikolai Kondrashov wrote: > Hi Greg, > > On 02/10/2011 01:40 AM, Greg KH wrote: > > This adds the samsung-laptop driver to the kernel. It now supports > > all known Samsung laptops. > Thank you for this patch :)! > > I&#x

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-02-25 Thread Greg KH
On Fri, Feb 11, 2011 at 05:27:19PM +0100, Richard Schütz wrote: > Add DMI data for Samsung N145P/N250P/N260P > > Signed-off-by: Richard Schütz > --- > > >Yes I can, but do you want to send it to me in a format that I can apply > >so you can get the proper authorship credit? > > Of course, here

Re: [PATCH] Platform: Samsung Q10 backlight driver

2011-02-16 Thread Greg KH
On Wed, Feb 16, 2011 at 11:30:29PM +, Frederick van der Wyck wrote: > This adds backlight control on the Samsung Q10 laptop, which does not support > the SABI interface. Also tested successfully on the Dell Latitude X200. > > Signed-off-by: Frederick van der Wyck > --- > drivers/platform/x8

Re: [PATCH] Platform: add Samsung Laptop platform driver

2011-02-11 Thread Greg KH
On Fri, Feb 11, 2011 at 03:45:08PM +, Matthew Garrett wrote: > On Wed, Feb 09, 2011 at 02:40:06PM -0800, Greg KH wrote: > > > +/* Structure to get data back to the calling function */ > > +struct sabi_retval { > > + u8 retval[20]; > > +}; > > 20 bytes,

  1   2   >